Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "b6"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Batch 6. Implements the #985 decisions and the three approved mockups.
account-not-allowed,account-expiredandpassword-change-required; the AD 532/773 path stays off until the real-DC test.auth.genericSigninErrors,auth.passwordChangeUrl,auth.signinHelp,auth.signinHelpUrl.auth-signin-refused./login?refused=not-allowed|failed|idp|removedwith "Sign out of single sign-on".findGroupfix (#987).directory-locked, and the #990 guard.tls.expiryWarn/tls.expiryCriticalwith the lifetime rule, sharedtlsstatus.json, bell items and thecertificatesmute, metrics.serviceAccountvalues (#994).device-pauses.jsonshared across instances.Reviews: per-task reviews plus a final whole-branch review in
.superpowers/sdd/2026-10-25-batch6/.Follow-ups: #1001, #1002, #1003 (v0.6.355).
- ErrAccountRefused (wraps ErrUnauthenticated) with RefusedError {Reason, Source, User, Code}: LDAP not-allowed and account-expired, local disabled (ErrAccountDisabled is now one), AD 532/773 behind the unexported adPasswordChangeConfirmed switch (off until #741), app passwords of refused accounts. Carried through the LDAP single flight. - POST /auth/password: 403 account-not-allowed, account-expired, password-change-required (+ passwordChangeUrl), account-disabled; auth.genericSigninErrors answers them exactly like a wrong password. - Throttle option D: refusals spend the bucket (same delays, 429 at 20, own auth-throttled note) but never the failures notice, bell limit items, spray detection or the client-address alarm; Throttle.Clear on re-admission (OnResume). - Audit verb auth-signin-refused (signin, admin tier), folded per user, reason and hour. - #992: refused-credential cache for AD 52e (HMAC fingerprint, per process key, ldapCacheTTL, bounded, cleared on a successful bind); client address and client class in the AD refusal line. - Config auth.genericSigninErrors, auth.passwordChangeUrl, auth.signinHelp, auth.signinHelpUrl (+ env); /auth/mode carries the help fields.Keep U3's insecureLdapCard / insecureLdapCardNode(kind, opts{L, doc, copy, url, instances, only, onOpen}) and call it from Users & access with onOpen: certOpen (Open Certificates). Remove U2's duplicate builder, its LDAP_GUIDE constant, its copy of the certLdap* / certOpenTopic strings (U3's copies match mockup C) and the unused certLdapKInst key (the card uses certKInst), and U2's copy of the .cajump CSS rule. dirfacts985.test.js: the pure insecureLdapCard is no longer in the pure:dir-facts block (certs985.test.js covers it), so the U2 test pins the Users & access call site instead.