Space keys: a migrated space that never had a key shows "missing / Recovery only" instead of "new" #1018

Closed
opened 2026-10-26 22:55:31 +00:00 by Cordy · 2 comments
Owner

Found in the v0.6.358 live check (2026-10-26).

What happens: the stage-3 move (#1002) writes missing for every space where no old key was found. On the dogfoods that is mostly spaces nobody ever uploaded to, so they never had a key:

  • files-bao: 8 of 13 missing (Fall 1, Fall 2, Test Ümlauf folderinö, cairn-admins, case-folder-1, qa656, test new space 2, test5). All of them are 0 bytes in the admin inventory.
  • files: 2 of 6 missing (Café-922, which has been recovery-only since v0.6.356, and cairn-admins).

The UI shows these as "Recovery only" and counts them in Needs attention. That is alarming and wrong for an empty space. A first upload creates the holder (spacekeys.go byID, createHolder), so nothing is lost. Only the state and the wording are wrong.

Proposal (to decide): at the move, a space where nothing was found and whose folder holds no stored file (trash and version history included) gets new, the D-S12 state ("key made at first upload", not attention). missing stays for spaces that hold files but have no key. The fixture expectation "files-bao 12 copied" in the plan was wrong for the same reason.

Not a data risk: Check keys passed 5/5 (files-bao) and 4/4 (files), and every file in the visible spaces opens.

Found in the v0.6.358 live check (2026-10-26). **What happens:** the stage-3 move (#1002) writes `missing` for every space where no old key was found. On the dogfoods that is mostly spaces nobody ever uploaded to, so they never had a key: - files-bao: 8 of 13 missing (Fall 1, Fall 2, Test Ümlauf folderinö, cairn-admins, case-folder-1, qa656, test new space 2, test5). All of them are 0 bytes in the admin inventory. - files: 2 of 6 missing (Café-922, which has been recovery-only since v0.6.356, and cairn-admins). The UI shows these as "Recovery only" and counts them in Needs attention. That is alarming and wrong for an empty space. A first upload creates the holder (`spacekeys.go` `byID`, `createHolder`), so nothing is lost. Only the state and the wording are wrong. **Proposal (to decide):** at the move, a space where nothing was found and whose folder holds no stored file (trash and version history included) gets `new`, the D-S12 state ("key made at first upload", not attention). `missing` stays for spaces that hold files but have no key. The fixture expectation "files-bao 12 copied" in the plan was wrong for the same reason. Not a data risk: Check keys passed 5/5 (files-bao) and 4/4 (files), and every file in the visible spaces opens.
Author
Owner

Decision (Nikola, 2026-10-27): yes. When the key move finds no key for a space whose folder holds no stored file (trash and version history included), the space gets new ("key made at first upload", not counted in Needs attention). missing stays for spaces that hold files but have no key. Planned for batch R3.

**Decision (Nikola, 2026-10-27):** yes. When the key move finds no key for a space whose folder holds no stored file (trash and version history included), the space gets `new` ("key made at first upload", not counted in Needs attention). `missing` stays for spaces that hold files but have no key. Planned for batch R3.
Cordy closed this issue 2026-10-27 03:15:06 +00:00
Author
Owner

Shipped in v0.6.360 and live on both dogfoods (2026-10-27). The first pass after the rollout (about 30 s after start) logged:

  • files: space keys: spaces without a key re-classified by whether their folder holds a stored file new=1 missing=0 (cairn-admins). Café-922 stays missing, because it holds files.
  • files-bao: ... new=8 missing=0, covering the eight empty spaces listed above.
**Shipped in v0.6.360 and live on both dogfoods (2026-10-27).** The first pass after the rollout (about 30 s after start) logged: - files: `space keys: spaces without a key re-classified by whether their folder holds a stored file new=1 missing=0` (cairn-admins). Café-922 stays `missing`, because it holds files. - files-bao: `... new=8 missing=0`, covering the eight empty spaces listed above.
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#1018
No description provided.