v0.6.367: space links by space id (#1034), OIDC client certificate (#996), sign-in pauses with a roles claim (#1001) #1037

Merged
Cordy merged 10 commits from ri1 into main 2026-10-28 12:25:53 +00:00
Owner

Batch I1, decisions in the issue comments of 2026-10-28.

  • #1034 (security): public links on space content are bound to the space id + path inside it; served by id (deleted/unknown 404, moving 503, missing 404 + WARN); start migration binds old links, refused or unmatched ones stop serving and show "Space not found" to admins.
  • #996: private_key_jwt for the OIDC sign-in client (auth.oidcClientCertDir, hot reload, Entra PS256 + x5t#S256, expiry WARN + metric, facts block). Tested against a fake IdP; Entra and Keycloak live checks in #1005.
  • #1001: Keycloak + a non-groups claim: a refused sign-in pauses app passwords until the next accepted sign-in.

Three reviews, three fix rounds; full suite, vet, gofmt and web suite green locally.

Batch I1, decisions in the issue comments of 2026-10-28. - #1034 (security): public links on space content are bound to the space id + path inside it; served by id (deleted/unknown 404, moving 503, missing 404 + WARN); start migration binds old links, refused or unmatched ones stop serving and show "Space not found" to admins. - #996: private_key_jwt for the OIDC sign-in client (`auth.oidcClientCertDir`, hot reload, Entra PS256 + x5t#S256, expiry WARN + metric, facts block). Tested against a fake IdP; Entra and Keycloak live checks in #1005. - #1001: Keycloak + a non-groups claim: a refused sign-in pauses app passwords until the next accepted sign-in. Three reviews, three fix rounds; full suite, vet, gofmt and web suite green locally.
A refused OIDC sign-in pauses the person's app passwords wherever
oidcAllowedGroups is set and no re-check reads the allowed groups
(Entra, no admin client, Keycloak with oidcGroupsClaim other than
groups). The pause carries until=sign-in in device-pauses.json: the
re-check, appValid and the daily sweep leave it standing (decided on the
file as read, #742), the sweep never purges it; an accepted sign-in or
the #1003 safety stop lifts it. New start WARN text.
auth.oidcClientCertDir (CAIRN_OIDC_CLIENT_CERT_DIR) with tls.key (+ tls.crt,
required on Entra), re-read like tls.certDir; a fresh signed assertion per
token request (RS256/PS256/ES256, x5t#S256, optional kid, aud auto/issuer/
token-endpoint) sent in the form with no secret. Secret and directory both
set, bad or expired pair, Entra with a non-RSA or short key: refuse start.
Discovery WARN without private_key_jwt, expiry WARN and gauge
cairn_oidc_client_cert_expiry_days, AADSTS code and clock skew on
invalid_client, facts block clientAuth/clientCert and the Client row.
Links on space content store the space id and the path inside the space
(created through scope ResolveSpace) and are served from the folder the
registry names for that id (scope SpaceLinkRoot): a rename's convergence
keeps them; a retired former name or a purged space's name taken by
another space never reaches that space (no file, no upload, no listing).
Unknown or deleted space 404 (folder never made), moving folder 503
space-folder-moving Retry-After 30, missing folder 404 with the #961 WARN;
a restore brings the links back. Start migration binds old links by
folder, else by a living former name (share-link-bound), marks the rest
unbound (share-link-unbound, WARN); unbound links never serve and show as
space not found in the admin share list and report. Flat mode unchanged.
Cordy merged commit 9486b67e87 into main 2026-10-28 12:25:53 +00:00
Cordy deleted branch ri1 2026-10-28 12:25:57 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#1037
No description provided.