Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "lf835"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #835, #1045.
SDD with TDD per task, wave reviews, fix rounds, final whole-branch review + focused re-review of the guard fixes (release-ready).
- POST /api/v1/rename: a PersonalShareMoveOutError answers 409 personal-share-move-out {code, error, shares, grants, links, items}; endShares carries storage.WithEndShares as for spaces. - writeErr and davError: ErrPersonalShareMoveOut is 403 with X-Cairn-Code personal-share-move-out and the error's text. - DELETE /api/v1/files answers 200 {"deleted","sharesPaused"} (trash on) or {"deleted","sharesEnded"} (trash off), counted by the new Handler.ShareCount at the backend path before the delete (D-f). - Deleted files lists carry "shares" {grants, links} per entry from the new TrashAPI.EntryShares (personal entries by trash.PersonalEntryID); restore answers gain sharesResumed, purges answer 200 {"sharesEnded"}. Existing tests changed (reason: spec 8 / D-f, the delete and purge answers are now 200 with a body; the restore body gains sharesResumed): lifecycle1035_test.go (REST delete 204 -> 200), purgeaudit920_test.go, purgeaudit926_test.go, restorefeed920_test.go, spacebc935_test.go, spacedelete935_test.go, spacefinal4_test.go, spacekeys1002s3_test.go, spacelink1034_test.go, spacepurge964_test.go, spacerestore935fix_test.go, spacerestore935fix2_test.go, trashaudit911_test.go (purge 204 -> 200), rename908_test.go and trash911_test.go (restore body gains sharesResumed).Frames D1 to D3, F1 and F2 of the approved mockup: state chips (icon, text, tip as description) on my links and shares, Copy link dimmed for paused-trash, item-missing and item-replaced, a grant's state in place of its role select, "from <person>" on handed-over rows, Turn on (POST /api/v1/shares/{token}/resume) with focus kept on the row's Copy link, the Handed over to you filter and notices, the share-links-handed and share-item-replaced bells, notifPrefShareActivityD as approved. Existing test changed: web/test/devices900fix.test.js passes lfBellSh to the lifted renderBell body (renderBell now asks the #835 bells after shareBellText; the test supplied every other free name already).