Bulk Copy to, Move to, Add to favourites and Delete act on the wrong list in search, Favourites and Recents #1112

Closed
opened 2026-11-04 05:06:25 +00:00 by Cordy · 4 comments
Owner

Found in the #1097 research (2026-11-04, scratch/b7e/backlog/research-1097-unsettled.md U6). The selection bar's bulk actions filter the folder listing (fbItems) instead of the rows the current view drew, at web/static/index.html:13489 (Delete) and :13509 (Copy to, Move to, Add to favourites) at 0e0885db. In search results, Favourites and Recents, selected items that are not in the current folder's listing are silently skipped, so the action does nothing or only part of the job.

No data loss: only selected items are ever touched. #1097 adds selViewItems() for Download; reuse it (or fbViewItems, which keeps the drawn order) for these actions, with tests for each view.

Found in the #1097 research (2026-11-04, `scratch/b7e/backlog/research-1097-unsettled.md` U6). The selection bar's bulk actions filter the folder listing (`fbItems`) instead of the rows the current view drew, at `web/static/index.html:13489` (Delete) and `:13509` (Copy to, Move to, Add to favourites) at 0e0885db. In search results, Favourites and Recents, selected items that are not in the current folder's listing are silently skipped, so the action does nothing or only part of the job. No data loss: only selected items are ever touched. #1097 adds `selViewItems()` for Download; reuse it (or `fbViewItems`, which keeps the drawn order) for these actions, with tests for each view.
Author
Owner

Research done (Phase 1, read only, main 666c3d3b): scratch/b7e/backlog/research-1112.md.

Findings:

  • Confirmed. Delete (index.html:14424) and Copy to, Move to and Add to favourites (items() at :14444) filter currentItems, the last folder loaded. Download already uses selViewItems(), the rows drawn in the order drawn (#1097).
  • Worse than reported: after each of the four actions the page runs load(cwd) (:14437, :14470, and in cfFlow at :18412). That sends you from search, Favourites or Recents back to the folder and clears the search. The single-row Delete does the same (:18252).
  • Add to favourites always says "Added to favourites", even when every star failed, for example at the 200 cap (409). Bulk Delete reports failures as "Delete failed: 2".
  • Market: Nextcloud had the same class of bug (#48708, empty ZIP from Recents). Its NC 32 batch bar also failed silently ("nothing happens"). Lesson: every bulk click answers with a line.

Recommended: all four actions use one list, selViewItems(). After the action you stay in the view: deleted or moved-away rows leave in place, moved rows show their new path, and focus goes to the neighbour (as leaveDropRows already does). Results are honest and per item, in one spoken line (WCAG 4.1.3, 3.3.1). The Delete confirm lists the items when they come from several folders (3.3.4). No server change, nothing new to share across instances (#742).

Open questions (each with a recommendation in the file): Q1 stay in the view (yes), Q2 where the picker starts (the common parent, else the last folder), Q3 list the items in the Delete confirm for mixed views (yes, needs one mockup frame), Q4 "Remove from favourites" in the Favourites view (yes, reuses rmFav), Q5 show paused or ended records after a bulk delete (yes). New strings: up to 7 (EN/DE/FR/IT drafts in the file).

Research done (Phase 1, read only, main 666c3d3b): `scratch/b7e/backlog/research-1112.md`. Findings: - Confirmed. Delete (`index.html:14424`) and Copy to, Move to and Add to favourites (`items()` at `:14444`) filter `currentItems`, the last folder loaded. Download already uses `selViewItems()`, the rows drawn in the order drawn (#1097). - Worse than reported: after each of the four actions the page runs `load(cwd)` (`:14437`, `:14470`, and in `cfFlow` at `:18412`). That sends you from search, Favourites or Recents back to the folder and clears the search. The single-row Delete does the same (`:18252`). - Add to favourites always says "Added to favourites", even when every star failed, for example at the 200 cap (409). Bulk Delete reports failures as "Delete failed: 2". - Market: Nextcloud had the same class of bug (#48708, empty ZIP from Recents). Its NC 32 batch bar also failed silently ("nothing happens"). Lesson: every bulk click answers with a line. Recommended: all four actions use one list, `selViewItems()`. After the action you stay in the view: deleted or moved-away rows leave in place, moved rows show their new path, and focus goes to the neighbour (as `leaveDropRows` already does). Results are honest and per item, in one spoken line (WCAG 4.1.3, 3.3.1). The Delete confirm lists the items when they come from several folders (3.3.4). No server change, nothing new to share across instances (#742). Open questions (each with a recommendation in the file): Q1 stay in the view (yes), Q2 where the picker starts (the common parent, else the last folder), Q3 list the items in the Delete confirm for mixed views (yes, needs one mockup frame), Q4 "Remove from favourites" in the Favourites view (yes, reuses `rmFav`), Q5 show paused or ended records after a bulk delete (yes). New strings: up to 7 (EN/DE/FR/IT drafts in the file).
Author
Owner

Decisions (Nikola, 2026-11-05): all research recommendations approved. Bulk actions use the rows on screen (as Download does since #1097); the view stays (search, Favourites, Recents) after the action; the folder picker starts at the selection's common parent; the Delete confirm lists the items when they come from several folders (one mockup frame); Favourites shows "Remove from favourites"; failures get one honest status line; records paused or ended by a bulk delete are reported as for a single delete. Next: mockup frame and new strings for approval, then build in batch 2.

**Decisions (Nikola, 2026-11-05):** all research recommendations approved. Bulk actions use the rows on screen (as Download does since #1097); the view stays (search, Favourites, Recents) after the action; the folder picker starts at the selection's common parent; the Delete confirm lists the items when they come from several folders (one mockup frame); Favourites shows "Remove from favourites"; failures get one honest status line; records paused or ended by a bulk delete are reported as for a single delete. Next: mockup frame and new strings for approval, then build in batch 2.
Author
Owner

Mockup approved (Nikola, 2026-11-06): b2-bulk-and-tag-search-mockup.html, all frames, the 10 new strings and open points 1-7 as recommended: British "favourites" everywhere (6 existing English strings change, style guide line added); bulk delete line with the count after a colon; failed rows stay selected; left-out items as an amber row in the Delete confirm and at the head of the Move status line, the item list in search/Favourites/Recents only; Move also leaves out space rows; tags/find answers cappedBy; after Move focus goes to the first moved row. Server: Add to favourites at the 200 limit answers 409 favorites-limit.

Note on the dark samples: the mockup drew selected rows with the light tint because its dark block did not recompute --sel; fixed in the mockup. The real app is not affected: on the dark theme a selected row measures rgb(27,52,60) behind text rgb(223,231,233), about 11:1 contrast.

**Mockup approved (Nikola, 2026-11-06):** `b2-bulk-and-tag-search-mockup.html`, all frames, the 10 new strings and open points 1-7 as recommended: British "favourites" everywhere (6 existing English strings change, style guide line added); bulk delete line with the count after a colon; failed rows stay selected; left-out items as an amber row in the Delete confirm and at the head of the Move status line, the item list in search/Favourites/Recents only; Move also leaves out space rows; `tags/find` answers `cappedBy`; after Move focus goes to the first moved row. Server: Add to favourites at the 200 limit answers 409 `favorites-limit`. Note on the dark samples: the mockup drew selected rows with the light tint because its dark block did not recompute `--sel`; fixed in the mockup. The real app is not affected: on the dark theme a selected row measures rgb(27,52,60) behind text rgb(223,231,233), about 11:1 contrast.
Cordy closed this issue 2026-11-06 11:01:51 +00:00
Author
Owner

Shipped in v0.6.400 (PR #1136), live on both dogfoods (pods on v0.6.400, ready; one restart each at rollout from an OIDC discovery timeout, filed separately).

  • Copy to, Move to, Add/Remove favourites and Delete act on exactly the rows selected in the list shown (folder, search, Favourites, Recents), in order; a folder plus an item inside it is acted on once.
  • You stay in the view; Load more continues where it was.
  • Left-out items (spaces, items shared with you) are said; the Delete confirm lists the items.
  • One status line per action, spoken once; failed rows stay selected; focus rules as in the approved mockup.

Live UI check is on the #1005 list (needs your sign-in).

Shipped in **v0.6.400** (PR #1136), live on both dogfoods (pods on v0.6.400, ready; one restart each at rollout from an OIDC discovery timeout, filed separately). - Copy to, Move to, Add/Remove favourites and Delete act on exactly the rows selected in the list shown (folder, search, Favourites, Recents), in order; a folder plus an item inside it is acted on once. - You stay in the view; Load more continues where it was. - Left-out items (spaces, items shared with you) are said; the Delete confirm lists the items. - One status line per action, spoken once; failed rows stay selected; focus rules as in the approved mockup. Live UI check is on the #1005 list (needs your sign-in).
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#1112
No description provided.