Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "b4v07"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Batch 4 of v0.7 (b4v07).
Reviews: W1-W3 wave reviews, fix rounds fx1-fx3, whole-branch final review per feature with adversarial probes, final fix round fx4, release round fx5 (Nikola's decisions of 2026-11-09). Strings approved 2026-11-08/09. Local verification at
934cbd81: go build/vet/gofmt clean; internal/api and cmd/cairnd full; all touched packages; deploy, audit, webcheck, config; web suite 2288/2288; all 64 a11y files ok.internal/preview/pdfium renders page 1 of a PDF with go-pdfium v1.21.4 (webassembly backend, wazero v1.12.0) under the decided sandbox rule: fresh module instance per render (ReuseWorkers false, MaxTotal 1), nothing mounted (non-nil empty FSConfig), output discarded, 128 MiB linear memory, 10 s per render with close-on-context-done and Kill, wazero's compiler only (an engine check at New turns PDF off instead of falling back to the interpreter), lazy single-flight compile under its own 120 s limit, a watchdog that retires a module stuck 5 s past its deadline and stops PDF rendering at 2 stuck renders, idle close after 10 min and recycle after 500 renders. internal/preview gains the sentinel errors and the PDFRenderer interface. go.mod/go.sum: scratch/b7e/backlog/gap-v07/pdfium-gomod.diff applied; the go tool then moved wazero to the direct block (imported directly). No other version changed. Builds offline with the repo go.mod. Memory (U2), linux/arm64 sandbox (4 CPU, 3.9 GB), measured in-process with VmHWM (reset per step via clear_refs) and runtime.MemStats; no cgroup limit could be applied (no write access to /sys/fs/cgroup, no systemd user bus, no container runtime). Idle test process 9.7 MB RSS. compile + first small render: peak 335 MB (GOMEMLIMIT off), 308 MB with GOMEMLIMIT=100MiB (live heap, the GC cannot lower it) compiled module resident after GC: 55 MB (+45 MB); after close 25 MB 30 MB PDF (5 noise JPEGs), linear memory 127 MiB (the cap): peak 516-595 MB (GOMEMLIMIT off), 304 MB with GOMEMLIMIT=100MiB 6000x4000 JPEG page: linear memory 51 MiB (PDFium decodes downscaled) Verdict: growth over idle is above 150 MiB (about +300 MB for the compile and for a render at the cap even with GOMEMLIMIT); inside a 256Mi limit the first compile would be OOM-killed. amd64 not measured here. Test binary (go test -c, linux/arm64): 19.5 MB vs 12.9 MB for internal/preview (+6.7 MB).T-S2: OpenCache at start touches only ^[0-9a-f]{32}<ext>$, its own cpv-<digits><ext>.tmp files and v0.6.403's tmb-/conv-<digits> temp files; a foreign report.pdf in the folder stays. T-N1: a compound file under an OOXML name is password-protected only when its directory holds EncryptionInfo and EncryptedPackage (bounded directory walk, loops end it); anything else is unreadable. preview.MemLimit: the lowest cgroup v2 memory.max / v1 memory.limit_in_bytes on the process's cgroup path, 0 when unlimited or unknown (t5 reports it as memLimit).The optional notices (share-received, space-added, link-ending) go to a per-process worker (1,024) that reads the prefs record fresh and queues with Prio sharing; SendLink queues one link-sent record per address with the key part sealed (link-key, aad the record id); PreviewLink renders without queueing (meta CSP, data: logo, dummy b1/u1 tokens, #...); SharingPass on the sender lease holder mails upload batches (Mailed with the seen batch) and the daily and weekly summaries. Sharing messages: From {sender} via {instance}, Reply-To the person, List-Unsubscribe on optional kinds over https with the host punycoded, the brand logo as an inline part; link-mail-failed bell for given-up link e-mails; audit Path the sender for link-sent; HeldBack WARN every 10 minutes.Basic settings gains a third APG tab, Branding and legal (frames A1 to A3): the instance name moved from General (counted in characters after NFC, no maxlength), logo, dark logo and browser icon uploaded on choose or drop, imprint and privacy addresses (read-only when pinned), the default accent as a radiogroup, the credit switch, a live preview and its own Save (the main settings form). A named image this instance cannot resolve ({id, missing}) shows empty and its id goes back in the PUT until removed (fx2 B-S1). The Overview gains the Imprint and privacy row (A4); the watermark preview names the address without a name (A5). Existing tests changed for the third tab and the A.1 strings.B1: linkResultShow rebinds the result's Send by e-mail (mailSendResult(made)); Add another link and shareFormPrep reset it (mailSendResult(null)). S3: Escape in the Preview dialog stops at the dialog (native cancel kept). S4: {contact} from me.mail.replyName (absent = ""), else branding.displayName, else the instance name; {instance} from branding.displayName first. S5: bellUploads1 for one file (new string, EN/DE/FR/IT for approval). N1 iframe title set by id via t(); N2 the Copy link no-key panel closes an open Send panel; N3 notification switch PUTs serialised, the body made from the previous answer; N4 shareGroupKind dropped; N5 no upload-mail checkbox before the prefs for accounts without e-mail.WIP: v0.6.404: branding and legal links (#1109), sharing e-mails (#1103), document thumbnails with PDFium (#1101)to v0.6.404: branding and legal links (#1109), sharing e-mails (#1103), document thumbnails with PDFium (#1101)CI's Go 1.26 test binary has no go-pdfium or wazero in its build information, so the cache turned off (reason=build-info) and every compile-cache test failed. Marker version 2 records the sha256 of the WASM bytes compiled (Config.WASM, else go-pdfium's embedded module via linkname), the go-pdfium and wazero path/version/sum lines ("<path> unknown" when absent), GOOS/GOARCH and runtime.Version(). The build-info source is injectable (Renderer.buildInfo).