fix(storage): ErrNotFound wraps fs.ErrNotExist at the sentinel (#153 crashloop, round 2) #164

Merged

Cordy merged 1 commit from fix/notfound-sentinel into main

2026-08-09 04:38:17 +00:00

Cordy commented

2026-08-09 04:37:57 +00:00

Owner

v0.5.3 still crashlooped: Stat has a second, bare return storage.ErrNotFound (the neither-file-nor-directory fallthrough) that bypasses mapS3Err, and Open routes through Stat. Instead of chasing return sites, the sentinel itself now wraps: ErrNotFound = fmt.Errorf("not found: %w", fs.ErrNotExist) — every site, present and future, satisfies both checks; identity comparisons and errors.Is(err, storage.ErrNotFound) unchanged. Hotfix-1's site-local Join reverted to the plain sentinel. Full suite green.

v0.5.3 still crashlooped: `Stat` has a second, bare `return storage.ErrNotFound` (the neither-file-nor-directory fallthrough) that bypasses `mapS3Err`, and `Open` routes through `Stat`. Instead of chasing return sites, the sentinel itself now wraps: `ErrNotFound = fmt.Errorf("not found: %w", fs.ErrNotExist)` — every site, present and future, satisfies both checks; identity comparisons and `errors.Is(err, storage.ErrNotFound)` unchanged. Hotfix-1's site-local Join reverted to the plain sentinel. Full suite green.

Cordy added 1 commit

2026-08-09 04:37:58 +00:00