#552: a disabled dialog button looks disabled (v0.6.209) #562
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix-552d"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found during the live pass over v0.6.208 on files-bao.
The collision check switches the primary button off correctly — verified in the page,
gadd-go.disabled === trueandgren-go.disabled === trueon a clash. But the button carried on rendering as a solid, full-colour primary:getComputedStyle(btn).opacity === "1". It invites the click it is going to ignore.Cause is scope, not logic. Every
:disabledrule inindex.htmlbelonged to something else:Dialog action buttons are none of those —
.dlgactions buttonhad no disabled styling at all, so the state was invisible in every dialog, not just the three the #552 check touches. It simply had not been visible before because nothing disabled a dialog button until v0.6.208.The rule goes beside
.dlgactions button.danger, the global dialog-button family de-scoped in v0.6.203, so the fix lands once for the whole app rather than per dialog — the same call taken then.Web suite green,
node --checkclean, rule asserted outside any@mediablock.