Groups "Used by" gains the real share count (#529 scope addition, extracted)

Cordy commented

2026-09-18 02:38:40 +00:00

Owner

Extraction of the 2026-09-16 scope addition recorded on #529 (comment 5456), so the tracker stays a tracker. The addressee it needed shipped in #570/#571; this is now buildable. The full research (Nextcloud #5586/#25755, groupfolders #2827, ownCloud advisory — no competitor surfaces this) lives in that comment.

Checklist, carried over verbatim in substance

Used by shows a real share count for app-owned and directory groups alike — "4 shares · 1 space · peering" rather than today's reference-only list.
The count is a link, not a dead number: clicking it lists the shared paths with owner and role, so the admin can act rather than go hunting.
Deletion stays fail-closed. A group holding grants cannot be deleted silently: the existing 409 extends to cover grants, naming them.
Membership changes must not destroy shares. Removing a member from a group revokes that person's resolution of group grants (which the resolution model already does — grants address the group, resolution walks membership); it must never delete the grant, and never touch grants owned by third parties.
Internal grants only on group rows — a group cannot hold a public link, and the test asserts the category error is impossible.
Lazy-loaded like member counts; the groups table must not block on a share scan.

Shape

Backend: a per-group grant count (and listing) query over share.Store — grants are AddresseeKind: "group" records, so this is a filter, not a new store. API beside the existing groups endpoints. Frontend: the Used-by cell grows the count + click-through listing; the cell and listing are drawn in mockup batch A (with #572 and #577) before the UI is built.

Closing this is one of the two remaining gates on #529 (the other is #572).

Extraction of the 2026-09-16 scope addition recorded on #529 (comment 5456), so the tracker stays a tracker. The addressee it needed shipped in #570/#571; this is now buildable. The full research (Nextcloud #5586/#25755, groupfolders #2827, ownCloud advisory — no competitor surfaces this) lives in that comment. ## Checklist, carried over verbatim in substance - [ ] **Used by shows a real share count** for app-owned and directory groups alike — "4 shares · 1 space · peering" rather than today's reference-only list. - [ ] **The count is a link**, not a dead number: clicking it lists the shared paths with owner and role, so the admin can act rather than go hunting. - [ ] **Deletion stays fail-closed.** A group holding grants cannot be deleted silently: the existing 409 extends to cover grants, naming them. - [ ] **Membership changes must not destroy shares.** Removing a member from a group revokes that person's resolution of group grants (which the resolution model already does — grants address the group, resolution walks membership); it must never delete the grant, and never touch grants owned by third parties. - [ ] **Internal grants only on group rows** — a group cannot hold a public link, and the test asserts the category error is impossible. - [ ] **Lazy-loaded** like member counts; the groups table must not block on a share scan. ## Shape Backend: a per-group grant count (and listing) query over `share.Store` — grants are `AddresseeKind: "group"` records, so this is a filter, not a new store. API beside the existing groups endpoints. Frontend: the Used-by cell grows the count + click-through listing; **the cell and listing are drawn in mockup batch A** (with #572 and #577) before the UI is built. Closing this is one of the two remaining gates on #529 (the other is #572).

Cordy added this to the v0.7 — Closed beta (dogfood + hardening) milestone

2026-09-18 02:38:40 +00:00

Cordy commented

2026-09-18 10:28:23 +00:00

Author

Owner

Mockup batch A is drawn: batch-a-572-577-598-mockup.html (design folder), blocks 6–7 — the Used-by cell ("4 shares · 1 space · peering", lazy-loaded, "Not used" as a real state), the fail-closed 409 wording naming grants, and the click-through listing (path / owner / role, spaces sectioned separately). One open question flagged: is the drill-down read-only (drawn) or does it get a per-row admin Revoke? Build waits on markup.

Mockup batch A is drawn: `batch-a-572-577-598-mockup.html` (design folder), blocks 6–7 — the Used-by cell ("4 shares · 1 space · peering", lazy-loaded, "Not used" as a real state), the fail-closed 409 wording naming grants, and the click-through listing (path / owner / role, spaces sectioned separately). One open question flagged: is the drill-down read-only (drawn) or does it get a per-row admin Revoke? Build waits on markup.

Cordy commented

2026-09-18 11:34:27 +00:00

Author

Owner

Mockup approved (batch A rev 1 blocks 6–7 stand, no markup): compound count cell, lazy-loaded, "Not used" as a real state, fail-closed 409 naming grants, read-only drill-down (path / owner / role, spaces sectioned).

Mockup approved (batch A rev 1 blocks 6–7 stand, no markup): compound count cell, lazy-loaded, "Not used" as a real state, fail-closed 409 naming grants, **read-only** drill-down (path / owner / role, spaces sectioned).

forgejo-actions referenced this issue from a commit

2026-09-18 12:01:31 +00:00

#598: Used-by carries the real share count; group delete is fail-closed

Cordy referenced this issue

2026-09-18 12:02:38 +00:00

#598: Used-by real share counts, fail-closed group delete #605

Cordy referenced this issue from a commit

2026-09-18 12:04:57 +00:00

Merge pull request '#598: Used-by real share counts, fail-closed group delete' (#605) from fix-598 into main

forgejo-actions referenced this issue from a commit

2026-09-18 12:18:24 +00:00

changelog: v0.6.216 (#572 send-a-copy, #598 Used-by counts, #577 row chip)

Cordy referenced this issue

2026-09-18 12:18:54 +00:00

changelog: v0.6.216 #607

Cordy commented

2026-09-18 12:27:30 +00:00

Author

Owner

Shipped in v0.6.216 (PR #605), live on both dogfoods. Checklist: real share count in Used-by (lazy GET /api/v1/admin/groups/usage) ✓; count is a click-to-expand listing with path/owner/role ✓; deletion fail-closed with a 409 naming grants ✓; membership changes proven not to touch grants (test) ✓; group rows can only carry internal grants — links excluded at the source, test asserts it ✓; lazy-loaded, never blocks the table ✓. Closing.

Shipped in **v0.6.216** (PR #605), live on both dogfoods. Checklist: real share count in Used-by (lazy `GET /api/v1/admin/groups/usage`) ✓; count is a click-to-expand listing with path/owner/role ✓; deletion fail-closed with a 409 naming grants ✓; membership changes proven not to touch grants (test) ✓; group rows can only carry internal grants — links excluded at the source, test asserts it ✓; lazy-loaded, never blocks the table ✓. Closing.

Cordy closed this issue

2026-09-18 12:27:36 +00:00

Cordy referenced this issue

2026-09-18 12:27:39 +00:00

Federated sharing UX: separate it from the share dialog and design its own flow #529

Rows
Columns

Groups "Used by" gains the real share count (#529 scope addition, extracted) #598

Checklist, carried over verbatim in substance

Shape