QA batch 7a - dark-theme button contrast and dialog canon mechanics (v0.6.256) #705

Merged

Cordy merged 15 commits from fix-qa7 into main

2026-09-23 21:41:25 +00:00

Cordy commented

2026-09-23 21:39:13 +00:00

Owner

Closes #691

Part of #693 (mechanics only): destructive confirms and the name dialog label their primary with the verb instead of OK (i18n ×4), name input gets an accent focus ring, licence dialog puts Close first and spells Licence in en. Left open on #693: fact-row rebuilds of confirmdlg (design work), pickdlg/peeraddlg/peerdetaildlg structure, and removal of the confirmed-dead settingsdlg/auditdlg/holdsdlg trio (openSettings has no callers; boot-time wiring makes removal its own change).

#691: accent-filled controls read the per-theme --accent-on ink instead of hardcoded #fff (the token system already carried correct dark inks per theme and accent variant); .rochip and plainlist greys go through tokens with fallbacks. Danger buttons stay #fff: --danger is not lightened in the dark themes, so white passes AA there.

Pins in web/test/qa7.test.js.

Closes #691 Part of #693 (mechanics only): destructive confirms and the name dialog label their primary with the verb instead of OK (i18n ×4), name input gets an accent focus ring, licence dialog puts Close first and spells Licence in en. Left open on #693: fact-row rebuilds of confirmdlg (design work), pickdlg/peeraddlg/peerdetaildlg structure, and removal of the confirmed-dead settingsdlg/auditdlg/holdsdlg trio (openSettings has no callers; boot-time wiring makes removal its own change). #691: accent-filled controls read the per-theme `--accent-on` ink instead of hardcoded #fff (the token system already carried correct dark inks per theme and accent variant); `.rochip` and `plainlist` greys go through tokens with fallbacks. Danger buttons stay #fff: `--danger` is not lightened in the dark themes, so white passes AA there. Pins in web/test/qa7.test.js.

Cordy added 15 commits

2026-09-23 21:39:13 +00:00

scout: qa7 surfaces (#691 #692 #693 #694 ) d4cb2b2236

scout: qa7 v2 (no pipefail; SIGPIPE-safe) 6133f3389a

scout: qa7 round 2 (dialog canon details) c0ff8d044d

RED: QA batch 7a pins - dark-theme contrast + dialog canon (#691 #693 ) dbb24325dd

GREEN splice: dark-theme contrast + dialog canon (#691 #693 ) 8e934ecfeb

one-shot: QA batch 7a red-green (#691 #693 )

fix-qa7.yml / one-shot: QA batch 7a red-green (#691 #693) (push) Failing after 0s

Details

e5dc1fc1c7

one-shot: fix yaml (no column-0 lines in commit message) 373f001d5f

scout: qa7b splice-failure specifics 5e9a8abf55

RED fix: accent-on count is 11 (3 pre-existing reads) aa8091bb45

splice fix: match t(NEW_KIND_LABELS[kind]) titles; accent-on count is 11 9e43be81eb

one-shot: also clean scout-qa7b 6caf64868d

QA batch 7a - dark-theme button contrast and dialog canon (#691 #693 ) 3928387259

Text on accent fills reads the per-theme --accent-on ink instead of hardcoded #fff (2.0-2.3:1 in the four dark themes); off-token greys on .rochip and plainlist go through tokens with fallbacks. Destructive confirms and the name dialog label their primary with the verb (Delete, Revoke, Delete forever, Remove, Create, Rename - i18n x4) instead of OK; the name input gets an accent focus ring; the licence dialog puts Close first and spells Licence consistently. Deliberately out: fact-row rebuilds of confirmdlg (design work) and removing the dead settingsdlg/auditdlg/holdsdlg trio (boot-time wiring; its own change).

chg-256: changelog entry for v0.6.256 ebd43861cf

one-shot: changelog v0.6.256 14a227d4fb

changelog: v0.6.256

ci / test-and-build (pull_request) Successful in 1m21s

Details

13ea4d68bd