Dialog canon completed - fact-row confirms, structure, dead trio removed (v0.6.258) #707

Merged

Cordy merged 10 commits from fix-693 into main

2026-09-23 22:58:42 +00:00

Cordy commented

2026-09-23 22:56:36 +00:00

Owner

Closes #693

The shared #dangerdlg generalizes spacedeldlg's fact-row canon (.conseq/.crow/.cico/.ctext, now shared selectors): title, icon + sentence rows with bold counts and mono paths, Cancel before a named danger verb. All eight destructive confirms migrate: file delete, bulk delete, link revoke ×2, app-password revoke, delete-forever (with warn row), peer remove, peer-key revoke. askConfirm remains only for the trivial peer enable/disable toggle, per canon.

Structure: peerdetaildlg gains an h2 (peerDetailTitle ×4); peeraddlg/peerdetaildlg/spcdetaildlg swap actions dlgfoot for .dlgactions. #pickdlg is documented as a style-guide exception (its composite footer carries the destination readout; New-folder is a tree action).

Dead trio: settingsdlg/auditdlg/holdsdlg become hidden parking-lot divs — their children are live admin-shell widgets adopted at open (SET_SLOTS / audit + holds slots), so only the dialog chrome and boot wiring (openSettings, set-close/set-save/set-audit/set-holds, audit-close, holds-close) are removed. saveSettings, ensureSettingsInShell and the adm-save-* buttons are untouched.

New i18n ×4: dgRevokeLink, dgRevokePw, dgRemovePeer, dgRevokeKey, dgNoteTrash, dgNoteLink, dgNotePurge, peerDetailTitle.

Pins in web/test/qa693.test.js; qa7.test.js caller-count pins superseded there.

Closes #693 The shared `#dangerdlg` generalizes spacedeldlg's fact-row canon (`.conseq`/`.crow`/`.cico`/`.ctext`, now shared selectors): title, icon + sentence rows with bold counts and mono paths, Cancel before a named danger verb. All eight destructive confirms migrate: file delete, bulk delete, link revoke ×2, app-password revoke, delete-forever (with warn row), peer remove, peer-key revoke. `askConfirm` remains only for the trivial peer enable/disable toggle, per canon. Structure: peerdetaildlg gains an h2 (`peerDetailTitle` ×4); peeraddlg/peerdetaildlg/spcdetaildlg swap `actions dlgfoot` for `.dlgactions`. `#pickdlg` is documented as a style-guide exception (its composite footer carries the destination readout; New-folder is a tree action). Dead trio: `settingsdlg`/`auditdlg`/`holdsdlg` become hidden parking-lot divs — their children are live admin-shell widgets adopted at open (SET_SLOTS / audit + holds slots), so only the dialog chrome and boot wiring (openSettings, set-close/set-save/set-audit/set-holds, audit-close, holds-close) are removed. `saveSettings`, `ensureSettingsInShell` and the `adm-save-*` buttons are untouched. New i18n ×4: dgRevokeLink, dgRevokePw, dgRemovePeer, dgRevokeKey, dgNoteTrash, dgNoteLink, dgNotePurge, peerDetailTitle. Pins in web/test/qa693.test.js; qa7.test.js caller-count pins superseded there.

Cordy added 10 commits

2026-09-23 22:56:37 +00:00

scout: 693 canon reference + dead trio inventory + outlier dialogs 39ca3291c7

scout: 693 round 2 - canon markup + trio spans a77ca8355f

scout: 693 round 3 - peeraddlg footer + icons + spans c9f9b87426

RED: #693 completion pins - dangerdlg, migration, structure, trio removal 883c8e8853

GREEN splice: #693 completion - dangerdlg, migration, structure, trio removal ba8b4eff04

one-shot: #693 completion red-green a19d1df528

Dialog canon completed (#693 ): fact-row destructive confirms, structure, dead trio removed ce70a6a5c1

A shared dangerdlg brings the fact-row canon (icon + sentence with bold counts and mono paths, Cancel before a named danger verb) to every destructive confirm: file and bulk delete, link and app-password revoke, purge, peer remove and key revoke - eight callers leave askConfirm, which keeps only the trivial enable/disable toggle. peerdetaildlg gains a title; the three detail/add dialogs get real .dlgactions bands; pickdlg's composite footer is documented as a style-guide exception. The unreachable settings/audit/holds dialogs become hidden parking-lot divs (their children are live admin-shell widgets moved out at open) and their boot wiring - openSettings, set-close/set-save/set-audit/set-holds, audit-close, holds-close - is removed.

chg-258: changelog entry for v0.6.258 ad11dbd3d5

one-shot: changelog v0.6.258 a601709c77

changelog: v0.6.258

ci / test-and-build (pull_request) Successful in 1m16s

Details

2754db7e50