#724: update check no longer caches "context canceled" from aborted page views #725
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat-724"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #724
The on-demand update check ran its upstream tags fetch on the admin request's own context; a page view aborted mid-check (navigation, closed tab) cancelled the fetch and cached
context canceledas the feed's outcome for 24h.result()now detaches the fetch:context.WithTimeout(context.WithoutCancel(ctx), 30s)— same lifetime the daily poll already uses.refresh()records nothing oncontext.Canceled— news about the caller, not the feed.TestUpdateCheckClientCancelDoesNotPoisonCache(RED-gated on unpatched code in the one-shot).