#724: update check no longer caches "context canceled" from aborted page views #725

Merged
Cordy merged 9 commits from feat-724 into main 2026-09-24 22:45:31 +00:00
Owner

Closes #724

The on-demand update check ran its upstream tags fetch on the admin request's own context; a page view aborted mid-check (navigation, closed tab) cancelled the fetch and cached context canceled as the feed's outcome for 24h.

  • result() now detaches the fetch: context.WithTimeout(context.WithoutCancel(ctx), 30s) — same lifetime the daily poll already uses.
  • refresh() records nothing on context.Canceled — news about the caller, not the feed.
  • Regression test TestUpdateCheckClientCancelDoesNotPoisonCache (RED-gated on unpatched code in the one-shot).
Closes #724 The on-demand update check ran its upstream tags fetch on the admin request's own context; a page view aborted mid-check (navigation, closed tab) cancelled the fetch and cached `context canceled` as the feed's outcome for 24h. - `result()` now detaches the fetch: `context.WithTimeout(context.WithoutCancel(ctx), 30s)` — same lifetime the daily poll already uses. - `refresh()` records nothing on `context.Canceled` — news about the caller, not the feed. - Regression test `TestUpdateCheckClientCancelDoesNotPoisonCache` (RED-gated on unpatched code in the one-shot).
Cordy merged commit d210ca6b40 into main 2026-09-24 22:45:31 +00:00
Cordy deleted branch feat-724 2026-09-24 22:45:34 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#725
No description provided.