Tags: unify tag-search rendering (footer/pills), combobox input with existing-tags dropdown, permissions hint #745

Closed
opened 2026-09-25 16:03:58 +00:00 by Cordy · 0 comments
Owner

Dogfood findings + OpenCloud adoption from the #695/#743 pass (screenshots in chat).

  1. Tag search renders like every other search. runSearch's tag: branch predates #734/#738: it calls renderRows directly, so the "Tagged" view has no summary footer, and the Type/Last-modified pills shown there operate on the previous normal search's rows. Fix: the tag branch feeds searchRaw and calls sfRender() — one rendering path for all searches; footer and pills work on tag results.
  2. Tag combobox in the details pane (OpenCloud-style, the input box Nikola prefers): a bordered field containing the file's current tags as removable chips plus the input; on focus a dropdown lists every tag that already exists on the instance (minus ones already applied), filtered as you type; click adds, Enter creates the typed tag. Kills vocabulary fragmentation ("finance"/"Finance"/"fin"). Server: new GET /api/v1/tags/all → distinct sorted tag list (optional-interface on the store, no TagsStore interface change). No tag glyphs in chips — the box is the adopted part.
  3. Permissions hint: a small "?" beside the Tags label with OpenCloud's honest sentence — everyone who can view the file sees its tags, everyone who can edit it can edit them (matches our existing gating; we just never said it).
Dogfood findings + OpenCloud adoption from the #695/#743 pass (screenshots in chat). 1. **Tag search renders like every other search.** `runSearch`'s `tag:` branch predates #734/#738: it calls `renderRows` directly, so the "Tagged" view has no summary footer, and the Type/Last-modified pills shown there operate on the *previous* normal search's rows. Fix: the tag branch feeds `searchRaw` and calls `sfRender()` — one rendering path for all searches; footer and pills work on tag results. 2. **Tag combobox in the details pane** (OpenCloud-style, the input box Nikola prefers): a bordered field containing the file's current tags as removable chips plus the input; on focus a dropdown lists every tag that already exists on the instance (minus ones already applied), filtered as you type; click adds, Enter creates the typed tag. Kills vocabulary fragmentation ("finance"/"Finance"/"fin"). Server: new `GET /api/v1/tags/all` → distinct sorted tag list (optional-interface on the store, no TagsStore interface change). No tag glyphs in chips — the box is the adopted part. 3. **Permissions hint**: a small "?" beside the Tags label with OpenCloud's honest sentence — everyone who can view the file sees its tags, everyone who can edit it can edit them (matches our existing gating; we just never said it).
Cordy closed this issue 2026-09-25 16:19:05 +00:00
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#745
No description provided.