Spaces UI cleanup: empty image dialog, flex-td borders, checkbox click-through, disabled styling, 0-byte blanks, clipped inventory menu #778

Closed
opened 2026-09-27 12:21:23 +00:00 by Cordy · 0 comments
Owner

Findings from the rev3 checklist drive (Bao dogfood), all frontend:

  1. Space image dialog is unusable — the bare input[type=file] is hidden by a global rule (the avatar pattern pairs a hidden input with a styled button). Dialog shows title + hint + Close and nothing else. Needs a "Choose image…" button that clicks the hidden input.
  2. Overview name cell is display:flex on the <td> — it stops behaving like a table cell (39px vs 45px siblings), its bottom border sits ~6px above the row's. Wrap the flex layout in an inner div.
  3. Clicking the checkbox CELL navigates into the space — the batch-2 stopPropagation on the cell was lost in the batch-3 rewrite; only the input itself is safe. Cell clicks should toggle the checkbox.
  4. Batch-bar Delete looks enabled while disabled — no :disabled styling on .btn/.dangerbtn (opacity 1, cursor pointer).
  5. Storage used renders blank for a measured 0-byte space (fmtSize(0) returns "") — should read "0 B".
  6. Admin inventory row menu (.pmenu) clips below the fold on last rows — needs the qa759 fixed-position viewport-flip canon.
  7. #773 rides along: tiles for spaces show "—" where the subtitle could be.
  8. An empty space in Tiles mode shows nothing at all (empty-state renders only in the list table, which is hidden in grid) — pre-existing, but the overview funnels people there now.

(The dead Modified column on the overview is a data problem — synthetic /spaces listings carry epoch mtimes, and S3 backends cannot answer cheaply; handled in the overview-polish pass, not here.)

Findings from the rev3 checklist drive (Bao dogfood), all frontend: 1. **Space image dialog is unusable** — the bare `input[type=file]` is hidden by a global rule (the avatar pattern pairs a hidden input with a styled button). Dialog shows title + hint + Close and nothing else. Needs a "Choose image…" button that clicks the hidden input. 2. **Overview name cell is `display:flex` on the `<td>`** — it stops behaving like a table cell (39px vs 45px siblings), its bottom border sits ~6px above the row's. Wrap the flex layout in an inner div. 3. **Clicking the checkbox CELL navigates into the space** — the batch-2 `stopPropagation` on the cell was lost in the batch-3 rewrite; only the input itself is safe. Cell clicks should toggle the checkbox. 4. **Batch-bar Delete looks enabled while disabled** — no `:disabled` styling on `.btn`/`.dangerbtn` (opacity 1, cursor pointer). 5. **Storage used renders blank for a measured 0-byte space** (`fmtSize(0)` returns "") — should read "0 B". 6. **Admin inventory row menu (`.pmenu`) clips below the fold** on last rows — needs the qa759 fixed-position viewport-flip canon. 7. **#773** rides along: tiles for spaces show "—" where the subtitle could be. 8. An empty space in Tiles mode shows nothing at all (empty-state renders only in the list table, which is hidden in grid) — pre-existing, but the overview funnels people there now. (The dead Modified column on the overview is a data problem — synthetic /spaces listings carry epoch mtimes, and S3 backends cannot answer cheaply; handled in the overview-polish pass, not here.)
Cordy closed this issue 2026-09-27 12:39:26 +00:00
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#778
No description provided.