Space header: implement the agreed rev3 layout — media tile left, name + kebab, subtitle, description, Members relocated; image is a TILE, not a banner #785

Closed
opened 2026-09-28 01:32:50 +00:00 by Cordy · 0 comments
Owner

Problem (screenshot pair from Nikola's pass): the shipped header renders the space image as a full-width banner above the text — not what rev3 panel 2 ("Slice G") agreed. The mockup shows a compact header block at the space root.

Target layout, exactly per the mockup:

Spaces › test                                      (crumb, unchanged)
┌─────────┐  test  ⋮                    [ 👤 4 members ]
│  tile   │  test description write.              (subtitle, bold)
│ (img/T) │  long description, paragraphs…
└─────────┘
[Upload file] [New] …                              (toolbar as today)

Explicit instructions:

  1. Rework applySpaceHeader() into a two-column flex block (.sphdr): left, a fixed media tile ~150×84 CSS px, rounded 10px — the space image (object-fit: cover) when set, else the initial letter on the --sunk background (same look as the overview's .spovcardinit, scaled up). Right column: an <h1>-weight name line (the space name, ~20px/700) with the space kebab (.acck, RD_DOTS, opens openSpaceMenu with the space's item) directly after it; then .sphsub (subtitle, bold, as today); then .sphdesc (paragraphs, as today). The .sphalias former-name hint stays, above the name line.
  2. Members button relocation: at a space root, hide #spacemembers in the toolbar (extend the existing per-fbview/cwd logic) and render a members button at the header's top-right (same markup/classes as the toolbar button — icon + "Members" or "{n} members" using /meta's count when present), wired to openMembersDialog(name). Only when feat.spaceMembers allows, mirroring today's visibility rule.
  3. Collapse rule changes: at a space root the header ALWAYS shows (tile + name + kebab + members); subtitle/description rows render only when set. Outside space roots: hidden as today.
  4. Delete the full-width .sphimg banner rendering and its CSS; the image lives only in the tile. Keep ?v= cache busting.
  5. The kebab needs the item shape openSpaceMenu expects ({ path: "/spaces/<name>", name, isDir: true, spaceImage, subtitle } — build it from the /meta response + name).
  6. Pins to respect: qa768 (async function applySpaceHeader(, call-site ordering), qa771 (.sphalias, hide-condition), qa770 header-related pins — update any that pin the banner deliberately, in the same push.
  7. i18n: reuse spaceMembers; new key only if a "{n} members" label variant is needed.

Acceptance: on Bao, /spaces/test shows tile (cropped image), "test" + kebab, bold subtitle, description paragraphs, members button top-right; toolbar no longer shows Members at space roots; a space with no cosmetics still shows tile-initial + name + kebab + members; no full-width banner anywhere. This also closes the #779 open question — the rev3 header treatment is the decision.

**Problem (screenshot pair from Nikola's pass):** the shipped header renders the space image as a full-width banner above the text — not what rev3 panel 2 ("Slice G") agreed. The mockup shows a compact header block at the space root. **Target layout, exactly per the mockup:** ``` Spaces › test (crumb, unchanged) ┌─────────┐ test ⋮ [ 👤 4 members ] │ tile │ test description write. (subtitle, bold) │ (img/T) │ long description, paragraphs… └─────────┘ [Upload file] [New] … (toolbar as today) ``` **Explicit instructions:** 1. Rework `applySpaceHeader()` into a two-column flex block (`.sphdr`): left, a fixed media tile ~150×84 CSS px, rounded 10px — the space image (`object-fit: cover`) when set, else the initial letter on the `--sunk` background (same look as the overview's `.spovcardinit`, scaled up). Right column: an `<h1>`-weight name line (the space name, ~20px/700) with the space kebab (`.acck`, `RD_DOTS`, opens `openSpaceMenu` with the space's item) directly after it; then `.sphsub` (subtitle, bold, as today); then `.sphdesc` (paragraphs, as today). The `.sphalias` former-name hint stays, above the name line. 2. Members button relocation: at a space root, hide `#spacemembers` in the toolbar (extend the existing per-fbview/`cwd` logic) and render a members button at the header's top-right (same markup/classes as the toolbar button — icon + "Members" or "{n} members" using `/meta`'s count when present), wired to `openMembersDialog(name)`. Only when `feat.spaceMembers` allows, mirroring today's visibility rule. 3. Collapse rule changes: at a space root the header ALWAYS shows (tile + name + kebab + members); subtitle/description rows render only when set. Outside space roots: hidden as today. 4. Delete the full-width `.sphimg` banner rendering and its CSS; the image lives only in the tile. Keep `?v=` cache busting. 5. The kebab needs the item shape `openSpaceMenu` expects (`{ path: "/spaces/<name>", name, isDir: true, spaceImage, subtitle }` — build it from the `/meta` response + name). 6. Pins to respect: qa768 (`async function applySpaceHeader(`, call-site ordering), qa771 (`.sphalias`, hide-condition), qa770 header-related pins — update any that pin the banner deliberately, in the same push. 7. i18n: reuse `spaceMembers`; new key only if a "{n} members" label variant is needed. **Acceptance:** on Bao, `/spaces/test` shows tile (cropped image), "test" + kebab, bold subtitle, description paragraphs, members button top-right; toolbar no longer shows Members at space roots; a space with no cosmetics still shows tile-initial + name + kebab + members; no full-width banner anywhere. This also closes the #779 open question — the rev3 header treatment is the decision.
Cordy closed this issue 2026-09-28 01:42:51 +00:00
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#785
No description provided.