Bug: files selection bar leaks into non-file views (recents selection shown above the Spaces overview) #788

Closed
opened 2026-09-28 01:33:49 +00:00 by Cordy · 1 comment
Owner

Screenshot evidence from Nikola: select 11 files in Recents, click Spaces — the files selection bar ("Download / Copy to… / Move to… / Delete / Add to favorites · 11 selected") renders above the Spaces overview and its actions would operate on the invisible file selection.

Explicit instructions:

  1. Reproduce first: Recents → select rows → sidebar Spaces. Confirm the #selbar stays visible (body[data-sel="on"] not cleared by setView).
  2. Fix in setView(v): when v is not a files-type view (files/search/recents/favorites — the existing files boolean), clear the file selection: SEL.clear() + whatever applySel()/data-attribute reset the files code uses to hide the bar (scout the exact mechanism; reuse it, don't hand-roll a second one).
  3. Check the reverse path too: overview selection state (spovSel) is already cleared on every openSpacesView() render — verify nothing of it survives into files views after #787's swap mechanism, and add the symmetric clear if it does.
  4. Regression guard in the RED test: pin that setView contains the clear call for non-file views; keep misc6's setView head pin intact.

Acceptance: selecting files in Recents (or any files view) and navigating to Spaces/Shares/Trash shows no selection bar and drops the selection; returning to Recents starts unselected.

Screenshot evidence from Nikola: select 11 files in Recents, click Spaces — the files selection bar ("Download / Copy to… / Move to… / Delete / Add to favorites · 11 selected") renders above the Spaces overview and its actions would operate on the invisible file selection. **Explicit instructions:** 1. Reproduce first: Recents → select rows → sidebar Spaces. Confirm the `#selbar` stays visible (`body[data-sel="on"]` not cleared by `setView`). 2. Fix in `setView(v)`: when `v` is not a files-type view (`files/search/recents/favorites` — the existing `files` boolean), clear the file selection: `SEL.clear()` + whatever `applySel()`/data-attribute reset the files code uses to hide the bar (scout the exact mechanism; reuse it, don't hand-roll a second one). 3. Check the reverse path too: overview selection state (`spovSel`) is already cleared on every `openSpacesView()` render — verify nothing of it survives into files views after #787's swap mechanism, and add the symmetric clear if it does. 4. Regression guard in the RED test: pin that `setView` contains the clear call for non-file views; keep misc6's `setView` head pin intact. **Acceptance:** selecting files in Recents (or any files view) and navigating to Spaces/Shares/Trash shows no selection bar and drops the selection; returning to Recents starts unselected.
Cordy closed this issue 2026-09-28 02:03:33 +00:00
Author
Owner

Shipped in v0.6.295 (PR #791), live on both dogfoods. Verified on Bao after deploy:

  • Recents → Select all → data-sel=on, "11 selected".
  • → Spaces: data-sel=off, #selbar hidden, #fileactions back — no files bar over the overview.
  • → back to Recents: 0 rows checked, starts unselected.
  • Same check via Deleted files (Recents select-all → Trash): data-sel=off, bar hidden.

Reproduced on v0.6.294 beforehand (identical leak to the screenshot) so the before/after is apples to apples. Ready for review.

**Shipped in v0.6.295 (PR #791), live on both dogfoods. Verified on Bao after deploy:** - Recents → Select all → `data-sel=on`, "11 selected". - → Spaces: `data-sel=off`, `#selbar` hidden, `#fileactions` back — no files bar over the overview. - → back to Recents: 0 rows checked, starts unselected. - Same check via Deleted files (Recents select-all → Trash): `data-sel=off`, bar hidden. Reproduced on v0.6.294 beforehand (identical leak to the screenshot) so the before/after is apples to apples. Ready for review.
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#788
No description provided.