Per-space quota: store, admin API, enforcement (#802, 767a) #805

Merged
Cordy merged 2 commits from feat-802 into main 2026-09-28 04:06:33 +00:00
Owner

Closes #802 (slice 1 of #767).

  • internal/spacequota: ID-keyed caps (spacequota.json, statestore-backed); Set refuses < 1.
  • spaceids.ByBackendDir: resolves a (possibly diverged) backend dir to the space id.
  • Quota decorator:
    • SetSpaceLimit; prefixCap routes a path to /home/<u> (per-user cap) or /spaces/<dir> (space cap), never both.
    • room = max(cap − used, 0) + the size of the replaced file, so overwrites are net and a full or over-cap tree still accepts edits that don't grow it (per-user too).
    • New Copy/Rename overrides pre-check the source size against the room when entering a different capped tree (these bypassed every cap before).
    • Cache deltas can be negative (clamped at 0).
    • SpaceUsage for display.
  • API:
    • PUT/DELETE /api/v1/spaces/{name}/quota, admin-only, both kinds, audited (space-set-quota/space-clear-quota, registered verbs).
    • /spaces entries and /meta carry quota + quotaUsed only for capped spaces; uncapped ones never trigger a walk.
    • POST /spaces sets 1 GiB (defaultSpaceQuota, #800 follow-up).
  • Wiring: main.go opens the store, installs the lookup, passes Quota + SpaceUsage to both SpacesAPI modes.

Checked the decorator stack order: versions sit below quota, so version copies aren't charged. A trash delete is a move to /.trash (uncapped → passes unchecked); a restore into a full space is refused with 507, which is correct. A backend-dir converge rename resolves to an uncapped target and passes.

Tests: RED commit 6f92b204 (compile-red), green: go test ./... all ok, web 285/285.

Closes #802 (slice 1 of #767). - **`internal/spacequota`**: ID-keyed caps (`spacequota.json`, statestore-backed); `Set` refuses < 1. - **`spaceids.ByBackendDir`**: resolves a (possibly diverged) backend dir to the space id. - **Quota decorator**: - `SetSpaceLimit`; `prefixCap` routes a path to `/home/<u>` (per-user cap) or `/spaces/<dir>` (space cap), never both. - `room` = max(cap − used, 0) + the size of the replaced file, so overwrites are net and a full or over-cap tree still accepts edits that don't grow it (per-user too). - New `Copy`/`Rename` overrides pre-check the source size against the room when entering a different capped tree (these bypassed every cap before). - Cache deltas can be negative (clamped at 0). - `SpaceUsage` for display. - **API**: - `PUT`/`DELETE /api/v1/spaces/{name}/quota`, admin-only, both kinds, audited (`space-set-quota`/`space-clear-quota`, registered verbs). - `/spaces` entries and `/meta` carry `quota` + `quotaUsed` only for capped spaces; uncapped ones never trigger a walk. - `POST /spaces` sets **1 GiB** (`defaultSpaceQuota`, #800 follow-up). - **Wiring**: `main.go` opens the store, installs the lookup, passes `Quota` + `SpaceUsage` to both SpacesAPI modes. **Checked the decorator stack order:** versions sit below quota, so version copies aren't charged. A trash delete is a move to `/.trash` (uncapped → passes unchecked); a restore into a full space is refused with 507, which is correct. A backend-dir converge rename resolves to an uncapped target and passes. Tests: RED commit 6f92b204 (compile-red), green: `go test ./...` all ok, web 285/285.
Cordy merged commit 3b361ddbc6 into main 2026-09-28 04:06:33 +00:00
Cordy deleted branch feat-802 2026-09-28 04:06:35 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#805
No description provided.