Admin › Limits: "Warn people at" can silently reset to off; state that empty/0 = no warning #815

Closed
opened 2026-09-28 17:40:28 +00:00 by Cordy · 1 comment
Owner

Found while building #800 (PR #814 note).

Bug: loadSettingsValues fills #set-warnpct only if the input exists, but the input is created later by buildQuotaRows(), when the Storage topic is first opened. If the admin view opens on another topic first and the admin later saves the Limits tab, the field is empty and saves as 0. A configured warning threshold is silently switched off.

Fix: seed the field from serverSettings.quotaWarnPercent when the row is built (the same guard #800 added for #set-spacedef). Empty or 0 then only happens when the admin chooses it.

Copy (Nikola): turning the warning off is a legitimate choice (some instances don't want the banner), so say so plainly in the row description: "Leave empty or set 0 for no warning." This replaces "0 turns the warning off." (i18n ×4).

Tests:

  • Node pin that the warn input is seeded in buildQuotaRows, plus the new copy.
  • A behavioural check that opening Users first and then Storage shows the saved percentage.
Found while building #800 (PR #814 note). **Bug:** `loadSettingsValues` fills `#set-warnpct` only if the input exists, but the input is created later by `buildQuotaRows()`, when the Storage topic is first opened. If the admin view opens on another topic first and the admin later saves the Limits tab, the field is empty and saves as **0**. A configured warning threshold is silently switched off. **Fix:** seed the field from `serverSettings.quotaWarnPercent` when the row is built (the same guard #800 added for `#set-spacedef`). Empty or 0 then only happens when the admin chooses it. **Copy (Nikola):** turning the warning off is a legitimate choice (some instances don't want the banner), so say so plainly in the row description: "Leave empty or set 0 for no warning." This replaces "0 turns the warning off." (i18n ×4). **Tests:** - Node pin that the warn input is seeded in `buildQuotaRows`, plus the new copy. - A behavioural check that opening Users first and then Storage shows the saved percentage.
Cordy closed this issue 2026-09-28 18:06:55 +00:00
Author
Owner

Shipped in v0.6.307 (PR #816, CI green, web 305/305). Verified live on Bao:

  • The description reads "…Leave empty or set 0 for no warning."
  • The bug scenario:
    • Set warn to 85 through the field and save bar (stored 85).
    • Fresh page load on Admin › Spaces, then a hop to Storage & quotas › Limits: the field shows 85 instead of coming up empty.
  • Restored to empty (stored 0); per-user, instance and new-space values unchanged.
Shipped in **v0.6.307** (PR #816, CI green, web 305/305). Verified live on Bao: - The description reads "…Leave empty or set 0 for no warning." - **The bug scenario:** - Set warn to 85 through the field and save bar (stored 85). - Fresh page load on **Admin › Spaces**, then a hop to Storage & quotas › Limits: the field shows **85** instead of coming up empty. - Restored to empty (stored 0); per-user, instance and new-space values unchanged.
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#815
No description provided.