Security hotfix: storage stack hid path mapping + permission checks from the API (#831); details pane surface #832
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "hotfix-actrec"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #831, and a broader security regression with the same root cause. v0.6.315.
Root cause
Since v0.6.254 (#673)
actrecis the outermost storage layer andapiH.Storeis actrec. actrec only implementedstorage.Driver, so every API interface assertion for the scope driver's extra capabilities silently failed:Resolve/home/x) instead of the backend path (/home/<user>/x); Shared/Public/Hold chips gone for everyoneDelegatedReadOnlyLive example on files-bao: sharer1's grant and public link on "/home/sharer2" pointed at sharer2's whole home. Revoked (with Nikola's OK) before this PR.
Fix
actrecforwardsResolve,ReadOnly,Delegatedto the inner stack, with identity/false fallbacks when the stack is not scoped (that is also the correct answer for unscoped administrators, so #831's admin case is fixed too).TestActrecForwardsEveryScopeCapabilityreflects over*scope.Driverand fails if actrec misses any non-builder method (red with the old actrec: Delegated, ReadOnly, Resolve).h.Store, which is why this was invisible.Details pane
#675 scoped the sidebar rules away from
#detpane; the pane had been inheriting the sidebar's surface, edge and inset, which is what separated it from the list. Restored explicitly for desktop (#app > aside#detpane, ≥820px; specificity beats the runtime-injected pane CSS). Checked on a local build: pane background equals the sidebar's, padding 12px 8px, sticky at 56px; phone sheet unchanged.Not in this PR (decision needed)
Records created v0.6.254–v0.6.314 by non-admin users still carry view paths. Product is pre-release, so the exposure is the dogfoods; options in the chat.