local accounts: one last-admin rule for delete/demote/disable; hover reasons; sign-in message font (#865 follow-up, v0.6.330) #879

Merged
Cordy merged 3 commits from fix-865b into main 2026-10-12 14:36:26 +00:00
Owner

Follow-up to #865, from Nikola's live test on files-bao (2026-10-12).

Rule

  • Delete, "Remove admin" and disable now share one rule. Each refuses the last enabled local administrator (break-glass) and the last administrator in total, with 409 last-admin.
  • Before this, delete and demote only checked the total, so the only local admin could be deleted while a directory admin existed.
  • All three checks are atomic under the store lock. A delete that is refused keeps the account's app passwords.

UI

  • On your own row and on the last local admin's row, the entries are greyed out. The reason is in a hover/focus tooltip (the app's data-tip) and in aria-describedby; it is no longer printed under the entry.
  • "Disable account" and "Enable account" no longer end in "…".
  • The sign-in message uses the sans font instead of monospace, on all three pages.

Docs

  • users-access.md and local-accounts.md are updated.
  • CHANGELOG v0.6.330 has an upgrade note.

Review
Two Important findings, both fixed: the delete race, and the tooltip not appearing on keyboard focus. Go, race and web tests are green.

Follow-up to #865, from Nikola's live test on files-bao (2026-10-12). **Rule** - Delete, "Remove admin" and disable now share one rule. Each refuses the last enabled local administrator (break-glass) and the last administrator in total, with `409 last-admin`. - Before this, delete and demote only checked the total, so the only local admin could be deleted while a directory admin existed. - All three checks are atomic under the store lock. A delete that is refused keeps the account's app passwords. **UI** - On your own row and on the last local admin's row, the entries are greyed out. The reason is in a hover/focus tooltip (the app's `data-tip`) and in `aria-describedby`; it is no longer printed under the entry. - "Disable account" and "Enable account" no longer end in "…". - The sign-in message uses the sans font instead of monospace, on all three pages. **Docs** - users-access.md and local-accounts.md are updated. - CHANGELOG v0.6.330 has an upgrade note. **Review** Two Important findings, both fixed: the delete race, and the tooltip not appearing on keyboard focus. Go, race and web tests are green.
local accounts: fix-865b review fixes
All checks were successful
ci / test-and-build (pull_request) Successful in 3m21s
652a3f74e6
Refs #865. A delete refused by the floor under the store lock keeps the account's app passwords (removal moved inside DeleteChecked). Greyed-out menu entries use the #747 tooltip (hover and keyboard focus) instead of a native title; no hover highlight.
Cordy merged commit 48bce5d94e into main 2026-10-12 14:36:26 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#879
No description provided.