client address: the card follows the fix; small instances get the proxy card; docs drift (#864 follow-up, v0.6.332) #882

Merged
Cordy merged 3 commits from fix-864b into main 2026-10-12 16:58:45 +00:00
Owner

Follow-up to #864. These come from the v0.6.331 live walkthrough on files-bao with Nikola on 2026-10-12.

Fixes

  • R9: newer evidence replaces the cluster cause. After externalTrafficPolicy: Local, the card stayed on "cluster" for up to 24 h because of old evidence, which broke its "disappears by itself" promise. It now changes after about 20 requests from outside the cluster. If the setting is reverted, the card goes back to "cluster".
  • R10: authenticated traffic confirms a proxy. On a single-user instance the card could never name the proxy, because it needed 3 different client hops. Now one request through that peer with a valid session or app password is enough. Anonymous traffic can't plant the suggestion. Share-link password sessions, WOPI tokens and failed Basic attempts don't count, and each has a test.
  • R11: probes are ignored. /healthz and /metrics never feed the detector.
  • R12: an ingress pod replaces old node evidence. This covers k3s with Traefik set to Local.

Docs drift found by checking v0.6.326–331 against the handbook

  • sharing.md:
    • Upload links: what a full link answers (507), the 64 KiB budget for form fields, and that uploads are streamed with the quota checked during the upload.
    • The share-link password limit: 10 per minute per client address, with IPv6 grouped per /64. It follows trustedProxies.
    • "Disabled" now covers local accounts too.
  • licensing-faq.md: a disabled account holds no seat.
  • deployment.md: behaviour after a fix, and the R10–R12 rules.
  • CHANGELOG: v0.6.332.

Verification

  • Review: 2 Important findings (R11, R12), both fixed.
  • Security guards added for R10.
  • Checks: go test ./..., -race, gofmt, and the web tests all pass.
Follow-up to #864. These come from the v0.6.331 live walkthrough on files-bao with Nikola on 2026-10-12. ## Fixes - **R9: newer evidence replaces the cluster cause.** After `externalTrafficPolicy: Local`, the card stayed on "cluster" for up to 24 h because of old evidence, which broke its "disappears by itself" promise. It now changes after about 20 requests from outside the cluster. If the setting is reverted, the card goes back to "cluster". - **R10: authenticated traffic confirms a proxy.** On a single-user instance the card could never name the proxy, because it needed 3 different client hops. Now one request through that peer with a valid session or app password is enough. Anonymous traffic can't plant the suggestion. Share-link password sessions, WOPI tokens and failed Basic attempts don't count, and each has a test. - **R11: probes are ignored.** `/healthz` and `/metrics` never feed the detector. - **R12: an ingress pod replaces old node evidence.** This covers k3s with Traefik set to Local. ## Docs drift found by checking v0.6.326–331 against the handbook - **sharing.md:** - Upload links: what a full link answers (507), the 64 KiB budget for form fields, and that uploads are streamed with the quota checked during the upload. - The share-link password limit: 10 per minute per client address, with IPv6 grouped per /64. It follows `trustedProxies`. - "Disabled" now covers local accounts too. - **licensing-faq.md:** a disabled account holds no seat. - **deployment.md:** behaviour after a fix, and the R10–R12 rules. - **CHANGELOG:** v0.6.332. ## Verification - Review: 2 Important findings (R11, R12), both fixed. - Security guards added for R10. - Checks: `go test ./...`, `-race`, gofmt, and the web tests all pass.
Cordy merged commit d53cd92885 into main 2026-10-12 16:58:45 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#882
No description provided.