Admin rights need a browser sign-in, hash-password ends at Enter, vulncheck reports everything (#890 #893 #886, v0.6.338) #894

Merged
Cordy merged 9 commits from batch-v07k into main 2026-10-13 20:47:18 +00:00
Owner

Closes #890, #893 and #886. The spec and plan are in docs/superpowers/specs|plans/2026-10-13-batch-v07k*, and the CHANGELOG entry is v0.6.338.

  • #890 (security): auth.AdminPowers / AdminNeedsSession use User.ViaBasic. Admin gates now answer 403 admin-needs-session to Basic credentials and app passwords. Every admin power switches over:
    • share revoke-any, spaces, locks, quota, the Office claim, trash (WebDAV and API), settings GET redaction and the admin bell items;
    • the bell cache is keyed separately for session and Basic requests.
    • An end-to-end test covers OIDC with an app password (403 on admin, 207 on /dav) and a form session (200).
  • #893: reads one line; on a TTY echo is off and the password is asked twice (x/sys/unix termios, linux build tag); over 1024 bytes is refused. The docs now lead with the piped and -it forms.
  • #886: internal/tools/vulnsummary makes a summary-first report from govulncheck -format json, and the summary is never cut. The workflow builds the tool so exit 3 survives. A failed scan now files a deduped issue.

Reviews: each task got a spec and quality review with fix rounds, and the whole branch got a final review (opus) that included a docs-drift check across the full handbook. Its findings are fixed. Locally, the full go test, go vet and web tests are green.

Closes #890, #893 and #886. The spec and plan are in `docs/superpowers/specs|plans/2026-10-13-batch-v07k*`, and the CHANGELOG entry is v0.6.338. - **#890 (security):** `auth.AdminPowers` / `AdminNeedsSession` use `User.ViaBasic`. Admin gates now answer 403 `admin-needs-session` to Basic credentials and app passwords. Every admin power switches over: - share revoke-any, spaces, locks, quota, the Office claim, trash (WebDAV and API), settings GET redaction and the admin bell items; - the bell cache is keyed separately for session and Basic requests. - An end-to-end test covers OIDC with an app password (403 on admin, 207 on `/dav`) and a form session (200). - **#893:** reads one line; on a TTY echo is off and the password is asked twice (x/sys/unix termios, linux build tag); over 1024 bytes is refused. The docs now lead with the piped and `-it` forms. - **#886:** `internal/tools/vulnsummary` makes a summary-first report from `govulncheck -format json`, and the summary is never cut. The workflow builds the tool so exit 3 survives. A failed scan now files a deduped issue. Reviews: each task got a spec and quality review with fix rounds, and the whole branch got a final review (opus) that included a docs-drift check across the full handbook. Its findings are fixed. Locally, the full `go test`, `go vet` and web tests are green.
AdminPowers/AdminNeedsSession in internal/auth; the admin gates (requireAdmin,
license, peering, settings PUT) answer admin-needs-session to an admin's Basic
credential, and shared handlers (settings GET, share revoke-any, Spaces,
quota capacity, Office claim, trash driver) treat it as an ordinary user.
u.Admin itself is unchanged (seats, #887 audit, bell). End-to-end test on
the real stack in OIDC mode: local Basic and app password refused, WebDAV
still 207, form session 200, non-admin session plain 403.
notify: key the feed cache by session vs Basic (#890); neutral example config hosts
All checks were successful
ci / test-and-build (pull_request) Successful in 3m54s
ff4a6ed49e
Cordy merged commit e3b6ffb130 into main 2026-10-13 20:47:18 +00:00
Cordy deleted branch batch-v07k 2026-10-13 20:47:21 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#894
No description provided.