No trash folders in folder pickers or as device/report targets; path box layout (#897 follow-up, v0.6.342) #905

Merged
Cordy merged 3 commits from fix-897b into main 2026-10-15 09:30:18 +00:00
Owner

This fixes three things Nikola found live on v0.6.341.

  1. Space trash folders in the device picker: the Connect a device folder picker offered a space's hidden .trash folder (/spaces/Fall 3/.trash).
  2. Space trash folders as report folders: the Sharing › Reviews scheduled report could also be saved into one.
  3. Overlapping path box: the path box next to Only this folder overlapped the helper line under it.

Changes

  • Pickers: no picker mode lists or offers .trash or anything inside it. That covers move, copy, report, device and the device picker's Shared with me list.
  • Server:
    • A device limited to a trash path is refused with 422 access-not-allowed.
    • A report folder changed to a trash path is refused with 422 share-report-dir-trash / admin-report-dir-trash (EN/DE/FR/IT).
    • A trash folder saved before this fix fails at run time with "report folder is inside a trash folder", and unrelated settings saves still go through.
  • CSS: the radio, label and path box stay level, the helper line sits below, and when a long path wraps the radio stays level with its label.

Checks: the picker change, the server refusals and the CSS each got their own review, and the follow-up fix round got a scoped re-review. Live-checked on a local instance: wide and narrow layouts, and a deep path.

Tests: 667 web tests and go test ./... pass.

Left open as its own issue: a session admin can still write into a space's .trash with a hand-made REST call. Trash enforcement deliberately allows admins raw access, so changing that is a design question.

This fixes three things Nikola found live on v0.6.341. 1. **Space trash folders in the device picker:** the Connect a device folder picker offered a space's hidden `.trash` folder (`/spaces/Fall 3/.trash`). 2. **Space trash folders as report folders:** the Sharing › Reviews scheduled report could also be saved into one. 3. **Overlapping path box:** the path box next to Only this folder overlapped the helper line under it. **Changes** - **Pickers:** no picker mode lists or offers `.trash` or anything inside it. That covers move, copy, report, device and the device picker's Shared with me list. - **Server:** - A device limited to a trash path is refused with 422 `access-not-allowed`. - A report folder changed to a trash path is refused with 422 `share-report-dir-trash` / `admin-report-dir-trash` (EN/DE/FR/IT). - A trash folder saved before this fix fails at run time with "report folder is inside a trash folder", and unrelated settings saves still go through. - **CSS:** the radio, label and path box stay level, the helper line sits below, and when a long path wraps the radio stays level with its label. **Checks:** the picker change, the server refusals and the CSS each got their own review, and the follow-up fix round got a scoped re-review. Live-checked on a local instance: wide and narrow layouts, and a deep path. **Tests:** 667 web tests and `go test ./...` pass. **Left open as its own issue:** a session admin can still write into a space's `.trash` with a hand-made REST call. Trash enforcement deliberately allows admins raw access, so changing that is a design question.
Cordy merged commit d4fd54830a into main 2026-10-15 09:30:18 +00:00
Cordy deleted branch fix-897b 2026-10-15 09:30:20 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#905
No description provided.