Recipient picker lists every group name by prefix (group names are space names on IdP instances) #928

Closed
opened 2026-10-15 22:06:20 +00:00 by Cordy · 5 comments
Owner

Found during the #923 research (2026-10-16).

What happens: the share recipient picker lists every directory group whose name matches the typed prefix, to any signed-in user. On IdP instances, group names are space names, so the picker reveals space names to non-members. This is the same class as #923, through a different endpoint.

Fix direction (research first):

  • Add an admin setting "restrict the picker to my own groups" (the market norm for large organisations).
  • Or only show groups the person belongs to, plus exact matches.
  • Check how Nextcloud's shareapi_only_share_with_group_members and the share-enumeration settings handle this.

Decision D7 in the #923 research.

Found during the #923 research (2026-10-16). **What happens:** the share recipient picker lists every directory group whose name matches the typed prefix, to any signed-in user. On IdP instances, group names are space names, so the picker reveals space names to non-members. This is the same class as #923, through a different endpoint. **Fix direction (research first):** - Add an admin setting "restrict the picker to my own groups" (the market norm for large organisations). - Or only show groups the person belongs to, plus exact matches. - Check how Nextcloud's `shareapi_only_share_with_group_members` and the share-enumeration settings handle this. Decision D7 in the #923 research.
Author
Owner

#1002 research (2026-10-26): best practice from Nextcloud, OpenCloud, SharePoint and Google:

  • Show the current name, plus the path or OU when two groups share a name.
  • Resolve the typed name to a stable reference when the share is made, and refuse an ambiguous name.

Group shares in Cairn today accept any group string without a check and match it case-insensitively (grants.go:139-179, grant.go:50), while spaces match case-sensitively. The picker rows with path are part of the #1002 mockup. The restriction of what the picker lists (this issue) will be decided alongside it.

#1002 research (2026-10-26): best practice from Nextcloud, OpenCloud, SharePoint and Google: - Show the current name, plus the path or OU when two groups share a name. - Resolve the typed name to a stable reference when the share is made, and refuse an ambiguous name. Group shares in Cairn today accept any group string without a check and match it case-insensitively (grants.go:139-179, grant.go:50), while spaces match case-sensitively. The picker rows with path are part of the #1002 mockup. The restriction of what the picker lists (this issue) will be decided alongside it.
Author
Owner

Decision (Nikola, 2026-10-26), for group shares:

  • The share stores a group reference (source, id where available, path, label), resolved when the share is created.
  • Ambiguous names are refused, and free-text group names are no longer accepted.
  • The picker shows the name plus the path or OU when two groups share a name.

This is built in the #1002 stage 2+3 batch, with a mockup. What the picker lists to whom (this issue's original point) will be asked with that mockup.

**Decision (Nikola, 2026-10-26), for group shares:** - The share stores a group reference (source, id where available, path, label), resolved when the share is created. - Ambiguous names are refused, and free-text group names are no longer accepted. - The picker shows the name plus the path or OU when two groups share a name. This is built in the #1002 stage 2+3 batch, with a mockup. What the picker lists to whom (this issue's original point) will be asked with that mockup.
Author
Owner

Stage 2 research (2026-10-26, research-1002-6-stage2.md; summary on #1002).

Today: every signed-in person can search every group name by prefix (recipients.go:126-148). VERIFIED. This is the leak this issue describes.

Recommended:

  • Default: people see only their own groups.
  • Admin setting: can widen this to exact full names or to all groups.
  • Rows: one per group, with a source chip, the path or OU when two groups share a name, and a "looks like" marker.
  • API: refuses free text.

The decision is asked with #1002.

Stage 2 research (2026-10-26, `research-1002-6-stage2.md`; summary on #1002). **Today:** every signed-in person can search every group name by prefix (recipients.go:126-148). VERIFIED. This is the leak this issue describes. **Recommended:** - **Default:** people see only their own groups. - **Admin setting:** can widen this to exact full names or to all groups. - **Rows:** one per group, with a source chip, the path or OU when two groups share a name, and a "looks like" marker. - **API:** refuses free text. The decision is asked with #1002.
Author
Owner

Decision (Nikola, 2026-10-26): by default people see only their own groups; an admin setting can widen this to exact full names or all groups. The rest is as recommended above. Built in the #1002 stage 2+3 batch, after the mockup.

**Decision (Nikola, 2026-10-26):** by default people see only their own groups; an admin setting can widen this to exact full names or all groups. The rest is as recommended above. Built in the #1002 stage 2+3 batch, after the mockup.
Author
Owner

Released in v0.6.357 (PR #1015).

  • Picker scope: the group picker shows people only their own groups by default. Admins can widen this to exact full names or all groups (groupScope, Sharing › Policy).
  • Picker rows: each row carries a source chip, the path only for groups the person holds, and a look-alike marker.
  • Free text: group shares no longer accept a typed group name.
  • Probing: under own, a group the person does not hold gets the same 403 whether it exists or not.

Closing.

Released in **v0.6.357** (PR #1015). - **Picker scope:** the group picker shows people only their own groups by default. Admins can widen this to exact full names or all groups (`groupScope`, Sharing › Policy). - **Picker rows:** each row carries a source chip, the path only for groups the person holds, and a look-alike marker. - **Free text:** group shares no longer accept a typed group name. - **Probing:** under `own`, a group the person does not hold gets the same 403 whether it exists or not. Closing.
Cordy closed this issue 2026-10-26 18:03:26 +00:00
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#928
No description provided.