Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix-922"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
#922: record, then publish
versions.PathSerializer) checks that the content being replaced has a record, and records it if it has none.YYYY-MM-DDTHH:MM:SS.nnnnnnnnnZ_<12 random digits>[a|u]_<author>.v, ordered by time.x-amz-meta-cairn-record, with a boot probe that chooses copy, put or none mode.#934
Faults on main (Task 1 probes, all failing on
8a20c218)TestFault922Reproduces: live345olga-2-IMPORTANTlost on 4/4 variants; 12-in-a-second lists w4 w3 w2; stress loses 47–112 of 161, plus "no free version key" refusals.TestFault922TwinReproduces: the same across two stacks.TestFault934Reproduces: take-over 201 with the NFD name, then 404s.TestFault934S3TwinPrefix: a new file in an NFD folder hides the old files.All four pass on the branch.
Rulings (spec
docs/superpowers/specs/2026-10-16-fix-922-design.md§3.2)uversion, which feeds the WOPI rescue.Recorder.otheris gone.SameName.Review-round rulings (all in the SDD ledger):
urules;Changed pre-existing tests (each with its reason in the task reports)
TestKeySearchStatErrorreplaced byTestRecordOfStatErrorTestNameTooLong(87-byte key)versions902:434(token)finalize908:140TestKeyRoundTripmintcopy908(asserts a link on posix)TestMergeMarkedSeqTakenandTestMergeNameClash(fresh token)TestCoalesceSkipsandTestCoalesceOnlyAfterAutosaveMint(R7/R3)Wrapreturns an error (R13): onrefusedwire908 and the stacktest order parser; ocm/grant908 embeds*posix.Driver.TestRigRoundTripandTestRigReopen(2 raw entries)TestDeleteDropsChainHeldKeepsTestMergeListErrorKeepsChainTestSameContentWriteAtCapKeepsChainandTestPruneCountCapset the grace to 1 nsTestFailedRenameLeavesNoMintallows one extra listed version on s3.Garage
none, I stop and report before going further.Checks
go test ./...passes (62 packages).-racepasses on Race922/Twin/Drain/Age.scratch/b7e/live347/report.md):Follow-up issues filed during this work
#939 #940 #941 #942 #943 #944 #945 #946 #947 #948 #949 #950 #951
Closes #922, closes #934 (after the dogfood checks).
The drain rewrites a recorded file with its record under the same name (WriteRecorded, Replace; Renew when the s3 publish finds the record gone) and skips that record in its walk. main opens the base driver through openBase (posix logs its record mode, s3 probes the store and a failed probe refuses the start) and builds the chain below versions through storageChain; versions.Wrap also requires the base driver (Raw) to record writes, since reserved and encrypt always have the methods. OnUnrecorded feeds cairn_versions_unrecorded_writes_total{cause}.