Versions: a grantee's save through a shared folder is recorded with the owner as author #977

Closed
opened 2026-10-20 04:43:44 +00:00 by Cordy · 0 comments
Owner

Found in the batch 4 review of #915 (review-b finding 3, 2026-10-19). Confirmed.

What happens: when bob writes to anna's file through /shared, the version is recorded with author="anna" (internal/storage/versions/versions.go:1038). The Versions panel then says anna saved content that bob saved. #915 introduced auth.ActorOf for exactly this identity swap. It now fixes trash, audit and locks, but not versions.

Care needed:

  • The author is part of the version key names (:516) and drives autosave merging (:953-960), so a change here affects key grammar and merging.
  • It must not touch key or path derivation.
  • Existing keys stay readable.

To do:

  1. Research the impact on key names and merging.
  2. Record ActorOf as the author.
  3. Test on posix and s3 with encryption, and with v0.6.351 keys.
Found in the batch 4 review of #915 (review-b finding 3, 2026-10-19). Confirmed. **What happens:** when bob writes to anna's file through `/shared`, the version is recorded with `author="anna"` (`internal/storage/versions/versions.go:1038`). The Versions panel then says anna saved content that bob saved. #915 introduced `auth.ActorOf` for exactly this identity swap. It now fixes trash, audit and locks, but not versions. **Care needed:** - The author is part of the version key names (`:516`) and drives autosave merging (`:953-960`), so a change here affects key grammar and merging. - It must not touch key or path derivation. - Existing keys stay readable. **To do:** 1. Research the impact on key names and merging. 2. Record `ActorOf` as the author. 3. Test on posix and s3 with encryption, and with v0.6.351 keys.
Cordy closed this issue 2026-10-27 03:15:01 +00:00
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#977
No description provided.