Leave share: a grantee removes a share from their own view #1033

Closed
opened 2026-10-28 02:00:02 +00:00 by Cordy · 4 comments
Owner

Follow-up to #973 (decision 2026-10-28: "refuse now, Leave share later").

Since v0.6.366 a grantee can no longer delete, move or rename the top folder or shared file of a share (403 share-root). What's missing is a way to get rid of a share you don't want in "Shared with me" without asking the owner.

Scope:

  • "Leave share" on a share root (row menu, and maybe the Shared-with-me list): hides it for this user only; the owner's data and other grantees are untouched.
  • Group grants: leaving hides it for the user, not the group. Decide whether a later re-grant shows it again.
  • Owner side: should the owner see that someone left (bell, list)?
  • Devices and WebDAV clients: the share disappears from /shared on the next sync.
  • Undo: where does a left share come back from?

Needs research (how Drive/OneDrive/Nextcloud/Seafile handle "remove from my view") and a whole-page mockup before building.

Follow-up to #973 (decision 2026-10-28: "refuse now, Leave share later"). Since v0.6.366 a grantee can no longer delete, move or rename the top folder or shared file of a share (403 `share-root`). What's missing is a way to get rid of a share you don't want in "Shared with me" without asking the owner. Scope: - "Leave share" on a share root (row menu, and maybe the Shared-with-me list): hides it for this user only; the owner's data and other grantees are untouched. - Group grants: leaving hides it for the user, not the group. Decide whether a later re-grant shows it again. - Owner side: should the owner see that someone left (bell, list)? - Devices and WebDAV clients: the share disappears from /shared on the next sync. - Undo: where does a left share come back from? Needs research (how Drive/OneDrive/Nextcloud/Seafile handle "remove from my view") and a whole-page mockup before building.
Author
Owner

Research (2026-10-30). The full write-up with sources and VERIFIED, INFERRED and UNVERIFIED markers is in scratch/b7e/backlog/research-1033.md.

Market

  • Every product splits leaving a share into two actions.
    • Out of my view, can come back: Google "Remove from view", OneDrive "Hide from Shared", OpenCloud/oCIS hide and unmount, Dropbox "Remove from Dropbox".
    • Give up access: Box "End Collaboration", Dropbox "Remove my access", iCloud "Remove Yourself", Nextcloud for a share made to one person.
  • Leaving a group share is always a per-person hide; no product lets one member really leave a group share.

Pitfalls seen elsewhere

  • Nextcloud's "Deleted shares" restore has been broken from 2018 to 2026.
  • A migration brought shares people had left back (Nextcloud PR #62373).
  • CVE-2016-9464: one member leaving a group share removed it for the whole group.
  • Sync clients delete local copies when a share disappears.
  • OneDrive users complain that "hide" leaves their access in place.

Cairn today

  • There is no per-person state on a share. Five places compute "shared with this person", all through share.GrantsFor.
  • The share root has refused delete and move since v0.6.366, and sharing.md promises Leave.
  • The change feed has no entries for a share appearing or disappearing.
  • A leaver's lock under a group share can stay held.
  • Rows in Shared with me are whole buttons, so a row menu needs a layout change.
  • Same-named space-share entries are numbered "(2)" by order, so filtering a left share out before naming would rename a sibling on people's devices.

Recommended design

  • One Leave for person, group and space shares. The share stops serving to that one person everywhere: web, WebDAV, devices, change feed and locks.
  • It is stored as a per-person marker on the share record, which works across several instances and leaves nothing behind when the share is removed.
  • The person can Rejoin from a "Left" filter in Shares › Shared with me, and a toast offers undo.
  • A new share by the owner shows up again; role, expiry and group-membership changes keep it left.
  • The owner sees a quiet "Left" label on shares made to one person, with no bell.
  • A device bound to the share goes to No access and comes back on Rejoin.
  • WebDAV DELETE on a share root stays 403.
  • Leave and Rejoin are audited, release the leaver's locks, and write change-feed entries.
  • Size M, with 8 mockup frames.

Open questions, with my recommendations

  1. What Leave means: suspend for me. → suspend
  2. A new share of the same item shows up again. → yes
  3. What the owner sees: a label on shares made to one person, plus the space owner's and admins' lists; no bell.
  4. Where a left share comes back from: the Left filter plus the toast, not Deleted files.
  5. Leaving with a bound device: allow, with a warning naming the devices.
  6. WebDAV DELETE on a share root: keep 403.
  7. Change-feed entries for leave and rejoin: now (revoke and new shares later).
  8. An admin switch to turn Leave off: no.
  9. Bulk leave from the selection bar: yes.
  10. The owner can clear someone's leave: no (revoke and share again does it).
  11. Drop left markers when an account is deleted: yes.
**Research (2026-10-30).** The full write-up with sources and VERIFIED, INFERRED and UNVERIFIED markers is in `scratch/b7e/backlog/research-1033.md`. **Market** - Every product splits leaving a share into two actions. - **Out of my view, can come back:** Google "Remove from view", OneDrive "Hide from Shared", OpenCloud/oCIS hide and unmount, Dropbox "Remove from Dropbox". - **Give up access:** Box "End Collaboration", Dropbox "Remove my access", iCloud "Remove Yourself", Nextcloud for a share made to one person. - Leaving a group share is always a per-person hide; no product lets one member really leave a group share. **Pitfalls seen elsewhere** - Nextcloud's "Deleted shares" restore has been broken from 2018 to 2026. - A migration brought shares people had left back (Nextcloud PR #62373). - CVE-2016-9464: one member leaving a group share removed it for the whole group. - Sync clients delete local copies when a share disappears. - OneDrive users complain that "hide" leaves their access in place. **Cairn today** - There is no per-person state on a share. Five places compute "shared with this person", all through `share.GrantsFor`. - The share root has refused delete and move since v0.6.366, and `sharing.md` promises Leave. - The change feed has no entries for a share appearing or disappearing. - A leaver's lock under a group share can stay held. - Rows in Shared with me are whole buttons, so a row menu needs a layout change. - Same-named space-share entries are numbered "(2)" by order, so filtering a left share out before naming would rename a sibling on people's devices. **Recommended design** - One Leave for person, group and space shares. The share stops serving to that one person everywhere: web, WebDAV, devices, change feed and locks. - It is stored as a per-person marker on the share record, which works across several instances and leaves nothing behind when the share is removed. - The person can Rejoin from a "Left" filter in Shares › Shared with me, and a toast offers undo. - A new share by the owner shows up again; role, expiry and group-membership changes keep it left. - The owner sees a quiet "Left" label on shares made to one person, with no bell. - A device bound to the share goes to No access and comes back on Rejoin. - WebDAV DELETE on a share root stays 403. - Leave and Rejoin are audited, release the leaver's locks, and write change-feed entries. - Size M, with 8 mockup frames. **Open questions, with my recommendations** 1. What Leave means: suspend for me. → suspend 2. A new share of the same item shows up again. → yes 3. What the owner sees: a label on shares made to one person, plus the space owner's and admins' lists; no bell. 4. Where a left share comes back from: the Left filter plus the toast, not Deleted files. 5. Leaving with a bound device: allow, with a warning naming the devices. 6. WebDAV DELETE on a share root: keep 403. 7. Change-feed entries for leave and rejoin: now (revoke and new shares later). 8. An admin switch to turn Leave off: no. 9. Bulk leave from the selection bar: yes. 10. The owner can clear someone's leave: no (revoke and share again does it). 11. Drop left markers when an account is deleted: yes.
Author
Owner

Decision (Nikola, 2026-10-30): all 11 recommendations from the research comment are approved. Next step: a whole-page mockup.

**Decision (Nikola, 2026-10-30):** all 11 recommendations from the research comment are approved. Next step: a whole-page mockup.
Author
Owner

Mockup approved (Nikola, 2026-10-30): 1033-leave-share-mockup.html, with all its strings and open-point recommendations.

  • German: "Freigabe verlassen", "Wieder beitreten" and "Verlassen".
  • A single file leaves without a confirm.
  • No "role lowered" bell while left.
  • No per-person Left label on group shares for admins in v0.7.
  • A follow-up issue for change-feed entries on revoke and new shares.
  • No Leave in the details pane yet.
  • The owner keeps 403 share-own.
**Mockup approved (Nikola, 2026-10-30):** `1033-leave-share-mockup.html`, with all its strings and open-point recommendations. - German: "Freigabe verlassen", "Wieder beitreten" and "Verlassen". - A single file leaves without a confirm. - No "role lowered" bell while left. - No per-person Left label on group shares for admins in v0.7. - A follow-up issue for change-feed entries on revoke and new shares. - No Leave in the details pane yet. - The owner keeps 403 `share-own`.
Cordy closed this issue 2026-10-31 09:29:22 +00:00
Author
Owner

Shipped in v0.6.378 (PR #1060), live on both dogfoods (pods ready, no restarts, no new WARN lines).

  • Leave share on any share made to you (person or group, personal or space share): Files row menu and selection bar (also in Favourites, Recents and search), a confirm that names the devices that pause and the locks that are released, then Undo in the status line.
  • Shares › Shared with me: a menu per row (Open, Details, Leave share), a Current / Left filter, the Left list with Rejoin; a device paused because you left says so and offers Rejoin.
  • The leave is per person on the grant (record-level marks): your colleagues keep the share, the owner sees a quiet "Left on …" label (admin filter ?left=1, CSV leftAt); a role change keeps you out; revoke and re-share, or your Rejoin, bring it back.
  • Only what rests on the left share is touched: locks or devices that another current share still covers stay.
  • API: GET/POST /api/v1/shared/{id}/leave, POST /api/v1/shared/{id}/rejoin; audit share-leave, share-rejoin, share-left-dropped; per-person change-feed entries.
  • Docs: CHANGELOG v0.6.378, sharing.md, change-feed.md, account.md, spaces.md, admin-policy.md, data protection and export pages, ARCHITECTURE.md.

Follow-up filed: #1063 (change feed entries on grant and revoke).

Shipped in **v0.6.378** (PR #1060), live on both dogfoods (pods ready, no restarts, no new WARN lines). - **Leave share** on any share made to you (person or group, personal or space share): Files row menu and selection bar (also in Favourites, Recents and search), a confirm that names the devices that pause and the locks that are released, then Undo in the status line. - **Shares › Shared with me**: a menu per row (Open, Details, Leave share), a Current / Left filter, the Left list with Rejoin; a device paused because you left says so and offers Rejoin. - The leave is per person on the grant (record-level marks): your colleagues keep the share, the owner sees a quiet "Left on …" label (admin filter `?left=1`, CSV `leftAt`); a role change keeps you out; revoke and re-share, or your Rejoin, bring it back. - Only what rests on the left share is touched: locks or devices that another current share still covers stay. - API: `GET/POST /api/v1/shared/{id}/leave`, `POST /api/v1/shared/{id}/rejoin`; audit `share-leave`, `share-rejoin`, `share-left-dropped`; per-person change-feed entries. - Docs: CHANGELOG v0.6.378, sharing.md, change-feed.md, account.md, spaces.md, admin-policy.md, data protection and export pages, ARCHITECTURE.md. Follow-up filed: #1063 (change feed entries on grant and revoke).
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#1033
No description provided.