v0.6.378: Leave share (#1033) #1060
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ls1033"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #1033.
?left=1, CSVleftAt; role changes PATCH in place (keep a leave).Merged with v0.6.376/v0.6.377 (left marks survive transfer; left + paused cases tested). Final review + final fixes done.
Frames E and G (spec 9.5, 10.3). A grant to one person that they left (leftAt, addresseeKind user) shows "Left 30 Oct" in Shares > Shared with others, in the item's Shares pane, in the space owner's Sharing list and under the recipient in the administrators' Shares tab. The tooltip with the long date is also the label's accessible description. Group grants never show it (M4). The administrators' list gets the "Left by recipient" chip with a count and aria-pressed; the client filter is shFilter.left and the export URL carries left=1, as the server's filterRows. Dates come from fixed parts (pure:leave1033-owner, ownerLeftDay and ownerLeftDayLong, same rules as T8's leftDay/leftDayLong) so tests never depend on ICU or the time zone. A person's role change in these lists was a revoke and a fresh grant, which would silently drop the person's leave (spec 2.4 and D2 say a role change keeps it). A left grant now changes in place with PATCH, as groups and space shares already did (ownerRoleInPlace). The role select in both lists had no accessible name (WCAG 4.1.2, found by the new axe test); it is now named with the existing devChgTitle ("Change access for {name}").Frames A, B, C and H of the approved mockup (spec 9.1 to 9.3, 9.7, 9.8, 10.1). The row menu of a share root ends with Leave share after Details and a separator, in normal colour; the selection bar offers Leave {n} shares when every selected row is a share root (Move to and Delete are then not offered, as the mockup draws). The confirm is askDanger with a primary verb and the preview's facts; a lone file with no device and no lock leaves at once (M2). Rows go at once from the answers, the status line says it with a real Undo button, focus goes to the neighbour. pure:leave1033: leaveOffered, selLeaveOffered, leaveTargets, leaveNeedsConfirm, leaveConfirmRows, leaveDoneText, rejoinDoneText, leftDay, leftDayLong. Effectful, for T10: leaveShares, rejoinShares, leaveStatusLine. codeText words share-own, share-not-found and shares-unavailable. askDanger renders a list of paths in one row (B5). Existing tests changed, with reasons: - shareroot973, shareroot973file, spaceshare1035b: the share-root texts now name Leave share (D6, spec 10.1 changed keys). - row-menu, shareroot973: openRowMenu calls leaveOffered, so their menu harness lifts pure:leave1033 too. - qa867, devices897a: refreshChrome re-labels Leave {n} shares (selLeaveSync), so their refreshChrome harness gets a stub. - qa693: one more askDanger confirm (45 to 46).The owner's share pane and Shared with others revoked and re-granted a person's grant unless the row carried leftAt. A list loaded before the person left has no leftAt, so a role change dropped their leave and the grant id. ownerRoleChange now PATCHes /api/v1/grants/{id} for every person, group and space grant; only a federated grant keeps revoke and grant. shGrantRolePatch had no caller left and is removed.Outside Files the selection bar computed Leave {n} shares from currentItems, which still hold the last folder, so in Favourites, Recents and search the button never showed for the selected rows. selLeaveItems reads currentItems in Files, searchRaw in search and fbRowsSrc in Favourites and Recents. leaveDropRows and leaveUndo call refreshNavCounts, so the Favourites count drops with a left share's favourite and returns after Undo.