Share items from a space with non-members (people and groups) #1035

Closed
opened 2026-10-28 09:55:07 +00:00 by Cordy · 4 comments
Owner

Research: research-space-sharing.md (2026-10-28): market (OpenCloud, oCIS, ownCloud 10, Nextcloud Team folders, Seafile, SharePoint, Google Shared Drives, Box, Dropbox), user voices, standards (ISO 27002, NIST 800-53, BSI, DSG/DSV, ISG, GDPR, NIS2, CISA SCuBA), Cairn code.

Decisions (Nikola, 2026-10-28):

  • Build it for v0.7: a file or folder inside a space can be shared with an organisation person or group who isn't a member.
  • Who may share: a per-space setting "Who can share: owner only / members with write", default owner only. The admin can cap it for the whole instance. Read-only members never share.
  • Shares belong to the space: they survive the sharer leaving or losing their role. The space owner sees every share and link in the space and can revoke any; the audit shows who made it.
  • External partners without an account: separate research issue. Until then, organisation users and groups, including local accounts an admin creates.

Must be built differently from the removed pre-v0.6.215 grants (#595, #983):

  • tied to the space id + relative path (like device bindings), never the backend folder name; survives rename and convergence;
  • effective right = min(share role, what the space's sharing rule still allows), checked on every request; no re-sharing; a share never exceeds the sharer's role at creation;
  • space deleted or disabled: shares end or pause with it, no orphans;
  • trash/restore rule for a non-member's delete; Activity exposure (revert the spacerename.go:1146-1174 shortcut); locks (HolderWrites); change feed; quota bills the space; WOPI; audit with the space id.
  • Public links on space content follow the same rule (#1034).

Next: whole-page mockups (owner's share dialog with the space rule, the space's share list, recipient's view), then spec and plan.

Research: research-space-sharing.md (2026-10-28): market (OpenCloud, oCIS, ownCloud 10, Nextcloud Team folders, Seafile, SharePoint, Google Shared Drives, Box, Dropbox), user voices, standards (ISO 27002, NIST 800-53, BSI, DSG/DSV, ISG, GDPR, NIS2, CISA SCuBA), Cairn code. **Decisions (Nikola, 2026-10-28):** - Build it for v0.7: a file or folder inside a space can be shared with an organisation person or group who isn't a member. - Who may share: a per-space setting "Who can share: owner only / members with write", **default owner only**. The admin can cap it for the whole instance. Read-only members never share. - Shares belong to the **space**: they survive the sharer leaving or losing their role. The space owner sees every share and link in the space and can revoke any; the audit shows who made it. - External partners without an account: separate research issue. Until then, organisation users and groups, including local accounts an admin creates. **Must be built differently from the removed pre-v0.6.215 grants (#595, #983):** - tied to the space id + relative path (like device bindings), never the backend folder name; survives rename and convergence; - effective right = min(share role, what the space's sharing rule still allows), checked on every request; no re-sharing; a share never exceeds the sharer's role at creation; - space deleted or disabled: shares end or pause with it, no orphans; - trash/restore rule for a non-member's delete; Activity exposure (revert the spacerename.go:1146-1174 shortcut); locks (HolderWrites); change feed; quota bills the space; WOPI; audit with the space id. - Public links on space content follow the same rule (#1034). Next: whole-page mockups (owner's share dialog with the space rule, the space's share list, recipient's view), then spec and plan.
Author
Owner

Mockup approved (Nikola, 2026-10-28)

design-direction-decision-needed/1035-space-sharing-mockup.html, frames A to F, with the recommended answers:

  1. Optional "Until" on every space share, default never; the instance maximum share expiry applies.
  2. No owner approval of member shares; choosing "members with read + write" is the approval.
  3. Moves inside the space carry the share; moving out ends it after a warning ("Move and end n shares"); trash pauses, restore resumes, purge ends. Same for links.
  4. No separate per-space link toggle; one rule plus the existing instance switch for links from Spaces.
  5. Bell to the space owner when a member shares, one item per share, mutable (on by default).
  6. Every member sees all shares on an item and who made them; changes/removes only their own; owner and admins any.
  7. Existing members can't be picked (409 space-share-member); groups containing members are fine.
  8. Tightening the rule: existing shares stay, marked "Outside this space's rule" / "Outside policy"; nothing pauses or reopens silently.
  9. Recipient path /shared/<space> (Space)/….
  10. Space deactivated or deleted: shares pause, resume on reactivate/restore, end on final delete.
  11. Owner CSV export with "made by", audited.
  12. Directory spaces: the recorded owner sets the rule; with no recorded owner, admins only.
  13. Admin policy "Who may share items from a Space": the space decides / owners only / nobody.

Next: spec and plan, then build.

## Mockup approved (Nikola, 2026-10-28) `design-direction-decision-needed/1035-space-sharing-mockup.html`, frames A to F, with the recommended answers: 1. Optional "Until" on every space share, default never; the instance maximum share expiry applies. 2. No owner approval of member shares; choosing "members with read + write" is the approval. 3. Moves inside the space carry the share; moving out ends it after a warning ("Move and end n shares"); trash pauses, restore resumes, purge ends. Same for links. 4. No separate per-space link toggle; one rule plus the existing instance switch for links from Spaces. 5. Bell to the space owner when a member shares, one item per share, mutable (on by default). 6. Every member sees all shares on an item and who made them; changes/removes only their own; owner and admins any. 7. Existing members can't be picked (`409 space-share-member`); groups containing members are fine. 8. Tightening the rule: existing shares stay, marked "Outside this space's rule" / "Outside policy"; nothing pauses or reopens silently. 9. Recipient path `/shared/<space> (Space)/…`. 10. Space deactivated or deleted: shares pause, resume on reactivate/restore, end on final delete. 11. Owner CSV export with "made by", audited. 12. Directory spaces: the recorded owner sets the rule; with no recorded owner, admins only. 13. Admin policy "Who may share items from a Space": the space decides / owners only / nobody. Next: spec and plan, then build.
Author
Owner

Spec decisions (Nikola, 2026-10-28/29)

  • Space root: research (OpenCloud/oCIS, oC10, Nextcloud, SharePoint, Google, Box, Dropbox, Seafile; incidents: Microsoft AI 38 TB whole-container link 2023, Box public folder links 2019; NIST AC-6/21/22, CISA SCuBA GWS 2.2, GDPR 25(2)). Person/group shares on a space root are refused: "This is the whole space. To give {name} access to everything in {space}, add them as a member." (members with write: "Only the owner can give access to the whole space…"). Links on the root: space owner only, after a "whole space" confirm, shown as "Whole space"; admin policy "Links to a whole space: space owners / nobody".
  • WebDAV MOVE out of a space while the item has shares: refused (403 with a code); the web asks first ("Move and end n shares").
  • Rollback to v0.6.368 deletes space shares for good (v0.6.366 start cleanup): accepted, upgrade notes say to export the share list first.
  • Included now (not follow-ups): devices can bind inside a space share; directory group changes that remove someone from a space trigger the "member left" handling/bell; former space names resolve under /shared.
  • Follow-up issue: an optional "Until" date on space membership (OpenCloud has member expiry).
## Spec decisions (Nikola, 2026-10-28/29) - **Space root:** research (OpenCloud/oCIS, oC10, Nextcloud, SharePoint, Google, Box, Dropbox, Seafile; incidents: Microsoft AI 38 TB whole-container link 2023, Box public folder links 2019; NIST AC-6/21/22, CISA SCuBA GWS 2.2, GDPR 25(2)). Person/group shares on a space root are refused: "This is the whole space. To give {name} access to everything in {space}, add them as a member." (members with write: "Only the owner can give access to the whole space…"). Links on the root: space owner only, after a "whole space" confirm, shown as "Whole space"; admin policy "Links to a whole space: space owners / nobody". - **WebDAV MOVE out of a space** while the item has shares: refused (403 with a code); the web asks first ("Move and end n shares"). - **Rollback** to v0.6.368 deletes space shares for good (v0.6.366 start cleanup): accepted, upgrade notes say to export the share list first. - **Included now (not follow-ups):** devices can bind inside a space share; directory group changes that remove someone from a space trigger the "member left" handling/bell; former space names resolve under /shared. - Follow-up issue: an optional "Until" date on space membership (OpenCloud has member expiry).
Author
Owner

Strings approved (Nikola, 2026-10-29)

EN/DE from the mockup (German "Spaces", Sie form, ß in de), FR/IT per the style guide. FR / IT for the new keys:

admChipFormer: Créés par d’anciens membres / Creati da ex membri · admMadeBy: créé par {name} / creato da {name} · admSpaceRootLinks: Liens vers un espace entier / Link a uno spazio intero · admSpaceRootLinksNone: Personne / Nessuno · admSpaceRootLinksOwners: Propriétaires des espaces / Proprietari degli spazi · admSpaceWho: Qui peut partager des éléments d’un espace / Chi può condividere elementi di uno spazio · admSpaceWhoMembers: Le propriétaire et, là où l’espace l’autorise, les membres avec Lecture + écriture (par défaut) / Il proprietario e, dove lo spazio lo consente, i membri con Lettura + scrittura (predefinito) · admSpaceWhoNone: Personne : les éléments des espaces ne sont partagés que par l’appartenance / Nessuno: gli elementi degli spazi si condividono solo tramite l’appartenenza · admSpaceWhoOwner: Uniquement le propriétaire de l’espace / Solo il proprietario dello spazio · bellMemberLeft / bellMemberShared / bellOwnerRemoved · detFrom: Provenance / Provenienza · detFromSpace · errAboveRole · errExpiryMax · errExpiryRequired · errIsMember · errNotYours · errOwnerOnly · errRoleNow · errRootLinkOff · errRootLinkOwner · errRootMember · errRootOwner · errShareRootSpace · errSpacesOff · linkRootConfirm · linkRootGo: Créer un lien vers l’espace entier / Crea link all’intero spazio · memRemove* · moveOutGo: Déplacer et mettre fin à {k} partages / Sposta e termina {k} condivisioni · moveOutWarn · notifPrefSpaceShares(D) · pickLocal: Compte local / Account locale · pickMember · rootAddMember: Ajouter comme membre / Aggiungi come membro · rootShareFolder: Partager plutôt un dossier / Condividi invece una cartella · rowSharedOut · shFromSpace: {space} · Espace / {space} · Spazio · shFromSpaceBy · shareMadeBy(Former/You) · shareOutsideHd · shareSpaceHint · shareSpaceNote · shareSpaceOwnerOnly · shareSpaceReadOnly · shareUntil: Expiration / Scadenza · spBadgeFormer: N’est plus membre / Non più membro · spBadgeNowMember · spBadgeRule: Hors de la règle de cet espace / Fuori dalla regola dello spazio · spBadgeRuleTip · spBadgeWholeSpace: Tout l’espace / Intero spazio · spExportCsv · spFilterMadeBy · spListFoot · spMadeBy · spSearch · spSharing / spTabShares: Partages / Condivisioni · spSharingTitle · spState* · spTabSettings · spTighten* · spWho* · spaceDelShares · until*.

(Full texts are in web/static/index.html at v0.6.370.)

## Strings approved (Nikola, 2026-10-29) EN/DE from the mockup (German "Spaces", Sie form, ß in de), FR/IT per the style guide. FR / IT for the new keys: admChipFormer: Créés par d’anciens membres / Creati da ex membri · admMadeBy: créé par {name} / creato da {name} · admSpaceRootLinks: Liens vers un espace entier / Link a uno spazio intero · admSpaceRootLinksNone: Personne / Nessuno · admSpaceRootLinksOwners: Propriétaires des espaces / Proprietari degli spazi · admSpaceWho: Qui peut partager des éléments d’un espace / Chi può condividere elementi di uno spazio · admSpaceWhoMembers: Le propriétaire et, là où l’espace l’autorise, les membres avec Lecture + écriture (par défaut) / Il proprietario e, dove lo spazio lo consente, i membri con Lettura + scrittura (predefinito) · admSpaceWhoNone: Personne : les éléments des espaces ne sont partagés que par l’appartenance / Nessuno: gli elementi degli spazi si condividono solo tramite l’appartenenza · admSpaceWhoOwner: Uniquement le propriétaire de l’espace / Solo il proprietario dello spazio · bellMemberLeft / bellMemberShared / bellOwnerRemoved · detFrom: Provenance / Provenienza · detFromSpace · errAboveRole · errExpiryMax · errExpiryRequired · errIsMember · errNotYours · errOwnerOnly · errRoleNow · errRootLinkOff · errRootLinkOwner · errRootMember · errRootOwner · errShareRootSpace · errSpacesOff · linkRootConfirm · linkRootGo: Créer un lien vers l’espace entier / Crea link all’intero spazio · memRemove* · moveOutGo: Déplacer et mettre fin à {k} partages / Sposta e termina {k} condivisioni · moveOutWarn · notifPrefSpaceShares(D) · pickLocal: Compte local / Account locale · pickMember · rootAddMember: Ajouter comme membre / Aggiungi come membro · rootShareFolder: Partager plutôt un dossier / Condividi invece una cartella · rowSharedOut · shFromSpace: {space} · Espace / {space} · Spazio · shFromSpaceBy · shareMadeBy(Former/You) · shareOutsideHd · shareSpaceHint · shareSpaceNote · shareSpaceOwnerOnly · shareSpaceReadOnly · shareUntil: Expiration / Scadenza · spBadgeFormer: N’est plus membre / Non più membro · spBadgeNowMember · spBadgeRule: Hors de la règle de cet espace / Fuori dalla regola dello spazio · spBadgeRuleTip · spBadgeWholeSpace: Tout l’espace / Intero spazio · spExportCsv · spFilterMadeBy · spListFoot · spMadeBy · spSearch · spSharing / spTabShares: Partages / Condivisioni · spSharingTitle · spState* · spTabSettings · spTighten* · spWho* · spaceDelShares · until*. (Full texts are in web/static/index.html at v0.6.370.)
Author
Owner

Shipped in v0.6.370 (PR #1041), both dogfoods bumped.

Items in a space can be shared with people and groups who aren't members, under the per-space rule (owner only by default) and the instance cap; shares belong to the space (owner's Sharing dialog with Shares + Settings and CSV); recipients see /shared/<space> (Space)/…; no re-sharing (links, peering, OCM included); root shares refused, root links owner-only with confirm; devices can bind inside a space share; directory leave noticed; former names resolve. Lifecycle: moves carry, WebDAV move-out refused, trash pauses, trash-off delete ends, folder overwrite parks with the replaced folder, Office save keeps the share. Read-only members can no longer make links; in a space only the owner makes links until the rule is opened. Rollback to v0.6.368 deletes space shares (export the CSV first).

Effective right follows the approved model (spec §4.3): a share keeps its role if the maker later drops to Read only or leaves; tightening the rule or cap marks shares "Outside this space's rule / policy" rather than reducing them.

Live checks added to #1005.

Shipped in v0.6.370 (PR #1041), both dogfoods bumped. Items in a space can be shared with people and groups who aren't members, under the per-space rule (owner only by default) and the instance cap; shares belong to the space (owner's Sharing dialog with Shares + Settings and CSV); recipients see `/shared/<space> (Space)/…`; no re-sharing (links, peering, OCM included); root shares refused, root links owner-only with confirm; devices can bind inside a space share; directory leave noticed; former names resolve. Lifecycle: moves carry, WebDAV move-out refused, trash pauses, trash-off delete ends, folder overwrite parks with the replaced folder, Office save keeps the share. Read-only members can no longer make links; in a space only the owner makes links until the rule is opened. Rollback to v0.6.368 deletes space shares (export the CSV first). Effective right follows the approved model (spec §4.3): a share keeps its role if the maker later drops to Read only or leaves; tightening the rule or cap marks shares "Outside this space's rule / policy" rather than reducing them. Live checks added to #1005.
Cordy closed this issue 2026-10-28 22:48:49 +00:00
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#1035
No description provided.