Open Cloud Mesh shares out of a Personal folder do not follow a rename and are not guarded by the item id #1057
Closed
opened 2026-10-31 07:48:25 +00:00 by Cordy
·
4 comments
No Branch/Tag specified
main
b12v07
b11v07
b10v07
ci-rc-publish
fx15-s3dry
b9v07
b8v07
bench742
b7v07
legal-texts-v0.2
b6v07
b5v07
b4v07
b3v07
sx1139
st742
b2v07
ix1102
fu1098
zp1097
wd1099
tr1100
qf1077
nc1070
ci1
rp1072
lk1073
ab1071
fi1074
si1070
ra1054
wo1056
oc1057
tf1055
sv1063
fg1059
st1058
fs929
mu1039
ls1033
cf975
lf835
dx1023
ml896
a11y2
av1022
r913
r7
r6
r5
r45
r23
r1
b10
b9
fix-b5
fix-b4
fix-b3
fix-b2
fix-b1
fix-922
fix-923
fix-911
fix-343b
batch-a
v0.6.413
v0.6.412
v0.6.411
v0.6.410
v0.6.409
v0.6.408
v0.6.407
v0.6.406
v0.6.405
v0.6.404
v0.6.403
v0.6.402
v0.6.401
v0.6.400
v0.6.399
v0.6.398
v0.6.397
v0.6.396
v0.6.395
v0.6.394
v0.6.393
v0.6.392
v0.6.391
v0.6.390
v0.6.389
v0.6.388
v0.6.387
v0.6.386
v0.6.385
v0.6.384
v0.6.383
v0.6.382
v0.6.381
v0.6.380
v0.6.379
v0.6.378
v0.6.377
v0.6.376
v0.6.375
v0.6.374
v0.6.373
v0.6.372
v0.6.371
v0.6.370
v0.6.369
v0.6.368
v0.6.367
v0.6.366
v0.6.365
v0.6.364
v0.6.363
v0.6.362
v0.6.361
v0.6.360
v0.6.359
v0.6.358
v0.6.357
v0.6.356
v0.6.355
v0.6.354
v0.6.353
v0.6.352
v0.6.351
v0.6.350
v0.6.349
v0.6.348
v0.6.347
v0.6.346
v0.6.345
v0.6.344
v0.6.343
v0.6.342
v0.6.341
v0.6.340
v0.6.339
v0.6.338
v0.6.337
v0.6.336
v0.6.335
v0.6.334
v0.6.333
v0.6.332
v0.6.331
v0.6.330
v0.6.329
v0.6.328
v0.6.327
v0.6.326
v0.6.325
v0.6.324
v0.6.323
v0.6.322
v0.6.321
v0.6.320
v0.6.319
v0.6.318
v0.6.317
v0.6.316
v0.6.315
v0.6.314
v0.6.313
v0.6.312
v0.6.311
v0.6.310
v0.6.309
v0.6.308
v0.6.307
v0.6.306
v0.6.305
v0.6.304
v0.6.303
v0.6.302
v0.6.301
v0.6.300
v0.6.299
v0.6.298
v0.6.297
v0.6.296
v0.6.295
v0.6.294
v0.6.293
v0.6.292
v0.6.291
v0.6.290
v0.6.289
v0.6.288
v0.6.287
v0.6.286
v0.6.285
v0.6.284
v0.6.283
v0.6.282
v0.6.281
v0.6.280
v0.6.279
v0.6.278
v0.6.277
v0.6.276
v0.6.275
v0.6.274
v0.6.273
v0.6.272
v0.6.271
v0.6.270
v0.6.269
v0.6.268
v0.6.267
v0.6.266
v0.6.265
v0.6.264
v0.6.263
v0.6.262
v0.6.261
v0.6.260
v0.6.259
v0.6.258
v0.6.257
v0.6.256
v0.6.255
v0.6.254
v0.6.253
v0.6.252
v0.6.251
v0.6.250
v0.6.249
v0.6.248
v0.6.247
v0.6.246
v0.6.245
v0.6.244
v0.6.243
v0.6.242
v0.6.241
v0.6.240
v0.6.239
v0.6.238
v0.6.237
v0.6.236
v0.6.235
v0.6.234
v0.6.233
v0.6.232
v0.6.231
v0.6.230
v0.6.229
v0.6.228
v0.6.227
v0.6.226
v0.6.225
v0.6.224
v0.6.223
v0.6.222
v0.6.221
v0.6.220
v0.6.219
v0.6.218
v0.6.217
v0.6.216
v0.6.215
v0.6.214
v0.6.213
v0.6.212
v0.6.211
v0.6.210
v0.6.209
v0.6.208
v0.6.207
v0.6.206
v0.6.205
v0.6.204
v0.6.203
v0.6.202
v0.6.201
v0.6.200
v0.6.199
v0.6.198
v0.6.197
v0.6.196
v0.6.195
v0.6.194
v0.6.193
v0.6.192
v0.6.191
v0.6.190
v0.6.189
v0.6.188
v0.6.187
v0.6.186
v0.6.185
v0.6.184
v0.6.183
v0.6.182
v0.6.181
v0.6.180
v0.6.179
v0.6.178
v0.6.177
v0.6.176
v0.6.175
v0.6.174
v0.6.173
v0.6.172
v0.6.171
v0.6.170
v0.6.169
v0.6.168
v0.6.167
v0.6.166
v0.6.165
v0.6.164
v0.6.163
v0.6.162
v0.6.161
v0.6.160
v0.6.159
v0.6.158
v0.6.157
v0.6.156
v0.6.155
v0.6.154
v0.6.153
v0.6.152
v0.6.151
v0.6.150
v0.6.149
v0.6.148
v0.6.147
v0.6.146
v0.6.145
v0.6.144
v0.6.143
v0.6.142
v0.6.141
v0.6.140
v0.6.139
v0.6.138
v0.6.137
v0.6.136
v0.6.135
v0.6.134
v0.6.133
v0.6.132
v0.6.131
v0.6.130
v0.6.129
v0.6.128
v0.6.127
v0.6.126
v0.6.125
v0.6.124
v0.6.123
v0.6.122
v0.6.121
v0.6.120
v0.6.119
v0.6.118
v0.6.117
v0.6.116
v0.6.115
v0.6.114
v0.6.113
v0.6.112
v0.6.111
v0.6.110
v0.6.109
v0.6.108
v0.6.107
v0.6.106
v0.6.105
v0.6.104
v0.6.103
v0.6.102
v0.6.101
v0.6.100
v0.6.99
v0.6.98
v0.6.97
v0.6.96
v0.6.95
v0.6.94
v0.6.93
v0.6.92
v0.6.91
v0.6.90
v0.6.89
v0.6.88
v0.6.87
v0.6.86
v0.6.85
v0.6.84
v0.6.83
v0.6.82
v0.6.81
v0.6.80
v0.6.79
v0.6.78
v0.6.77
v0.6.76
v0.6.75
v0.6.74
v0.6.73
v0.6.72
v0.6.71
v0.6.70
v0.6.69
v0.6.68
v0.6.67
v0.6.66
v0.6.65
v0.6.64
v0.6.63
v0.6.62
v0.6.61
v0.6.60
v0.6.59
v0.6.58
v0.6.57
v0.6.56
v0.6.55
v0.6.54
v0.6.53
v0.6.52
v0.6.51
v0.6.50
v0.6.49
v0.6.48
v0.6.47
v0.6.46
v0.6.45
v0.6.44
v0.6.43
v0.6.42
v0.6.41
v0.6.40
v0.6.39
v0.6.38
v0.6.37
v0.6.36
v0.6.35
v0.6.34
v0.6.33
v0.6.32
v0.6.31
v0.6.30
v0.6.29
v0.6.28
v0.6.25
v0.6.24
v0.6.23
v0.6.22
v0.6.21
v0.6.20
v0.6.19
v0.6.18
v0.6.17
v0.6.16
v0.6.15
v0.6.14
v0.6.12
v0.6.11
v0.6.10
v0.6.9
v0.6.8
v0.6.7
v0.6.6
v0.6.5
v0.6.4
v0.6.3
v0.6.2
v0.6.1
v0.6.0
v0.5.7
v0.5.6
v0.5.5
v0.5.4
v0.5.3
v0.5.2
v0.5.1
v0.5.0
v0.4.12
v0.4.11
v0.4.10
v0.4.9
v0.4.8
v0.4.7
v0.4.6
v0.4.5
v0.4.4
v0.4.3
v0.4.2
v0.4.1
v0.3.30
v0.3.29
v0.3.28
v0.3.27
v0.3.26
v0.3.25
v0.3.24
v0.3.23
v0.3.22
v0.3.21
v0.3.20
v0.3.19
v0.3.18
v0.3.17
v0.3.16
v0.3.15
v0.3.14
v0.3.13
v0.3.12
v0.3.11
v0.3.10
v0.3.9
v0.3.8
v0.3.7
v0.3.6
v0.3.5
v0.3.4
v0.3.3
v0.3.2
v0.3.1
v0.3.0
v0.2.7
v0.2.6
v0.2.5
v0.2.4
v0.2.3
v0.2.2
v0.2.1
v0.2.0
v0.0.3
v0.0.2
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference: Cordy/Cairn#1057
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem. An OCM share to a user on another instance (
internal/ocm,ShareOut{Path, LocalUser, ...}) binds to a path. Renaming or moving the shared item in Cairn leaves the OCM share on the old path: the remote side gets 404. Worse, a different item that later takes the old path is served to the remote recipient: the path-reuse gap that #835 closed for public links and person and group shares is still open for OCM shares. A delete into Deleted files does not pause them either.Today. #835 (v0.6.376) covers links and grants in the share store only; OCM keeps its own records (
ocmstate,sharesOut). The handbook names it as a known limit (sharing.md, Known limits of Personal links and shares).Proposal.
EnsureItemID) on each newShareOut, stamp existing ones once (asstampItemIDsdoes for the share store), and check it in the OCM WebDAV handler (/dav/ocm/<providerId>/) withshare.CheckItem: a different item answers 404.composeShareHooks); end on a confirmed move out (with the existing confirm counting OCM shares too) and refuse otherwise; pause with Deleted files, resume on restore, end on purge.Acceptance. Tests: an OCM share on a file, the file renamed in Cairn: the remote request still reads it; a new file at the old name is never served to the remote; delete pauses, restore resumes.
Refs. #835 spec §14, #835 decision 7 (item guard), #1035.
Follow-up of #835 (v0.6.376).
Research (2026-10-31, code at v0.6.380).
/dav/ocm/<providerId>/, no path. The OCM spec (cs3org OCM-API, draft-07) calls the share id opaque and has no rename notification; Nextcloud and Reva (oCIS/OpenCloud) send the name once. Updating our side is enough.ShareOut.Pathis served byGrantHandler(internal/ocm/grant.go:44-91) with no item check, and nothing ininternal/ocmreacts to rename, move, delete, restore, purge or transfer. OCM.md promises the share "ends honestly" on rename; never built. A new file at the old name would be served to the remote (path-reuse gap).ShareOutBySecrethas no caller; only Nextcloud to Cairn is live-tested); outgoing notifications lacksenderDomainandnotification.file.providerIdfrom the current draft.Recommended: the #835 lifecycle for OCM shares through the same hooks: item id stamped at send and once at start (
ocm-itemids.json), guard on every method, follow inside Personal, counted in the move-out confirm, pause/resume/end with Deleted files, SHARE_UNSHARED on end, re-point paused on owner transfer, freeze for departed owners, record-level writes. Questions are being asked now. Full file: research-1057.md.Decisions (Nikola, 2026-10-31): all research recommendations approved. The #835 lifecycle for OCM shares out of Personal: follow inside Personal (remote not notified; Cairn shows "Shared as {name}"), counted in the one move-out confirm and ended on confirmation, pause/resume/end with Deleted files, item guard on every method, SHARE_UNSHARED on end, re-point paused on owner transfer under the same checkbox, freeze for departed/disabled owners, record-level ledger writes (#742), notification fields up to the current draft, a homes-off path test. Separate issues: Nextcloud reading from Cairn (after a live check) and OCM shares in the admin Shares list. Next: whole-page mockups, then spec and build.
Mockup approved (Nikola, 2026-11-01):
1057-ocm-follow-mockup.html(37 new keys) with the open points as recommended: federated shares count as shares in "shares and links" (listed by name with "federated"); "Ended" lines stay until dismissed (only for ends Cairn made); Turn on for a handed-over federated share needs no confirm; Can view / Can edit instead ofread+write; the new field in the OCM shares answer isstate. The first version of the file did not render (a duplicate<style>tag); it is fixed and kept as the reference of the intended look. Next: spec and build.Released in v0.6.385 (PR #1068), live on both dogfoods since 11:58 UTC. Pods are ready and log no new WARN or ERROR lines. The OCM stamp ran with
records=0on both, since neither dogfood has a federated share out.What changed
SHARE_UNSHAREDwithsharedSecret, from a background sender that signs as the share's sending domain;wrong-path, and the other server is told whenshares.baseUrlis set.Follow-ups filed: #1070 (a Nextcloud reading from Cairn, live check first), #1071 (federated shares in the admin Shares list), #1072 (restore pause for federated shares out).
Live checks are in #1005.