v0.6.394: an admin revoke of an earlier account's share no longer reaches the current name holder (#1077) #1096

Merged
Cordy merged 2 commits from qf1077 into main 2026-11-04 01:29:49 +00:00
Owner

Quick fix for #1077 (decided 2026-11-03 after the deep dive). Refs #1077; the issue stays open for the broader research.

  • adminRevokeOne returns a zero Revocation and records no Activity when the share's creator is not the current account (!h.creatorHolds(s)). The audit line share-admin-revoke is unchanged.
  • After a Give the shares belong to the current account and their revoke is told as before.
  • Tests: internal/api/qf1077_test.go. CHANGELOG v0.6.394, chart appVersion.
Quick fix for #1077 (decided 2026-11-03 after the deep dive). Refs #1077; the issue stays open for the broader research. - `adminRevokeOne` returns a zero Revocation and records no Activity when the share's creator is not the current account (`!h.creatorHolds(s)`). The audit line `share-admin-revoke` is unchanged. - After a Give the shares belong to the current account and their revoke is told as before. - Tests: `internal/api/qf1077_test.go`. CHANGELOG v0.6.394, chart appVersion.
adminRevokeOne (single, bulk, group review) answers no tombstone and
records no share-removed Activity when !creatorHolds(s): the name's
current account is another person (#1054) and its bell named the earlier
person's file and recipient. The revoke and its audit line stay; after
Give and for the current account's own records the bell rings as before.

adminfed1071_test h.: the bulk link and grant get a CreatedAt after
fiona's start; without one they are an earlier account's (fail closed)
and now answer no tombstone.

CHANGELOG v0.6.394 (Security), chart appVersion v0.6.394, sharing.md.
Merge remote-tracking branch 'origin/main' into qf1077
All checks were successful
ci / test-and-build (pull_request) Successful in 3m30s
38cb748ffa
Cordy merged commit 0e0885db0e into main 2026-11-04 01:29:49 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#1096
No description provided.