A name used again: spaces, admin lists, notices, OCM contacts and bell items are still keyed by name (#1054 follow-up) #1077

Open
opened 2026-11-02 19:05:22 +00:00 by Cordy · 1 comment
Owner

Problem. #1054 (v0.6.387) separates an earlier account from the current holder of a username for shares, links, the Personal folder, credentials, favourites, recents, tags and federated shares. State keyed only by the username still passes from the earlier person to the current one:

  • Spaces: membership, ownership and space shares to a user addressee, app-owned space members and owners (spec 15.1, decision D10).
  • Admin lists (admin.users), profiles and seats.
  • Saved notices and per-name bell items, muted kinds, sign-in failure records.
  • OCM contacts and invites: the current account sees the earlier person's federated contacts.
  • An administrator's revoke of an earlier account's link or grant writes a bell item dated now, so the current holder of the name sees the earlier file and recipient (internal/api/notify.go:449, :986; found in the #1071 research, decided on 2026-11-02 to go here rather than into #1071).

Today. The earlier/current rule is creatorSince / addresseeSince against the account start (#981, first-signins.json).

Next step. Research by the playbook: how other products key these by immutable id (Nextcloud user ids, Microsoft Entra object id, Google user id), and what broke for them. Then decide per item: re-key by the directory's user id, stamp with the account start, or hand over with Give.

Refs: #1054 spec section 15, #981, #1071 research-1071-unsettled.md U3/N4.

**Problem.** #1054 (v0.6.387) separates an earlier account from the current holder of a username for shares, links, the Personal folder, credentials, favourites, recents, tags and federated shares. State keyed only by the username still passes from the earlier person to the current one: - Spaces: membership, ownership and space shares to a user addressee, app-owned space members and owners (spec 15.1, decision D10). - Admin lists (`admin.users`), profiles and seats. - Saved notices and per-name bell items, muted kinds, sign-in failure records. - OCM contacts and invites: the current account sees the earlier person's federated contacts. - An administrator's revoke of an earlier account's link or grant writes a bell item dated now, so the current holder of the name sees the earlier file and recipient (`internal/api/notify.go:449`, `:986`; found in the #1071 research, decided on 2026-11-02 to go here rather than into #1071). **Today.** The earlier/current rule is `creatorSince` / `addresseeSince` against the account start (#981, `first-signins.json`). **Next step.** Research by the playbook: how other products key these by immutable id (Nextcloud user ids, Microsoft Entra object id, Google user id), and what broke for them. Then decide per item: re-key by the directory's user id, stamp with the account start, or hand over with Give. Refs: #1054 spec section 15, #981, #1071 research-1071-unsettled.md U3/N4.
Author
Owner

The quick fix shipped in v0.6.394 (PR #1096, merge 0e0885db); both dogfoods run it with 0 restarts and no ERROR lines.

When the share's creator is not the current account, an admin revoke now leaves no bell item and no Activity entry. The share-admin-revoke audit line still carries the owner and the addressee. After a Give, the shares belong to the current account, so their revoke is announced as before. One trade-off: administrators also lose the share-removed entry in that file's Activity for earlier-account records. The audit keeps the full record. Keeping the entry for admins would need a filter when Activity is read.

The live-check lines are on #1005 under "v0.6.394 (#1077 …)". This issue stays open for the broader research.

The quick fix shipped in **v0.6.394** (PR #1096, merge 0e0885db); both dogfoods run it with 0 restarts and no ERROR lines. When the share's creator is not the current account, an admin revoke now leaves no bell item and no Activity entry. The `share-admin-revoke` audit line still carries the owner and the addressee. After a Give, the shares belong to the current account, so their revoke is announced as before. One trade-off: administrators also lose the `share-removed` entry in that file's Activity for earlier-account records. The audit keeps the full record. Keeping the entry for admins would need a filter when Activity is read. The live-check lines are on #1005 under "v0.6.394 (#1077 …)". This issue stays open for the broader research.
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#1077
No description provided.