Closed
opened 2026-09-17 01:14:01 +00:00 by Cordy
·
4 comments
No Branch/Tag specified
main
b12v07
b11v07
b10v07
ci-rc-publish
fx15-s3dry
b9v07
b8v07
bench742
b7v07
legal-texts-v0.2
b6v07
b5v07
b4v07
b3v07
sx1139
st742
b2v07
ix1102
fu1098
zp1097
wd1099
tr1100
qf1077
nc1070
ci1
rp1072
lk1073
ab1071
fi1074
si1070
ra1054
wo1056
oc1057
tf1055
sv1063
fg1059
st1058
fs929
mu1039
ls1033
cf975
lf835
dx1023
ml896
a11y2
av1022
r913
r7
r6
r5
r45
r23
r1
b10
b9
fix-b5
fix-b4
fix-b3
fix-b2
fix-b1
fix-922
fix-923
fix-911
fix-343b
batch-a
v0.6.413
v0.6.412
v0.6.411
v0.6.410
v0.6.409
v0.6.408
v0.6.407
v0.6.406
v0.6.405
v0.6.404
v0.6.403
v0.6.402
v0.6.401
v0.6.400
v0.6.399
v0.6.398
v0.6.397
v0.6.396
v0.6.395
v0.6.394
v0.6.393
v0.6.392
v0.6.391
v0.6.390
v0.6.389
v0.6.388
v0.6.387
v0.6.386
v0.6.385
v0.6.384
v0.6.383
v0.6.382
v0.6.381
v0.6.380
v0.6.379
v0.6.378
v0.6.377
v0.6.376
v0.6.375
v0.6.374
v0.6.373
v0.6.372
v0.6.371
v0.6.370
v0.6.369
v0.6.368
v0.6.367
v0.6.366
v0.6.365
v0.6.364
v0.6.363
v0.6.362
v0.6.361
v0.6.360
v0.6.359
v0.6.358
v0.6.357
v0.6.356
v0.6.355
v0.6.354
v0.6.353
v0.6.352
v0.6.351
v0.6.350
v0.6.349
v0.6.348
v0.6.347
v0.6.346
v0.6.345
v0.6.344
v0.6.343
v0.6.342
v0.6.341
v0.6.340
v0.6.339
v0.6.338
v0.6.337
v0.6.336
v0.6.335
v0.6.334
v0.6.333
v0.6.332
v0.6.331
v0.6.330
v0.6.329
v0.6.328
v0.6.327
v0.6.326
v0.6.325
v0.6.324
v0.6.323
v0.6.322
v0.6.321
v0.6.320
v0.6.319
v0.6.318
v0.6.317
v0.6.316
v0.6.315
v0.6.314
v0.6.313
v0.6.312
v0.6.311
v0.6.310
v0.6.309
v0.6.308
v0.6.307
v0.6.306
v0.6.305
v0.6.304
v0.6.303
v0.6.302
v0.6.301
v0.6.300
v0.6.299
v0.6.298
v0.6.297
v0.6.296
v0.6.295
v0.6.294
v0.6.293
v0.6.292
v0.6.291
v0.6.290
v0.6.289
v0.6.288
v0.6.287
v0.6.286
v0.6.285
v0.6.284
v0.6.283
v0.6.282
v0.6.281
v0.6.280
v0.6.279
v0.6.278
v0.6.277
v0.6.276
v0.6.275
v0.6.274
v0.6.273
v0.6.272
v0.6.271
v0.6.270
v0.6.269
v0.6.268
v0.6.267
v0.6.266
v0.6.265
v0.6.264
v0.6.263
v0.6.262
v0.6.261
v0.6.260
v0.6.259
v0.6.258
v0.6.257
v0.6.256
v0.6.255
v0.6.254
v0.6.253
v0.6.252
v0.6.251
v0.6.250
v0.6.249
v0.6.248
v0.6.247
v0.6.246
v0.6.245
v0.6.244
v0.6.243
v0.6.242
v0.6.241
v0.6.240
v0.6.239
v0.6.238
v0.6.237
v0.6.236
v0.6.235
v0.6.234
v0.6.233
v0.6.232
v0.6.231
v0.6.230
v0.6.229
v0.6.228
v0.6.227
v0.6.226
v0.6.225
v0.6.224
v0.6.223
v0.6.222
v0.6.221
v0.6.220
v0.6.219
v0.6.218
v0.6.217
v0.6.216
v0.6.215
v0.6.214
v0.6.213
v0.6.212
v0.6.211
v0.6.210
v0.6.209
v0.6.208
v0.6.207
v0.6.206
v0.6.205
v0.6.204
v0.6.203
v0.6.202
v0.6.201
v0.6.200
v0.6.199
v0.6.198
v0.6.197
v0.6.196
v0.6.195
v0.6.194
v0.6.193
v0.6.192
v0.6.191
v0.6.190
v0.6.189
v0.6.188
v0.6.187
v0.6.186
v0.6.185
v0.6.184
v0.6.183
v0.6.182
v0.6.181
v0.6.180
v0.6.179
v0.6.178
v0.6.177
v0.6.176
v0.6.175
v0.6.174
v0.6.173
v0.6.172
v0.6.171
v0.6.170
v0.6.169
v0.6.168
v0.6.167
v0.6.166
v0.6.165
v0.6.164
v0.6.163
v0.6.162
v0.6.161
v0.6.160
v0.6.159
v0.6.158
v0.6.157
v0.6.156
v0.6.155
v0.6.154
v0.6.153
v0.6.152
v0.6.151
v0.6.150
v0.6.149
v0.6.148
v0.6.147
v0.6.146
v0.6.145
v0.6.144
v0.6.143
v0.6.142
v0.6.141
v0.6.140
v0.6.139
v0.6.138
v0.6.137
v0.6.136
v0.6.135
v0.6.134
v0.6.133
v0.6.132
v0.6.131
v0.6.130
v0.6.129
v0.6.128
v0.6.127
v0.6.126
v0.6.125
v0.6.124
v0.6.123
v0.6.122
v0.6.121
v0.6.120
v0.6.119
v0.6.118
v0.6.117
v0.6.116
v0.6.115
v0.6.114
v0.6.113
v0.6.112
v0.6.111
v0.6.110
v0.6.109
v0.6.108
v0.6.107
v0.6.106
v0.6.105
v0.6.104
v0.6.103
v0.6.102
v0.6.101
v0.6.100
v0.6.99
v0.6.98
v0.6.97
v0.6.96
v0.6.95
v0.6.94
v0.6.93
v0.6.92
v0.6.91
v0.6.90
v0.6.89
v0.6.88
v0.6.87
v0.6.86
v0.6.85
v0.6.84
v0.6.83
v0.6.82
v0.6.81
v0.6.80
v0.6.79
v0.6.78
v0.6.77
v0.6.76
v0.6.75
v0.6.74
v0.6.73
v0.6.72
v0.6.71
v0.6.70
v0.6.69
v0.6.68
v0.6.67
v0.6.66
v0.6.65
v0.6.64
v0.6.63
v0.6.62
v0.6.61
v0.6.60
v0.6.59
v0.6.58
v0.6.57
v0.6.56
v0.6.55
v0.6.54
v0.6.53
v0.6.52
v0.6.51
v0.6.50
v0.6.49
v0.6.48
v0.6.47
v0.6.46
v0.6.45
v0.6.44
v0.6.43
v0.6.42
v0.6.41
v0.6.40
v0.6.39
v0.6.38
v0.6.37
v0.6.36
v0.6.35
v0.6.34
v0.6.33
v0.6.32
v0.6.31
v0.6.30
v0.6.29
v0.6.28
v0.6.25
v0.6.24
v0.6.23
v0.6.22
v0.6.21
v0.6.20
v0.6.19
v0.6.18
v0.6.17
v0.6.16
v0.6.15
v0.6.14
v0.6.12
v0.6.11
v0.6.10
v0.6.9
v0.6.8
v0.6.7
v0.6.6
v0.6.5
v0.6.4
v0.6.3
v0.6.2
v0.6.1
v0.6.0
v0.5.7
v0.5.6
v0.5.5
v0.5.4
v0.5.3
v0.5.2
v0.5.1
v0.5.0
v0.4.12
v0.4.11
v0.4.10
v0.4.9
v0.4.8
v0.4.7
v0.4.6
v0.4.5
v0.4.4
v0.4.3
v0.4.2
v0.4.1
v0.3.30
v0.3.29
v0.3.28
v0.3.27
v0.3.26
v0.3.25
v0.3.24
v0.3.23
v0.3.22
v0.3.21
v0.3.20
v0.3.19
v0.3.18
v0.3.17
v0.3.16
v0.3.15
v0.3.14
v0.3.13
v0.3.12
v0.3.11
v0.3.10
v0.3.9
v0.3.8
v0.3.7
v0.3.6
v0.3.5
v0.3.4
v0.3.3
v0.3.2
v0.3.1
v0.3.0
v0.2.7
v0.2.6
v0.2.5
v0.2.4
v0.2.3
v0.2.2
v0.2.1
v0.2.0
v0.0.3
v0.0.2
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference: Cordy/Cairn#570
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
First slice of #529, backend only and invisible until 2/3 lands. Approved from
sharing-rework-529-mockup.htmlrev 1.The decision this implements
The grant authorises; the path still keys.
encrypt/group.goderives the key scope from the backend path —/spaces/<name>/uses that space's group recipient, everything else the owning user — so an addressee on a share record cannot make a recipient able to decrypt. It makes them entitled. The read then goes through the owner's key scope, which is the mechanism the public-link handler already uses to serve unauthenticated callers.Rejected alternatives, recorded so they are not revisited by accident: re-encrypting on every share (rewrites content on every membership change, collides with legal holds #138, versioning #541 and quota) and leaving sharing as space membership only (the divergence from OpenCloud that #529 exists to close).
Scope
share.Sharegains an addressee — a kind (user|group) and a name, alongside the existing path-addressed link fields. A record carries either an addressee or link policy, never both; the shape should make the invalid state unrepresentable rather than validated after the fact.read|write, reusingspacestore's vocabulary.AllowUploadstays as it is for folder file-drop.User.Groups, which since #550 already merges app-owned and directory groups — so app groups become share targets with no extra plumbing.Store.Listgains a way to query by addressee and by path, which is what #550's Used-by count and 2/3's panel both need.Out of scope here
The panel (2/3), federated relocation (3/3), owner-deletion semantics (#569), re-sharing by recipients (decided: no).
Verifiable done
go test ./...green with tests covering: a user grant admits and a non-grantee is refused; a group grant admits via app-owned and directory group membership; a revoked grant refuses immediately with no re-encryption anywhere; an unresolvable addressee grants nothing; audit records the person for a group share; and the read path serves an entitled recipient a file encrypted to the owner's scope. House TDD — red witnessed on the runner before implementation.Correction: the public-link precedent is not what this issue says
The body above claims the read path uses "the owner's key scope, which is the mechanism the public-link handler already uses to serve unauthenticated callers." That is wrong, and the same wrong sentence is in #529's mockup and in the chat that produced it. Recording it here rather than quietly editing.
What the public handler actually does:
It reads via the deployment recovery identity, not the owner's, as a documented feature-detected fallback, separately audited as a recovery-path read. It also takes a raw
storage.Driverwith absolute backend paths, because it mounts outside the auth middleware.The approved decision is unaffected — grant authorises, path keys, the server opens the owner's file for the entitled recipient. Only my description of the existing plumbing was inaccurate. But the difference matters, because the scope driver's
resolve()maps/hometo/home/<requesting user>with no admin exemption (#177), so there is no existing way for Bob to address Alice's home. A new seam is needed either way.Mechanism decided (Nikola, 2026-09-17)
Owner-scope open, plus a space shortcut.
RecoveryOpenis left alone. Reusing it would have been cheaper, but every shared read would then log as a recovery-path read — blurring a signal that currently means something specific, and it isnilon unencrypted and remote-crypto deployments, where internal sharing would have silently failed.The "Verifiable done" list above stands, with one addition: a test asserting that a share read does not invoke the recovery path, so the two mechanisms cannot quietly merge later.
Slice 1 landed — #573 merged.
Sharenow carriesAddresseeKind/Addressee/Role/ID;Entitles,Key,ListForPath,ListForAddresseeandRoleForPathare implemented and tested. Backend only — nothing is reachable or visible yet.Three decisions recorded here because they constrain the next slice:
1.
Storewas not widened; the grant queries live onGrantQuerier.My first green attempt added
ListForPath/ListForAddresseeto theStoreinterface. That brokerecStoreinpublic_recovery_test.go— a link-only double that exists to prove the #175 recovery fallback and will never answer a grant query. WideningStorewould force every link-only implementation to grow two methods it cannot meaningfully answer.GrantQuerieris a separate two-method interface;*FileStoresatisfies both,PublicHandlerkeeps takingStore. Any future SQLite backend implementsGrantQuerieronly if it wants to serve grants.2. Path match is exact, never prefix.
A grant on
/home/alice/reportsdoes not reach/home/alice/reports-private. Folder sharing is its own feature with its own semantics, and prefix inheritance is a data leak that reads like a typo. Fenced byTestRoleForPathIsExact.3. The audit verbs are deferred, deliberately.
The scope sentence for this slice named "the audit verb". It is not in #573, and that is a decision rather than an omission:
share-grantandshare-grant-revokehave no emit site until the grant create/revoke API exists, and the entitled-read verb has none until the read path is wired.internal/audit/verbs.gois append-only by design (#433) — a verb registered ahead of its feature is a permanent name chosen before the feature that names it.verbs_test.goonly fails on emitted-but-unregistered, so nothing forces the order. They land with the code that emits them, in the next slice.One implementation note worth keeping: grants have no token, so
FileStorere-keys throughKey()(g:<id>for a grant, the token for a link). Every write-side access was re-keyed —Create, theCreaterollback, and the load path inOpenFileStore.GetandDeletestill key by token, which is correct: they are link lookups. Missing the load path alone would have collapsed every grant onto""on reload — silently, and only in the persisted file.Next:
/sharedtree + owner-scope open, per the approved split.Slice 2 landed — #574 merged.
/sharedexists, resolves, and reads through the owner's key scope.Four decisions taken this round, three of them Nikola's:
1. Layout is
/shared/<owner>/<name>, not flat. Two people can each share areport.pdf; a flat tree has to mangle one of the names, and "who gave me this" stops being visible without opening a details pane.2. Directory grants are in, and carry their subtree. Matched segment by segment, never by string prefix — so
reportsstill does not reachreports-private. That distinction is the whole reason slice 1'sRoleForPathis exact, andTestSharedSiblingPrefixIsNotReachableis the fence for it here.3. Write-role grants are writable now. The write re-encrypts into the owner's scope, because that is the only scope the file can live in. The consequence is that
ownermetawill attribute the change to the owner rather than the editor — accepted knowingly rather than discovered later. If that turns out to matter in the beta it is a separate fix, inownermeta, not here.4. The audit hook sits in the scope driver, above the identity swap. This is the one that would have gone wrong silently. Everything below the scope decorator sees the owner, so an audit record made down there reads "alice read her own file" — and an entitled access becomes indistinguishable from ordinary activity, which is the exact case the record exists for. The hook takes the real reader and the owner separately, and
TestSharedAuditNamesTheReaderNotTheOwnerasserts both halves at once: the hook saw Bob, the inner driver saw Alice. Neither can drift without the test failing.share-grant-readandshare-grant-writeare now registered ininternal/audit/verbs.go, which closes the deferral I recorded when slice 1 landed.Deliberately not wired.
WithGrantsis not called incmd/cairnd/main.go. Nothing can create a grant yet, so wiring it would ship a root that can only ever be empty. The adapter from the share store toscope.Grantslands with #571, alongside the panel and the create/revoke API.#570 remaining: the grant create/revoke API (with its own two audit verbs), then the adapter + wiring. Both belong with #571 rather than here, since the panel is what calls them.
Closing — all three parts of the scope are in and live.
Sharegains addressee/role/id,FileStorekeys grants separately from linksEntitles,RoleForPath, exact-path matching/sharedoverlay, owner-scope open, reader-attributed auditshare-grant-read/-write), #575 (share-grant/-revoke)The three decisions from this issue that the rest of the feature now rests on:
Storewas not widened. The grant queries live onGrantQuerier, so a link-only implementation is not forced to grow methods it cannot answer.reportsdoes not reachreports-private. Directory grants descend segment by segment, which preserves that.Remaining sharing work is tracked on #571 (panel + admin toggle) and #572 (federated send relocation).