Groups "Used by" ignores share grants — a group that grants access reads "Not used" #687

Closed
opened 2026-09-23 10:17:39 +00:00 by Cordy · 1 comment
Owner

Found by the #656 QA pass, §2 admin scouting (v0.6.247, files-bao).

Where: Administration → Users & access → Groups.

Steps: app group qa656 (member sharer1) holds an active grant: _qa/drop is shared with qa656, Can view, and sharer1 sees "drop · Can view via qa656" under Shared with me. Its row in App-owned groups says Used by: Not used.

Expected: "Used by" counts share grants alongside peering lists, spaces and the admin group ("1 share · …"). This matters most at the moment an admin decides whether Delete is safe.
Seen: "Not used", even though deleting the group would silently revoke (or orphan) the access it grants.

Screenshot: 656-admin-users-groups-bao.jpg

Found by the #656 QA pass, §2 admin scouting (v0.6.247, files-bao). **Where:** Administration → Users & access → Groups. **Steps:** app group `qa656` (member sharer1) holds an active grant: `_qa/drop` is shared with `qa656`, Can view, and sharer1 sees "drop · Can view via qa656" under Shared with me. Its row in App-owned groups says **Used by: Not used**. **Expected:** "Used by" counts share grants alongside peering lists, spaces and the admin group ("1 share · …"). This matters most at the moment an admin decides whether **Delete** is safe. **Seen:** "Not used", even though deleting the group would silently revoke (or orphan) the access it grants. **Screenshot:** `656-admin-users-groups-bao.jpg`
Author
Owner

This got worse during #656 cleanup: Delete group fails silently.

  • Groups → qa656 → Delete opens #gdeldlg, which says "Nothing references this group. References simply stop matching…".
  • Clicking Delete group (real click) sends DELETE /api/v1/admin/groups/294b6a01804c73f6409 this group is the addressee of 1 share grant(s); revoke those shares first (the Used by column lists them).
  • The dialog stays open with no error shown. The group is not deleted.

Three layers disagree:

  1. The server blocks the delete (correctly), and its message points to a "Used by" column that says "Not used".
  2. The dialog promises "nothing references this group".
  3. The UI swallows the 409.

The fix is the same as above (count grants in Used by and in the dialog's fact rows), plus surfacing a 409 in the dialog. Screenshot: 696-group-delete-silent-409.jpg.

This got worse during #656 cleanup: **Delete group fails silently.** - Groups → qa656 → Delete opens `#gdeldlg`, which says "**Nothing references this group.** References simply stop matching…". - Clicking **Delete group** (real click) sends `DELETE /api/v1/admin/groups/294b6a01804c73f6` → **409** `this group is the addressee of 1 share grant(s); revoke those shares first (the Used by column lists them)`. - The dialog stays open with no error shown. The group is not deleted. Three layers disagree: 1. The server blocks the delete (correctly), and its message points to a "Used by" column that says "Not used". 2. The dialog promises "nothing references this group". 3. The UI swallows the 409. The fix is the same as above (count grants in Used by and in the dialog's fact rows), plus surfacing a 409 in the dialog. Screenshot: `696-group-delete-silent-409.jpg`.
Cordy closed this issue 2026-09-23 18:44:34 +00:00
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#687
No description provided.