Spaces overview chrome joins the design system: standard toolbar placement (view selector + gear top-right), New space in the actions row, established footer bar #789

Closed
opened 2026-09-28 01:34:10 +00:00 by Cordy · 1 comment
Owner

Nikola: "there is no design system being applied… the footer is the wrong color… list and view settings are misplaced, we [want] the same spot at every view, should not be placed in top level spaces section."

Explicit instructions:

  1. Toolbar row: the overview uses the SAME #fileactions row layout as every other view — left: a New space button (primary, replacing Upload/New's position; add a dedicated hidden #spovnew button to the #fileactions markup, shown only in spacesov via the existing per-fbview CSS pattern, wired to createSpaceFlow); right: the view-mode dropdown AND the gear in their standard positions (today the view dropdown shows but sits with the shipped bar left-aligned in the panel head — the left-aligned floating "Tiles ∨" above the panel must go). Gear in spacesov shows only its applicable row (tile size, only in Tiles mode — the vs-tilerow logic already exists; hide the other rows per-fbview).
  2. Panel head: inside the panel keep only: search input (left, per rev3 mockup) + "?" help button. New space button leaves the panel (moves to the toolbar row). Remove .spovhead's primary styling remnants.
  3. Footer: replace the plain-text .spovfoot with the established list footer: same element style as the files #listfoot bar (scout its classes/markup — full-width, sunk background, muted text, content at both ends) — tally text left ("6 spaces — 2 active, 0 deactivated, 4 directory-managed"), measured total right ("3.3 MB measured"). Reuse the exact classes if they are reusable; otherwise mirror their CSS values verbatim with a .spovfoot that visually matches pixel-for-pixel.\n4. General sweep against the design system while in there: search input should match the established input styling (compare against the members dialog input / files search field paddings and radii); spacing between toolbar, panel and footer should mirror the files view rhythm (16px top margin under the toolbar, as .selbar/table do).\n5. Pins: qa783 pins on the removed placements must be updated in the same push; qa769/770/778/779 pins (table, chips, wrapper, search, filter, tally-parts) must survive — the tally STRING composition may move element but keeps tf("spovTallyParts"… and tf("spovMeasured"….

Acceptance: overview screenshot side-by-side with the Personal files view shows: identical toolbar row position/heights (New space where Upload sits, view dropdown + gear top-right), search + ? inside the panel, and a footer bar with the same background/padding as the files footer; nothing floats above the panel on the left.

Nikola: "there is no design system being applied… the footer is the wrong color… list and view settings are misplaced, we [want] the same spot at every view, should not be placed in top level spaces section." **Explicit instructions:** 1. **Toolbar row:** the overview uses the SAME `#fileactions` row layout as every other view — left: a `New space` button (primary, replacing Upload/New's position; add a dedicated hidden `#spovnew` button to the `#fileactions` markup, shown only in `spacesov` via the existing per-fbview CSS pattern, wired to `createSpaceFlow`); right: the view-mode dropdown AND the gear in their standard positions (today the view dropdown shows but sits with the shipped bar left-aligned in the panel head — the left-aligned floating "Tiles ∨" above the panel must go). Gear in spacesov shows only its applicable row (tile size, only in Tiles mode — the `vs-tilerow` logic already exists; hide the other rows per-fbview). 2. **Panel head:** inside the panel keep only: search input (left, per rev3 mockup) + "?" help button. New space button leaves the panel (moves to the toolbar row). Remove `.spovhead`'s `primary` styling remnants. 3. **Footer:** replace the plain-text `.spovfoot` with the established list footer: same element style as the files `#listfoot` bar (scout its classes/markup — full-width, sunk background, muted text, content at both ends) — tally text left ("6 spaces — 2 active, 0 deactivated, 4 directory-managed"), measured total right ("3.3 MB measured"). Reuse the exact classes if they are reusable; otherwise mirror their CSS values verbatim with a `.spovfoot` that visually matches pixel-for-pixel.\n4. **General sweep against the design system while in there:** search input should match the established input styling (compare against the members dialog input / files search field paddings and radii); spacing between toolbar, panel and footer should mirror the files view rhythm (16px top margin under the toolbar, as `.selbar`/table do).\n5. Pins: qa783 pins on the removed placements must be updated in the same push; qa769/770/778/779 pins (table, chips, wrapper, search, filter, tally-parts) must survive — the tally STRING composition may move element but keeps `tf("spovTallyParts"…` and `tf("spovMeasured"…`. **Acceptance:** overview screenshot side-by-side with the Personal files view shows: identical toolbar row position/heights (New space where Upload sits, view dropdown + gear top-right), search + ? inside the panel, and a footer bar with the same background/padding as the files footer; nothing floats above the panel on the left.
Cordy closed this issue 2026-09-28 02:27:21 +00:00
Author
Owner

Shipped in v0.6.296 (PR #792), live on both dogfoods. Verified on Bao after deploy in all three modes:

  • List: New space in the toolbar row where Upload sits; List selector top-right; panel with .lh-style header band; footer is the standard sunk bar, joined under the table — tally left, "3.3 MB measured" right. Side-by-side with Personal: same anatomy.
  • Condensed: same chrome, tight rows, footer joined.
  • Tiles: gear appears beside the selector (only the Tile size row; the slider resizes space cards); cards on the page background; footer as the standalone rounded bar like files Tiles.

Caught in the pre-ship preview and fixed before pushing: hairline seams in the header band (per-cell backgrounds at fractional widths → band now painted once on the row) and a stray divider above the lone gear row.

Noted, not changed: the toolbar row sits ~3px higher than in Personal because the line above it is a view title rather than a breadcrumb — Recents/Shares/Trash share the same offset, so it's system-wide, not an overview issue. The sort <select> in the panel head is intentionally still there; #786 removes it.

Your prefs were restored to List after the checks. Ready for review.

**Shipped in v0.6.296 (PR #792), live on both dogfoods. Verified on Bao after deploy in all three modes:** - **List:** New space in the toolbar row where Upload sits; List selector top-right; panel with `.lh`-style header band; footer is the standard sunk bar, joined under the table — tally left, "3.3 MB measured" right. Side-by-side with Personal: same anatomy. - **Condensed:** same chrome, tight rows, footer joined. - **Tiles:** gear appears beside the selector (only the Tile size row; the slider resizes space cards); cards on the page background; footer as the standalone rounded bar like files Tiles. Caught in the pre-ship preview and fixed before pushing: hairline seams in the header band (per-cell backgrounds at fractional widths → band now painted once on the row) and a stray divider above the lone gear row. Noted, not changed: the toolbar row sits ~3px higher than in Personal because the line above it is a view title rather than a breadcrumb — Recents/Shares/Trash share the same offset, so it's system-wide, not an overview issue. The sort `<select>` in the panel head is intentionally still there; #786 removes it. Your prefs were restored to List after the checks. Ready for review.
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#789
No description provided.