Spaces overview: gear always visible with Items per page (paged overview); Tile size row in Tiles only #795

Closed
opened 2026-09-28 02:38:56 +00:00 by Cordy · 1 comment
Owner

Nikola, reviewing #789: "the gear icon should stay, as it can also adjust Items per page, and some instances might have many spaces."

#789 shows the gear only in Tiles, with only the Tile size row. Revise:

Explicit instructions:

  1. Gear visible in the overview in every mode (List / Condensed / Tiles). Remove body[data-fbview="spacesov"]:not([data-view="grid"]) .fbgear{display:none}.
  2. Rows in the overview's gear: Items per page always; Tile size only in Tiles — exactly the files-view rule (the existing vs-tilerow hidden-unless-grid logic already does this; stop hiding it via the spacesov CSS). Show hidden files / Show file extensions stay hidden in the overview (not applicable to spaces). Fix the lone-row divider rule from #789 so dividers are right for the new visible set (first visible row has no top border).
  3. Paging: the overview honours the same fbPerPage() setting as the files views (one shared preference — no second per-page value). After filter + sort, show page N of the rows/cards; the pager renders in the overview footer's right side next to the measured size, using the SAME pager markup/classes as the files footer (#fbpager-style .pgn buttons, ‹ › and ellipsis — reuse the rendering, don't hand-roll a second pager). The tally keeps counting ALL spaces, not just the page.
  4. Interactions: search filters across all spaces and resets to page 1; sort (#786 headers) re-sorts all spaces then pages; selection (#787) must not silently keep rows that are on another page — clear or keep consistently with how the files views handle selection across pages (check and mirror).
  5. Changing Items per page in the gear re-renders the overview (as it re-renders files views).

Acceptance: gear visible in all three modes; List/Condensed show Items per page only; Tiles shows Items per page + Tile size; with per-page 20 and >20 spaces the overview shows 20 plus a pager identical to the files pager; search/sort reset to page 1; tally counts all spaces.

Depends on #786 (header sorting) — do after it.

Nikola, reviewing #789: "the gear icon should stay, as it can also adjust Items per page, and some instances might have many spaces." #789 shows the gear only in Tiles, with only the Tile size row. Revise: **Explicit instructions:** 1. Gear visible in the overview in every mode (List / Condensed / Tiles). Remove `body[data-fbview="spacesov"]:not([data-view="grid"]) .fbgear{display:none}`. 2. Rows in the overview's gear: **Items per page** always; **Tile size** only in Tiles — exactly the files-view rule (the existing `vs-tilerow` hidden-unless-grid logic already does this; stop hiding it via the spacesov CSS). Show hidden files / Show file extensions stay hidden in the overview (not applicable to spaces). Fix the lone-row divider rule from #789 so dividers are right for the new visible set (first visible row has no top border). 3. **Paging:** the overview honours the same `fbPerPage()` setting as the files views (one shared preference — no second per-page value). After filter + sort, show page N of the rows/cards; the pager renders in the overview footer's right side next to the measured size, using the SAME pager markup/classes as the files footer (`#fbpager`-style `.pgn` buttons, ‹ › and ellipsis — reuse the rendering, don't hand-roll a second pager). The tally keeps counting ALL spaces, not just the page. 4. Interactions: search filters across all spaces and resets to page 1; sort (#786 headers) re-sorts all spaces then pages; selection (#787) must not silently keep rows that are on another page — clear or keep consistently with how the files views handle selection across pages (check and mirror). 5. Changing Items per page in the gear re-renders the overview (as it re-renders files views). **Acceptance:** gear visible in all three modes; List/Condensed show Items per page only; Tiles shows Items per page + Tile size; with per-page 20 and >20 spaces the overview shows 20 plus a pager identical to the files pager; search/sort reset to page 1; tally counts all spaces. Depends on #786 (header sorting) — do after it.
Cordy closed this issue 2026-09-28 03:34:41 +00:00
Author
Owner

Shipped in v0.6.299 (PR #798), live on both dogfoods.

Verified on Bao:

  • Gear visible in List, Condensed and Tiles. Popover shows Items per page only (no divider over it); Tiles adds Tile size underneath with its divider. Show hidden / extensions stay hidden.
  • Paging (per-page temporarily forced to 2 in-page, since only 6 spaces exist; not persisted): footer pager ‹ 1 2 3 › beside "3.3 MB measured", same style as the files pager. Page 2/3 slices correct; a pick on page 1 is dropped when paging away (selection bar turns off); Name header sort → back to page 1 with the reversed order; search "c" → page 1 of 2 over matching rows; Tiles pages the cards the same way.
  • After a real reload: 6 rows, no pager at the default 100 per page, view prefs unchanged by the check.
Shipped in **v0.6.299** (PR #798), live on both dogfoods. Verified on Bao: - Gear visible in List, Condensed and Tiles. Popover shows Items per page only (no divider over it); Tiles adds Tile size underneath with its divider. Show hidden / extensions stay hidden. - Paging (per-page temporarily forced to 2 in-page, since only 6 spaces exist; not persisted): footer pager `‹ 1 2 3 ›` beside "3.3 MB measured", same style as the files pager. Page 2/3 slices correct; a pick on page 1 is dropped when paging away (selection bar turns off); Name header sort → back to page 1 with the reversed order; search "c" → page 1 of 2 over matching rows; Tiles pages the cards the same way. - After a real reload: 6 rows, no pager at the default 100 per page, view prefs unchanged by the check.
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#795
No description provided.