govulncheck: reachable vulnerabilities on main #875

Closed
opened 2026-10-12 05:30:55 +00:00 by forgejo-actions · 1 comment

The weekly vulncheck workflow found vulnerabilities reachable from our code.

== toolchain pinned by go.mod ==
afa2d1ec
go 1.26.8
== patch drift (informational) ==
NOTICE: a newer Go patch exists — go get go@patch would change:
--- /tmp/go.mod.before
+++ go.mod
@@ -1,6 +1,6 @@
 module github.com/nikolasomborski/cairn
 
-go 1.26.8
+go 1.26.9
 
 require (
 	codeberg.org/go-pdf/fpdf v0.12.0
== govulncheck (source mode, reachability) ==
      #149: internal/storage/quota/quota.go:391:20: quota.limitedReader.Read calls bufio.Reader.Read, which calls http.loggingConn.Read
      #150: internal/storage/quota/quota.go:391:20: quota.limitedReader.Read calls bufio.Reader.Read, which calls http.loggingConn.Read
      #151: internal/auth/throttle.go:865:20: auth.WriteThrottled calls fmt.Fprintf, which calls http.loggingConn.Write
      #152: internal/auth/throttle.go:865:20: auth.WriteThrottled calls fmt.Fprintf, which calls http.loggingConn.Write
      #153: internal/spaces/spaces.go:468:2: spaces.Manager.UserStatusByID calls http.maxBytesReader.Close
      #154: internal/spaces/spaces.go:468:2: spaces.Manager.UserStatusByID calls http.maxBytesReader.Close
      #155: internal/storage/quota/quota.go:391:20: quota.limitedReader.Read calls http.maxBytesReader.Read
      #156: internal/storage/quota/quota.go:391:20: quota.limitedReader.Read calls http.maxBytesReader.Read
      #157: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http.onceCloseListener.Close
      #158: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http.onceCloseListener.Close
      #159: internal/storage/quota/quota.go:391:20: quota.limitedReader.Read calls bufio.Reader.Read, which calls http.persistConn.Read
      #160: internal/storage/quota/quota.go:391:20: quota.limitedReader.Read calls bufio.Reader.Read, which calls http.persistConn.Read
      #161: internal/storage/s3/s3.go:344:19: s3.Driver.Write calls io.Copy, which eventually calls http.persistConnWriter.ReadFrom
      #162: internal/storage/s3/s3.go:344:19: s3.Driver.Write calls io.Copy, which eventually calls http.persistConnWriter.ReadFrom
      #163: internal/sharereport/sharereport.go:58:9: sharereport.CSV calls csv.Writer.Flush, which eventually calls http.persistConnWriter.Write
      #164: internal/sharereport/sharereport.go:58:9: sharereport.CSV calls csv.Writer.Flush, which eventually calls http.persistConnWriter.Write
      #165: internal/spaces/spaces.go:468:2: spaces.Manager.UserStatusByID calls http.readTrackingBody.Close
      #166: internal/spaces/spaces.go:468:2: spaces.Manager.UserStatusByID calls http.readTrackingBody.Close
      #167: internal/storage/quota/quota.go:391:20: quota.limitedReader.Read calls http.readTrackingBody.Read
      #168: internal/storage/quota/quota.go:391:20: quota.limitedReader.Read calls http.readTrackingBody.Read
      #169: internal/storage/s3/s3.go:261:23: s3.object.Read calls http.readWriteCloserBody.Read
      #170: internal/storage/s3/s3.go:261:23: s3.object.Read calls http.readWriteCloserBody.Read
      #171: internal/obs/middleware.go:38:10: obs.statusWriter.Flush calls http.response.Flush
      #172: internal/obs/middleware.go:38:10: obs.statusWriter.Flush calls http.response.Flush
      #173: internal/storage/s3/s3.go:344:19: s3.Driver.Write calls io.Copy, which eventually calls http.response.ReadFrom
      #174: internal/storage/s3/s3.go:344:19: s3.Driver.Write calls io.Copy, which eventually calls http.response.ReadFrom
      #175: internal/obs/middleware.go:30:34: obs.statusWriter.Write calls http.response.Write
      #176: internal/obs/middleware.go:30:34: obs.statusWriter.Write calls http.response.Write
      #177: internal/auth/throttle.go:864:15: auth.WriteThrottled calls http.response.WriteHeader
      #178: internal/auth/throttle.go:864:15: auth.WriteThrottled calls http.response.WriteHeader
      #179: internal/sharereport/sharereport.go:44:13: sharereport.CSV calls csv.Writer.Write, which eventually calls http.response.WriteString
      #180: internal/sharereport/sharereport.go:44:13: sharereport.CSV calls csv.Writer.Write, which eventually calls http.response.WriteString
      #181: internal/peering/service.go:208:42: peering.Service.PrepareTransfer calls http.transportReadFromServerError.Error
      #182: internal/peering/service.go:208:42: peering.Service.PrepareTransfer calls http.transportReadFromServerError.Error

Vulnerability #12: GO-2026-6600
    Recognize yield as regexp preceder keyword in html/template
  More info: https://pkg.go.dev/vuln/GO-2026-6600
  Standard library
    Found in: html/template@go1.26.8
    Fixed in: html/template@go1.26.9
    Example traces found:
      #1: internal/share/public.go:480:18: share.PublicHandler.renderPasswordForm calls template.Template.Execute
      #2: internal/httpx/httpx.go:244:87: httpx.Registry.ServeHTTP calls http.ServeMux.ServeHTTP, which eventually calls template.Template.ExecuteTemplate

Vulnerability #13: GO-2026-6599
    Reset context tracking on consecutive template expressions in html/template
  More info: https://pkg.go.dev/vuln/GO-2026-6599
  Standard library
    Found in: html/template@go1.26.8
    Fixed in: html/template@go1.26.9
    Example traces found:
      #1: internal/share/public.go:480:18: share.PublicHandler.renderPasswordForm calls template.Template.Execute
      #2: internal/httpx/httpx.go:244:87: httpx.Registry.ServeHTTP calls http.ServeMux.ServeHTTP, which eventually calls template.Template.ExecuteTemplate

Your code is affected by 13 vulnerabilities from the Go standard library.
This scan also found 1 vulnerability in packages you import and 4
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.
Use '-show verbose' for more details.

Fix recipe (#447): go get go@patch on a branch (or bump the affected dependency), full suite green, release, bump dogfoods.


Filed automatically by the scheduled vulncheck workflow.

The weekly vulncheck workflow found vulnerabilities reachable from our code. ``` == toolchain pinned by go.mod == afa2d1ec go 1.26.8 == patch drift (informational) == NOTICE: a newer Go patch exists — go get go@patch would change: --- /tmp/go.mod.before +++ go.mod @@ -1,6 +1,6 @@ module github.com/nikolasomborski/cairn -go 1.26.8 +go 1.26.9 require ( codeberg.org/go-pdf/fpdf v0.12.0 == govulncheck (source mode, reachability) == #149: internal/storage/quota/quota.go:391:20: quota.limitedReader.Read calls bufio.Reader.Read, which calls http.loggingConn.Read #150: internal/storage/quota/quota.go:391:20: quota.limitedReader.Read calls bufio.Reader.Read, which calls http.loggingConn.Read #151: internal/auth/throttle.go:865:20: auth.WriteThrottled calls fmt.Fprintf, which calls http.loggingConn.Write #152: internal/auth/throttle.go:865:20: auth.WriteThrottled calls fmt.Fprintf, which calls http.loggingConn.Write #153: internal/spaces/spaces.go:468:2: spaces.Manager.UserStatusByID calls http.maxBytesReader.Close #154: internal/spaces/spaces.go:468:2: spaces.Manager.UserStatusByID calls http.maxBytesReader.Close #155: internal/storage/quota/quota.go:391:20: quota.limitedReader.Read calls http.maxBytesReader.Read #156: internal/storage/quota/quota.go:391:20: quota.limitedReader.Read calls http.maxBytesReader.Read #157: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http.onceCloseListener.Close #158: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http.onceCloseListener.Close #159: internal/storage/quota/quota.go:391:20: quota.limitedReader.Read calls bufio.Reader.Read, which calls http.persistConn.Read #160: internal/storage/quota/quota.go:391:20: quota.limitedReader.Read calls bufio.Reader.Read, which calls http.persistConn.Read #161: internal/storage/s3/s3.go:344:19: s3.Driver.Write calls io.Copy, which eventually calls http.persistConnWriter.ReadFrom #162: internal/storage/s3/s3.go:344:19: s3.Driver.Write calls io.Copy, which eventually calls http.persistConnWriter.ReadFrom #163: internal/sharereport/sharereport.go:58:9: sharereport.CSV calls csv.Writer.Flush, which eventually calls http.persistConnWriter.Write #164: internal/sharereport/sharereport.go:58:9: sharereport.CSV calls csv.Writer.Flush, which eventually calls http.persistConnWriter.Write #165: internal/spaces/spaces.go:468:2: spaces.Manager.UserStatusByID calls http.readTrackingBody.Close #166: internal/spaces/spaces.go:468:2: spaces.Manager.UserStatusByID calls http.readTrackingBody.Close #167: internal/storage/quota/quota.go:391:20: quota.limitedReader.Read calls http.readTrackingBody.Read #168: internal/storage/quota/quota.go:391:20: quota.limitedReader.Read calls http.readTrackingBody.Read #169: internal/storage/s3/s3.go:261:23: s3.object.Read calls http.readWriteCloserBody.Read #170: internal/storage/s3/s3.go:261:23: s3.object.Read calls http.readWriteCloserBody.Read #171: internal/obs/middleware.go:38:10: obs.statusWriter.Flush calls http.response.Flush #172: internal/obs/middleware.go:38:10: obs.statusWriter.Flush calls http.response.Flush #173: internal/storage/s3/s3.go:344:19: s3.Driver.Write calls io.Copy, which eventually calls http.response.ReadFrom #174: internal/storage/s3/s3.go:344:19: s3.Driver.Write calls io.Copy, which eventually calls http.response.ReadFrom #175: internal/obs/middleware.go:30:34: obs.statusWriter.Write calls http.response.Write #176: internal/obs/middleware.go:30:34: obs.statusWriter.Write calls http.response.Write #177: internal/auth/throttle.go:864:15: auth.WriteThrottled calls http.response.WriteHeader #178: internal/auth/throttle.go:864:15: auth.WriteThrottled calls http.response.WriteHeader #179: internal/sharereport/sharereport.go:44:13: sharereport.CSV calls csv.Writer.Write, which eventually calls http.response.WriteString #180: internal/sharereport/sharereport.go:44:13: sharereport.CSV calls csv.Writer.Write, which eventually calls http.response.WriteString #181: internal/peering/service.go:208:42: peering.Service.PrepareTransfer calls http.transportReadFromServerError.Error #182: internal/peering/service.go:208:42: peering.Service.PrepareTransfer calls http.transportReadFromServerError.Error Vulnerability #12: GO-2026-6600 Recognize yield as regexp preceder keyword in html/template More info: https://pkg.go.dev/vuln/GO-2026-6600 Standard library Found in: html/template@go1.26.8 Fixed in: html/template@go1.26.9 Example traces found: #1: internal/share/public.go:480:18: share.PublicHandler.renderPasswordForm calls template.Template.Execute #2: internal/httpx/httpx.go:244:87: httpx.Registry.ServeHTTP calls http.ServeMux.ServeHTTP, which eventually calls template.Template.ExecuteTemplate Vulnerability #13: GO-2026-6599 Reset context tracking on consecutive template expressions in html/template More info: https://pkg.go.dev/vuln/GO-2026-6599 Standard library Found in: html/template@go1.26.8 Fixed in: html/template@go1.26.9 Example traces found: #1: internal/share/public.go:480:18: share.PublicHandler.renderPasswordForm calls template.Template.Execute #2: internal/httpx/httpx.go:244:87: httpx.Registry.ServeHTTP calls http.ServeMux.ServeHTTP, which eventually calls template.Template.ExecuteTemplate Your code is affected by 13 vulnerabilities from the Go standard library. This scan also found 1 vulnerability in packages you import and 4 vulnerabilities in modules you require, but your code doesn't appear to call these vulnerabilities. Use '-show verbose' for more details. ``` Fix recipe (#447): `go get go@patch` on a branch (or bump the affected dependency), full suite green, release, bump dogfoods. --- Filed automatically by the scheduled vulncheck workflow.
Cordy closed this issue 2026-10-12 19:19:04 +00:00
Owner

Fixed in v0.6.333 (PR #883). The build now uses Go 1.26.9, and both dogfoods are bumped.

I dispatched vulncheck on main after the merge:

  • The go directive is at 1.26.9, the latest patch of its line.
  • 0 standard-library vulnerabilities are reachable now. All 13 are gone.
  • What remains is 4 reachable vulnerabilities in golang.org/x/net v0.57.0 (fixed in v0.60.0, e.g. GO-2026-6603, HTTP/2 server memory exhaustion via Trailer headers). The full output in this issue had been truncated, so it didn't show them. The workflow filed them as #884, and the fix is in progress on fix-884.

Closing this one; #884 tracks the rest.

Fixed in v0.6.333 (PR #883). The build now uses Go 1.26.9, and both dogfoods are bumped. I dispatched `vulncheck` on main after the merge: - The go directive is at 1.26.9, the latest patch of its line. - **0 standard-library vulnerabilities are reachable now.** All 13 are gone. - What remains is 4 reachable vulnerabilities in `golang.org/x/net` v0.57.0 (fixed in v0.60.0, e.g. GO-2026-6603, HTTP/2 server memory exhaustion via Trailer headers). The full output in this issue had been truncated, so it didn't show them. The workflow filed them as **#884**, and the fix is in progress on `fix-884`. Closing this one; #884 tracks the rest.
Sign in to join this conversation.
No labels
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#875
No description provided.