govulncheck: reachable vulnerabilities on main #884

Closed
opened 2026-10-12 19:25:09 +00:00 by forgejo-actions · 1 comment

The weekly vulncheck workflow found vulnerabilities reachable from our code.

ervice.ListReceiverSpaces calls fmt.Sprintf, which eventually calls http2.writeData.String

Vulnerability #4: GO-2026-6603
    HTTP/2 server memory exhaustion due to Trailer headers in net/http
  More info: https://pkg.go.dev/vuln/GO-2026-6603
  Module: golang.org/x/net
    Found in: golang.org/x/net@v0.57.0
    Fixed in: golang.org/x/net@v0.60.0
    Example traces found:
      #1: internal/peering/service.go:209:47: peering.Service.PrepareTransfer calls http2.ConnectionError.Error
      #2: internal/peering/service.go:360:51: peering.Service.ListReceiverSpaces calls fmt.Sprintf, which eventually calls http2.ErrCode.String
      #3: internal/peering/service.go:360:51: peering.Service.ListReceiverSpaces calls fmt.Sprintf, which eventually calls http2.FrameHeader.String
      #4: internal/peering/service.go:360:51: peering.Service.ListReceiverSpaces calls fmt.Sprintf, which eventually calls http2.FrameType.String
      #5: internal/peering/service.go:360:51: peering.Service.ListReceiverSpaces calls fmt.Sprintf, which eventually calls http2.FrameWriteRequest.String
      #6: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.ReadFrame
      #7: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.ReadFrameForHeader
      #8: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.ReadFrameHeader
      #9: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.WriteContinuation
      #10: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.WriteGoAway
      #11: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.WriteHeaders
      #12: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.WritePing
      #13: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.WriteRSTStream
      #14: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.WriteSettings
      #15: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.WriteSettingsAck
      #16: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.WriteWindowUpdate
      #17: internal/peering/service.go:209:47: peering.Service.PrepareTransfer calls http2.GoAwayError.Error
      #18: cmd/cairnd/h2csafe.go:43:15: cairnd.h2cSafe calls h2c.h2cHandler.ServeHTTP, which calls http2.Server.ServeConn
      #19: internal/peering/service.go:360:51: peering.Service.ListReceiverSpaces calls fmt.Sprintf, which eventually calls http2.Setting.String
      #20: internal/peering/service.go:360:51: peering.Service.ListReceiverSpaces calls fmt.Sprintf, which eventually calls http2.SettingID.String
      #21: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.SettingsFrame.ForeachSetting
      #22: internal/peering/service.go:209:47: peering.Service.PrepareTransfer calls http2.StreamError.Error
      #23: internal/sharereport/sharereport.go:58:9: sharereport.CSV calls csv.Writer.Flush, which eventually calls http2.bufferedWriterTimeoutWriter.Write
      #24: internal/sharereport/sharereport.go:58:9: sharereport.CSV calls csv.Writer.Flush, which eventually calls http2.chunkWriter.Write
      #25: internal/peering/service.go:209:47: peering.Service.PrepareTransfer calls http2.connError.Error
      #26: internal/peering/service.go:209:47: peering.Service.PrepareTransfer calls http2.duplicatePseudoHeaderError.Error
      #27: internal/spaces/spaces.go:468:2: spaces.Manager.UserStatusByID calls http2.gzipReader.Close
      #28: internal/storage/s3/s3.go:261:23: s3.object.Read calls http2.gzipReader.Read
      #29: internal/peering/service.go:209:47: peering.Service.PrepareTransfer calls http2.headerFieldNameError.Error
      #30: internal/peering/service.go:209:47: peering.Service.PrepareTransfer calls http2.headerFieldValueError.Error
      #31: internal/peering/service.go:209:47: peering.Service.PrepareTransfer calls http2.pseudoHeaderError.Error
      #32: internal/spaces/spaces.go:468:2: spaces.Manager.UserStatusByID calls http2.requestBody.Close
      #33: internal/storage/quota/quota.go:391:20: quota.limitedReader.Read calls http2.requestBody.Read
      #34: internal/obs/middleware.go:40:10: obs.statusWriter.Flush calls http2.responseWriter.Flush
      #35: internal/httpx/deadline.go:64:28: httpx.deadlineBody.Read calls http.ResponseController.SetReadDeadline, which calls http2.responseWriter.SetReadDeadline
      #36: internal/obs/middleware.go:32:34: obs.statusWriter.Write calls http2.responseWriter.Write
      #37: internal/auth/throttle.go:853:15: auth.WriteThrottled calls http2.responseWriter.WriteHeader
      #38: internal/sharereport/sharereport.go:44:13: sharereport.CSV calls csv.Writer.Write, which eventually calls http2.responseWriter.WriteString
      #39: internal/sharereport/sharereport.go:58:9: sharereport.CSV calls csv.Writer.Flush, which eventually calls http2.stickyErrWriter.Write
      #40: internal/spaces/spaces.go:468:2: spaces.Manager.UserStatusByID calls http2.transportResponseBody.Close
      #41: internal/storage/s3/s3.go:261:23: s3.object.Read calls http2.transportResponseBody.Read
      #42: internal/peering/service.go:360:51: peering.Service.ListReceiverSpaces calls fmt.Sprintf, which eventually calls http2.writeData.String

Your code is affected by 4 vulnerabilities from 1 module.
This scan also found 2 vulnerabilities in packages you import and 4
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.
Use '-show verbose' for more details.

Fix recipe (#447): go get go@patch on a branch (or bump the affected dependency), full suite green, release, bump dogfoods.


Filed automatically by the scheduled vulncheck workflow.

The weekly vulncheck workflow found vulnerabilities reachable from our code. ``` ervice.ListReceiverSpaces calls fmt.Sprintf, which eventually calls http2.writeData.String Vulnerability #4: GO-2026-6603 HTTP/2 server memory exhaustion due to Trailer headers in net/http More info: https://pkg.go.dev/vuln/GO-2026-6603 Module: golang.org/x/net Found in: golang.org/x/net@v0.57.0 Fixed in: golang.org/x/net@v0.60.0 Example traces found: #1: internal/peering/service.go:209:47: peering.Service.PrepareTransfer calls http2.ConnectionError.Error #2: internal/peering/service.go:360:51: peering.Service.ListReceiverSpaces calls fmt.Sprintf, which eventually calls http2.ErrCode.String #3: internal/peering/service.go:360:51: peering.Service.ListReceiverSpaces calls fmt.Sprintf, which eventually calls http2.FrameHeader.String #4: internal/peering/service.go:360:51: peering.Service.ListReceiverSpaces calls fmt.Sprintf, which eventually calls http2.FrameType.String #5: internal/peering/service.go:360:51: peering.Service.ListReceiverSpaces calls fmt.Sprintf, which eventually calls http2.FrameWriteRequest.String #6: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.ReadFrame #7: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.ReadFrameForHeader #8: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.ReadFrameHeader #9: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.WriteContinuation #10: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.WriteGoAway #11: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.WriteHeaders #12: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.WritePing #13: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.WriteRSTStream #14: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.WriteSettings #15: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.WriteSettingsAck #16: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.Framer.WriteWindowUpdate #17: internal/peering/service.go:209:47: peering.Service.PrepareTransfer calls http2.GoAwayError.Error #18: cmd/cairnd/h2csafe.go:43:15: cairnd.h2cSafe calls h2c.h2cHandler.ServeHTTP, which calls http2.Server.ServeConn #19: internal/peering/service.go:360:51: peering.Service.ListReceiverSpaces calls fmt.Sprintf, which eventually calls http2.Setting.String #20: internal/peering/service.go:360:51: peering.Service.ListReceiverSpaces calls fmt.Sprintf, which eventually calls http2.SettingID.String #21: internal/api/updates.go:84:13: api.UpdateCheck.Start calls sync.Once.Do, which eventually calls http2.SettingsFrame.ForeachSetting #22: internal/peering/service.go:209:47: peering.Service.PrepareTransfer calls http2.StreamError.Error #23: internal/sharereport/sharereport.go:58:9: sharereport.CSV calls csv.Writer.Flush, which eventually calls http2.bufferedWriterTimeoutWriter.Write #24: internal/sharereport/sharereport.go:58:9: sharereport.CSV calls csv.Writer.Flush, which eventually calls http2.chunkWriter.Write #25: internal/peering/service.go:209:47: peering.Service.PrepareTransfer calls http2.connError.Error #26: internal/peering/service.go:209:47: peering.Service.PrepareTransfer calls http2.duplicatePseudoHeaderError.Error #27: internal/spaces/spaces.go:468:2: spaces.Manager.UserStatusByID calls http2.gzipReader.Close #28: internal/storage/s3/s3.go:261:23: s3.object.Read calls http2.gzipReader.Read #29: internal/peering/service.go:209:47: peering.Service.PrepareTransfer calls http2.headerFieldNameError.Error #30: internal/peering/service.go:209:47: peering.Service.PrepareTransfer calls http2.headerFieldValueError.Error #31: internal/peering/service.go:209:47: peering.Service.PrepareTransfer calls http2.pseudoHeaderError.Error #32: internal/spaces/spaces.go:468:2: spaces.Manager.UserStatusByID calls http2.requestBody.Close #33: internal/storage/quota/quota.go:391:20: quota.limitedReader.Read calls http2.requestBody.Read #34: internal/obs/middleware.go:40:10: obs.statusWriter.Flush calls http2.responseWriter.Flush #35: internal/httpx/deadline.go:64:28: httpx.deadlineBody.Read calls http.ResponseController.SetReadDeadline, which calls http2.responseWriter.SetReadDeadline #36: internal/obs/middleware.go:32:34: obs.statusWriter.Write calls http2.responseWriter.Write #37: internal/auth/throttle.go:853:15: auth.WriteThrottled calls http2.responseWriter.WriteHeader #38: internal/sharereport/sharereport.go:44:13: sharereport.CSV calls csv.Writer.Write, which eventually calls http2.responseWriter.WriteString #39: internal/sharereport/sharereport.go:58:9: sharereport.CSV calls csv.Writer.Flush, which eventually calls http2.stickyErrWriter.Write #40: internal/spaces/spaces.go:468:2: spaces.Manager.UserStatusByID calls http2.transportResponseBody.Close #41: internal/storage/s3/s3.go:261:23: s3.object.Read calls http2.transportResponseBody.Read #42: internal/peering/service.go:360:51: peering.Service.ListReceiverSpaces calls fmt.Sprintf, which eventually calls http2.writeData.String Your code is affected by 4 vulnerabilities from 1 module. This scan also found 2 vulnerabilities in packages you import and 4 vulnerabilities in modules you require, but your code doesn't appear to call these vulnerabilities. Use '-show verbose' for more details. ``` Fix recipe (#447): `go get go@patch` on a branch (or bump the affected dependency), full suite green, release, bump dogfoods. --- Filed automatically by the scheduled vulncheck workflow.
Cordy referenced this issue from a commit 2026-10-12 19:29:10 +00:00
Cordy closed this issue 2026-10-12 19:33:30 +00:00
Owner

Fixed in v0.6.334 (PR #885): golang.org/x/net v0.60.0, and the go-tidy run raised golang.org/x/crypto to v0.57.0. Both dogfoods are bumped.

After the merge I dispatched vulncheck on main:

Your code is affected by 0 vulnerabilities.
vulncheck: CLEAN (0 reachable)

Together with #875 (Go 1.26.9), main is clean.

Fixed in v0.6.334 (PR #885): `golang.org/x/net` v0.60.0, and the go-tidy run raised `golang.org/x/crypto` to v0.57.0. Both dogfoods are bumped. After the merge I dispatched `vulncheck` on main: ``` Your code is affected by 0 vulnerabilities. vulncheck: CLEAN (0 reachable) ``` Together with #875 (Go 1.26.9), main is clean.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#884
No description provided.