Space renames: legal holds, retention windows and Deleted files across a rename #918

Open
opened 2026-10-15 20:59:30 +00:00 by Cordy · 0 comments
Owner

Follow-ups from the fix-911 build and reviews (v0.6.345). The plan list is in docs/superpowers/plans/2026-10-15-fix-911.md, under "Open separate issues".

  1. Legal hold blocks convergence. A legal hold anywhere in a space stops its folder from converging after a rename, because the hold layer refuses renaming a folder that contains a held path. The old name then stays the folder and cannot be retired (alias-in-use) while the hold lasts. Today this is documented in spaces-rename.md. Decide whether convergence should be allowed to move held content (it is a rename, not a change).
  2. Retention windows don't follow a rename. Items deleted after convergence are recorded at the new path, so a window set on the old name doesn't cover them. A window typed on the new name misses entries recorded before the folder converges.
  3. Holds on an intermediate name. After renames A to B to C, a hold placed while the space was named B doesn't protect trash entries recorded under A. The trash only checks the recorded path and the current path.
  4. Restoring a whole space root. When someone deleted /spaces/Old itself, it went to per-user trash. After the space was renamed and its folder converged, restoring it lands at /spaces/Old, a folder no space points at.
  5. Orphan folders under /spaces/: needs a cleanup or an admin listing.

Research first: should holds and retention be keyed by space ID plus relative path instead of the storage path?

Follow-ups from the fix-911 build and reviews (v0.6.345). The plan list is in `docs/superpowers/plans/2026-10-15-fix-911.md`, under "Open separate issues". 1. **Legal hold blocks convergence.** A legal hold anywhere in a space stops its folder from converging after a rename, because the hold layer refuses renaming a folder that contains a held path. The old name then stays the folder and cannot be retired (`alias-in-use`) while the hold lasts. Today this is documented in spaces-rename.md. Decide whether convergence should be allowed to move held content (it is a rename, not a change). 2. **Retention windows don't follow a rename.** Items deleted after convergence are recorded at the new path, so a window set on the old name doesn't cover them. A window typed on the new name misses entries recorded before the folder converges. 3. **Holds on an intermediate name.** After renames A to B to C, a hold placed while the space was named B doesn't protect trash entries recorded under A. The trash only checks the recorded path and the current path. 4. **Restoring a whole space root.** When someone deleted `/spaces/Old` itself, it went to per-user trash. After the space was renamed and its folder converged, restoring it lands at `/spaces/Old`, a folder no space points at. 5. **Orphan folders under `/spaces/`:** needs a cleanup or an admin listing. Research first: should holds and retention be keyed by space ID plus relative path instead of the storage path?
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#918
No description provided.