Space names: validSpaceName ignores a custom read-only suffix #930

Closed
opened 2026-10-15 22:28:25 +00:00 by Cordy · 1 comment
Owner

Found while writing the fix-923 spec (§13, 2026-10-16).

What happens: validSpaceName refuses names that end in the default -ro suffix, but not names that end in a custom auth.spaceReadOnlySuffix. On an instance with a custom suffix, a space can be created whose name collides with the read-only group form of another space's name.

To do: use the configured suffix, and test with a custom one.

Found while writing the fix-923 spec (§13, 2026-10-16). **What happens:** `validSpaceName` refuses names that end in the default `-ro` suffix, but not names that end in a custom `auth.spaceReadOnlySuffix`. On an instance with a custom suffix, a space can be created whose name collides with the read-only group form of another space's name. **To do:** use the configured suffix, and test with a custom one.
Cordy closed this issue 2026-10-19 04:46:45 +00:00
Author
Owner

Shipped in v0.6.350 (PR #970). The merge closed this issue automatically without a result comment, so here it is.

What changed:

  • New names: the configured auth.spaceReadOnlySuffix now applies to every new space name: create, the new name of a rename, and a group's space.
  • Existing names: an existing space whose name already ends in the suffix stays manageable and can be renamed away. Cairn logs WARN spaces: name ends in the read-only suffix; rename it, rate-limited.
  • Custom suffix and "-ro": with a custom suffix, "-ro" names are allowed.

Not exercised live: both dogfoods use the default suffix, so the custom-suffix case was checked by tests on posix and s3, including power mode. After the upgrade neither instance logged the new WARN, so no existing space name ends in the suffix.

**Shipped in v0.6.350 (PR #970).** The merge closed this issue automatically without a result comment, so here it is. **What changed:** - **New names:** the configured `auth.spaceReadOnlySuffix` now applies to every new space name: create, the new name of a rename, and a group's space. - **Existing names:** an existing space whose name already ends in the suffix stays manageable and can be renamed away. Cairn logs WARN `spaces: name ends in the read-only suffix; rename it`, rate-limited. - **Custom suffix and "-ro":** with a custom suffix, "-ro" names are allowed. **Not exercised live:** both dogfoods use the default suffix, so the custom-suffix case was checked by tests on posix and s3, including power mode. After the upgrade neither instance logged the new WARN, so no existing space name ends in the suffix.
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#930
No description provided.