Membership rule: a group named "X-ro" grants write on a space named "X-ro" #933

Closed
opened 2026-10-15 23:08:16 +00:00 by Cordy · 3 comments
Owner

Found in fix-923 Task 3 (2026-10-16).

What happens: a member of a group named Ops-ro gets write access to a space or folder named Ops-ro. That happens through the file tree, and since fix-923 through the space gate too. The membership rule reads group X as write on X and X-ro as read on X. For a space whose own name ends in the read-only suffix, the same group matches both readings, and write wins.

Effects:

  • The new space list (fix-923) never shows such a space, so the list and the gate disagree on that one name.
  • A group meant to be read-only grants write on its own name, which looks unintended.

To decide (research first):

  • Should space names ending in the read-only suffix be refused everywhere (app spaces already are, #930 covers custom suffixes)?
  • Or should X-ro on a space named X-ro grant read only?
  • Check IdP and power-mode folders that may already exist with such names.
Found in fix-923 Task 3 (2026-10-16). **What happens:** a member of a group named `Ops-ro` gets write access to a space or folder named `Ops-ro`. That happens through the file tree, and since fix-923 through the space gate too. The membership rule reads group `X` as write on `X` and `X-ro` as read on `X`. For a space whose own name ends in the read-only suffix, the same group matches both readings, and write wins. **Effects:** - The new space list (fix-923) never shows such a space, so the list and the gate disagree on that one name. - A group meant to be read-only grants write on its own name, which looks unintended. **To decide (research first):** - Should space names ending in the read-only suffix be refused everywhere (app spaces already are, #930 covers custom suffixes)? - Or should `X-ro` on a space named `X-ro` grant read only? - Check IdP and power-mode folders that may already exist with such names.
Author
Owner

#1002 research (2026-10-26), research-1002-1-cairn.md §1.3 and §3.6:

  • SpacesOf strips the suffix from every group (membership.go:260-264), so group Ops-ro lists space Ops and never Ops-ro. The listing and the access gate disagree. VERIFIED.
  • Same family as Keycloak CVE-2026-18203: a name-prefix check without a boundary.

Options for the decision with #1002:

  1. Refuse a directory space name that ends in -ro (small, stage 1).
  2. Replace the naming convention with an explicit binding per space: each space record holds a group reference and a role (read or write). The -ro twin is only proposed when the space is created (stage 2).
#1002 research (2026-10-26), `research-1002-1-cairn.md` §1.3 and §3.6: - `SpacesOf` strips the suffix from every group (membership.go:260-264), so group `Ops-ro` lists space `Ops` and never `Ops-ro`. The listing and the access gate disagree. VERIFIED. - Same family as Keycloak CVE-2026-18203: a name-prefix check without a boundary. Options for the decision with #1002: 1. Refuse a directory space name that ends in `-ro` (small, stage 1). 2. Replace the naming convention with an explicit binding per space: each space record holds a group reference and a role (read or write). The `-ro` twin is only proposed when the space is created (stage 2).
Author
Owner

Decision (Nikola, 2026-10-26): each directory space gets an explicit binding (which group gives write, which gives read). The -ro twin is only proposed when the space is created, and the suffix rule goes away. Until then, stage 1 of #1002 (v0.6.355) refuses new directory space names ending in -ro. The rest is built in the #1002 stage 2+3 batch.

**Decision (Nikola, 2026-10-26):** each directory space gets an explicit binding (which group gives write, which gives read). The `-ro` twin is only proposed when the space is created, and the suffix rule goes away. Until then, stage 1 of #1002 (v0.6.355) refuses new directory space names ending in `-ro`. The rest is built in the #1002 stage 2+3 batch.
Author
Owner

Released in v0.6.357 (PR #1015).

  • Read/write binding: each directory space has an explicit write group and read group, chosen in the space panel, and the -ro suffix rule is retired.
  • Names ending in -ro: allowed again through "New directory space…", because the name no longer carries meaning.
  • Upgrade: binds an existing -ro twin as the read group only when exactly one group matches.

Closing.

Released in **v0.6.357** (PR #1015). - **Read/write binding:** each directory space has an explicit write group and read group, chosen in the space panel, and the `-ro` suffix rule is retired. - **Names ending in `-ro`:** allowed again through "New directory space…", because the name no longer carries meaning. - **Upgrade:** binds an existing `-ro` twin as the read group only when exactly one group matches. Closing.
Cordy closed this issue 2026-10-26 18:03:23 +00:00
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#933
No description provided.