Versions: overlapping saves published out of key order age the earlier one from the wrong time #958

Open
opened 2026-10-17 20:07:46 +00:00 by Cordy · 0 comments
Owner

Found in the batch 2 re-review (#946 fix round 4, 2026-10-17).

What happens

A save names its version record (and with it the key time) before it publishes. Two overlapping saves of one file can therefore publish out of key order: save X names its record first, save Y names its record later but publishes first, then X publishes. The chain's key order then disagrees with the order in which the contents were current. A version's age runs from the next newer entry (#946), so the content that was replaced can age from the wrong time.

The reviewer reproduced this on all five rigs with two plain overlapping saves; no move is needed. A failed recorded move (#946 round 4: the destination's content gets a fresh record with the newest key) is one more way to trigger it.

Effect

A version can expire before its policy age; in the probe it was about 60 days early. It needs overlapping saves of one file, which is rare on one instance. The per-path serializer orders commits, but not the key times, which are named before the commit.

To decide

  1. Name the key time at commit, under the lock, so key order equals publish order. On S3 the record PUT happens before the lock (D2), so the record would have to be renamed at commit.
  2. Or let ageCut read publish order from somewhere else.
  3. Or document the window.

Needs research by the playbook first.

Found in the batch 2 re-review (#946 fix round 4, 2026-10-17). ## What happens A save names its version record (and with it the key time) before it publishes. Two overlapping saves of one file can therefore publish out of key order: save X names its record first, save Y names its record later but publishes first, then X publishes. The chain's key order then disagrees with the order in which the contents were current. A version's age runs from the next newer entry (#946), so the content that was replaced can age from the wrong time. The reviewer reproduced this on all five rigs with two plain overlapping saves; no move is needed. A failed recorded move (#946 round 4: the destination's content gets a fresh record with the newest key) is one more way to trigger it. ## Effect A version can expire before its policy age; in the probe it was about 60 days early. It needs overlapping saves of one file, which is rare on one instance. The per-path serializer orders commits, but not the key times, which are named before the commit. ## To decide 1. Name the key time at commit, under the lock, so key order equals publish order. On S3 the record PUT happens before the lock (D2), so the record would have to be renamed at commit. 2. Or let ageCut read publish order from somewhere else. 3. Or document the window. Needs research by the playbook first.
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#958
No description provided.