v0.6.366: shared-folder rules (#983, #973, #978, #981) #1032

Merged
Cordy merged 13 commits from rc2 into main 2026-10-28 01:35:45 +00:00
Owner

Batch C2, decisions in the issue comments of 2026-10-28.

  • #983: grants on space content removed at start (audit share-grant-retired) and never served or listed.
  • #973: grantees can't delete, move or overwrite the top folder or shared file of a share (403 share-root); the web hides those actions.
  • #978: the home owner breaks locks (confirm, bell lock-broken); a lock stops counting once its holder can no longer write (incl. deleted/re-created accounts), lock-released audit.
  • #981: account start hides a predecessor's Activity (local and directory, first-signins.json); transfers carry history, only the two owners' events into a shared destination.
  • German "Lizenzen"; "Mitteilung des Administrators".

Two reviews and two fix rounds; full suite, vet, gofmt and web suite green locally.

Batch C2, decisions in the issue comments of 2026-10-28. - #983: grants on space content removed at start (audit share-grant-retired) and never served or listed. - #973: grantees can't delete, move or overwrite the top folder or shared file of a share (403 share-root); the web hides those actions. - #978: the home owner breaks locks (confirm, bell lock-broken); a lock stops counting once its holder can no longer write (incl. deleted/re-created accounts), lock-released audit. - #981: account start hides a predecessor's Activity (local and directory, first-signins.json); transfers carry history, only the two owners' events into a shared destination. - German "Lizenzen"; "Mitteilung des Administrators". Two reviews and two fix rounds; full suite, vet, gofmt and web suite green locally.
A re-created account no longer sees the Activity of its home from before
its epoch, nor do the people it shares with; administrators still do.
Local accounts: CreatedAt. Directory accounts: first-signins.json (new
state file, statePaths), one record per username with the first sign-in
and the IdP subject (OIDC sub at the callback, the LDAP entry's
ldapGroupIdAttr value at a bind); a different subject of the same
provider starts a new epoch (WARN, rate-limited per username). The record
is read-merge-written per change, Epoch reads a 30 s snapshot, the
known-subject cache is bounded (#742). #654 can reuse the record.

An ownership transfer (everything or shares only) now carries everyone's
Activity events to the new paths (activity.Store.Carry), stamping when
they came in so the successor's own epoch does not hide them; events
from before the departed account's epoch stay behind.
#983: the start removes every share grant on a /spaces path (share
store RemoveGrants, deciding on the file as read), one
share-grant-retired audit line each (admin tier) and a WARN; the scope
overlay never serves a grant on space content (guard in userGrants,
used by /shared and the change feed; WARN once per grant); a whole-space
Activity move asks the rename exposure check (ActExposed) and moves
nothing when exposed, with a WARN.

#973: deleting the top folder of a share, moving it away or moving
something onto it through the grant is refused (scope ErrShareRoot,
REST and WebDAV 403 share-root, the owner in the REST body); the row
menu hides Delete, Move and Rename on a share root; errShareRoot in EN,
DE, FR, IT.

Strings: German licence seats read Lizenzen in every seat text;
rstColMsg is Mitteilung des Administrators like rstHistMsg; the i18n
glossary says Lizenzen.

Existing tests changed on purpose (grants on space content are no
longer served): sharedview974 space case, changes974 wes, activity971move
space cases (carol's view replaced by bob's), actor915 space grant
subtest; appendctx864 gets the start-time exemption.
Cordy merged commit 5419ff8b15 into main 2026-10-28 01:35:45 +00:00
Cordy deleted branch rc2 2026-10-28 01:35:49 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#1032
No description provided.