fix(peering): pin gRPC dial target to scheme-appropriate port (#140) #141

Merged

Cordy merged 1 commit from fix/peering-dial-port into main

2026-08-09 00:46:14 +00:00

Cordy commented

2026-08-09 00:45:59 +00:00

Owner

Closes #140. Client.dial passed u.Host (portless for bare URLs) to grpc.NewClient, whose resolver defaults to 443 regardless of scheme — every plain-HTTP LAN peer dialed 443. New grpcTarget(u): explicit port wins, else http→80, https→443. Unit test over all four cases. Found live on the first real A↔B transfer; the loopback test injects Client.Dial and never exercised this path.

Closes #140. `Client.dial` passed `u.Host` (portless for bare URLs) to `grpc.NewClient`, whose resolver defaults to 443 regardless of scheme — every plain-HTTP LAN peer dialed 443. New `grpcTarget(u)`: explicit port wins, else http→80, https→443. Unit test over all four cases. Found live on the first real A↔B transfer; the loopback test injects `Client.Dial` and never exercised this path.

Cordy added 1 commit

2026-08-09 00:46:00 +00:00