fix(#175): three-dot Share dialog opens again; viewer explains insecure-context instead of importKey error #188

Merged

Cordy merged 6 commits from fix-share-viewer into main

2026-08-10 20:59:25 +00:00

Cordy commented

2026-08-10 20:59:06 +00:00

Owner

Two dogfood findings on v0.6.4:

Menu "Share" did nothing (#175·1). openShareDialog referenced an undefined r (r.mode) right before showModal(), so the click threw and the dialog never opened — which is also why only copy-link shares appeared in the Shares view (menu-Share created nothing). Same ReferenceError class as #131. Now reads the selected mode; the dialog opens.
Viewer threw Cannot read properties of undefined (reading 'importKey') on the plain-HTTP dogfood. typage decrypts with Web Crypto (crypto.subtle), which browsers make undefined on insecure origins. The viewer now detects that up front and shows a clear "needs an HTTPS link" message instead of the raw exception. Production shares are HTTPS and were never affected — this is graceful failure for plain-HTTP internal instances.

Plus the fragment-mode "anyone with the complete link can open it" warning (en/de/fr/it). node --check on all script blocks + go build/test green. CHANGELOG v0.6.5.

Two dogfood findings on v0.6.4: 1. **Menu "Share" did nothing (#175·1).** `openShareDialog` referenced an undefined `r` (`r.mode`) right before `showModal()`, so the click threw and the dialog never opened — which is also why only copy-link shares appeared in the Shares view (menu-Share created nothing). Same ReferenceError class as #131. Now reads the selected mode; the dialog opens. 2. **Viewer threw `Cannot read properties of undefined (reading 'importKey')` on the plain-HTTP dogfood.** typage decrypts with Web Crypto (`crypto.subtle`), which browsers make `undefined` on insecure origins. The viewer now detects that up front and shows a clear "needs an HTTPS link" message instead of the raw exception. Production shares are HTTPS and were never affected — this is graceful failure for plain-HTTP internal instances. Plus the fragment-mode "anyone with the complete link can open it" warning (en/de/fr/it). node --check on all script blocks + go build/test green. CHANGELOG v0.6.5.

Cordy added 6 commits

2026-08-10 20:59:07 +00:00