v0.6.13: remove vestigial scope.admins field + New param (#177 follow-up) #200

Merged

Cordy merged 5 commits from ship-v0.6.13 into main

2026-08-12 01:33:19 +00:00

Cordy commented

2026-08-12 01:31:59 +00:00

Owner

Pure internal tidy, no behaviour change.

Since #177 scoped admins exactly like regular users, scope.Driver.admins and the admins parameter of scope.New(inner, admins) were dead — kept only so call sites didn't have to change. This removes both: the struct field, the constructor parameter, the now-false doc sentence about "retained for call-site compatibility", and a stale test comment referencing the admins map.

Call sites were rewritten with gofmt -r (AST-correct): scope.New(a, b) -> scope.New(a) for external callers (8 in scope_test.go, 1 in cmd/cairnd/main.go), plus New(a, b) -> New(a) inside the scope package for the white-box scope_ro_test.go (2). go vet, full go test ./..., and the dual-arch build all pass.

No image/dogfood redeploy needed — this is a no-op refactor; the next functional release carries it.

Pure internal tidy, no behaviour change. Since #177 scoped admins exactly like regular users, `scope.Driver.admins` and the `admins` parameter of `scope.New(inner, admins)` were dead — kept only so call sites didn't have to change. This removes both: the struct field, the constructor parameter, the now-false doc sentence about "retained for call-site compatibility", and a stale test comment referencing the admins map. Call sites were rewritten with `gofmt -r` (AST-correct): `scope.New(a, b) -> scope.New(a)` for external callers (8 in `scope_test.go`, 1 in `cmd/cairnd/main.go`), plus `New(a, b) -> New(a)` inside the scope package for the white-box `scope_ro_test.go` (2). `go vet`, full `go test ./...`, and the dual-arch build all pass. No image/dogfood redeploy needed — this is a no-op refactor; the next functional release carries it.

Cordy added 5 commits

2026-08-12 01:32:00 +00:00