fix(spaces): parse members JSON in the dialog (#210) #229

Merged

Cordy merged 3 commits from hotfix-members-json into main

2026-08-13 17:33:17 +00:00

Cordy commented

2026-08-13 17:32:59 +00:00

Owner

Live-dogfood hotfix. Opening a space's Members dialog threw data.members is not iterable and rendered nothing.

Cause: refreshMembers did const data = await api(...) — but api() returns the raw Response, so data.members was undefined. (GET /members returns 200 with {owner, members:[]} correctly; it was only the client that never parsed it.) This is a pre-existing bug in the members dialog, surfaced now that app-owned spaces make the dialog reachable everywhere (#210/#211).

One-line fix: await (await api(...)).json(). This also feeds my #217 owner/member-set validation (which read data.owner/data.members). node --check clean.

Verified live: create-space works, feature-detect shows the Members button, error-surfacing showed the real JS error. Re-testing the full members flow after this deploys.

Live-dogfood hotfix. Opening a space's **Members** dialog threw `data.members is not iterable` and rendered nothing. Cause: `refreshMembers` did `const data = await api(...)` — but `api()` returns the raw `Response`, so `data.members` was `undefined`. (`GET /members` returns `200` with `{owner, members:[]}` correctly; it was only the client that never parsed it.) This is a pre-existing bug in the members dialog, surfaced now that app-owned spaces make the dialog reachable everywhere (#210/#211). One-line fix: `await (await api(...)).json()`. This also feeds my #217 owner/member-set validation (which read `data.owner`/`data.members`). `node --check` clean. Verified live: create-space works, feature-detect shows the Members button, error-surfacing showed the real JS error. Re-testing the full members flow after this deploys.

Cordy added 3 commits

2026-08-13 17:32:59 +00:00