Cordy/Cairn
2
1
Fork 0
Code Issues 20 Pull requests Projects Releases Packages Wiki Activity Actions

#306: admin Save no longer wipes peeringEnabled — saveSettings merges over serverSettings #307

Merged
Cordy merged 3 commits from fix/set62 into main 2026-08-21 17:01:42 +00:00
Conversation 0 Commits 3 Files changed 2 +9 -2
Cordy commented 2026-08-21 16:59:26 +00:00
Owner
Copy link

Fixes the "peering turns off after redeployment" dogfood finding: the trigger was any admin Save, not the redeploy. saveSettings sent a hand-built partial object to PUT /api/v1/settings (replace semantics), zeroing peeringEnabled, peeringExpandGroups, peeringMaxFileBytes, peeringBaseUrl. Now it merges its form fields over serverSettings — the same pattern the peering toggle already used — so all non-form fields (present and future) survive.

Full diagnosis on #306. Frontend-only.

Fixes the "peering turns off after redeployment" dogfood finding: the trigger was any admin **Save**, not the redeploy. `saveSettings` sent a hand-built partial object to `PUT /api/v1/settings` (replace semantics), zeroing `peeringEnabled`, `peeringExpandGroups`, `peeringMaxFileBytes`, `peeringBaseUrl`. Now it merges its form fields over `serverSettings` — the same pattern the peering toggle already used — so all non-form fields (present and future) survive. Full diagnosis on #306. Frontend-only.
Cordy merged commit 9efcce43d5 into main 2026-08-21 17:01:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#307
No description provided.
Delete branch "fix/set62"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?