fix(admin): purge tab survives revisits, overview reads fresh, peering joins the save bar, preview yields to admin #372

Merged

Cordy merged 6 commits from fix/hotfixes-2 into main

2026-08-28 18:26:19 +00:00

Cordy commented

2026-08-28 18:26:05 +00:00

Owner

Four dogfood findings.

Manual purge dead on revisit: the purge-all button is moved into the list when it renders; the re-render's wipe destroyed it and the next visit threw on a null before drawing anything (reproduced live — stack trace at the allBtn deref, line 3678). It's parked outside the list before the wipe now.
Overview staleness: the page claims values are read from the server but rendered a cached serverSettings — a just-saved audit toggle still read Off. It refetches settings on every render.
Save bar everywhere: the two peering global toggles were the last instantly-saving settings; they now participate in the pending-changes save bar (scope/field selectors learned .peerpane/.prow), with one Save merging both over serverSettings (#306). Settings persist via the settings store on /data, so they survive redeployments.
Preview vs admin: opening Administration closes an open file preview.

Four dogfood findings. - **Manual purge dead on revisit:** the purge-all button is *moved into* the list when it renders; the re-render's wipe destroyed it and the next visit threw on a null before drawing anything (reproduced live — stack trace at the `allBtn` deref, line 3678). It's parked outside the list before the wipe now. - **Overview staleness:** the page claims values are read from the server but rendered a cached `serverSettings` — a just-saved audit toggle still read Off. It refetches settings on every render. - **Save bar everywhere:** the two peering global toggles were the last instantly-saving settings; they now participate in the pending-changes save bar (scope/field selectors learned `.peerpane`/`.prow`), with one Save merging both over serverSettings (#306). Settings persist via the settings store on /data, so they survive redeployments. - **Preview vs admin:** opening Administration closes an open file preview.

Cordy added 6 commits

2026-08-28 18:26:06 +00:00

scout: hotfix-round anchors 9b549457dc

scout: bodies for the hotfixes 16a4efc074

scout: loadTrashPurge tail 0ac1756f01

one-shot: hotfix round splices d48f457a6c

one-shot: disambiguate the overview settings anchor b723a8cd29

fix(admin): purge tab survives revisits, overview reads fresh, peering joins the save bar, preview yields to admin

ci / test-and-build (pull_request) Successful in 38s

Details

876c33c526

Manual purge: the purge-all button is MOVED into the list when it
renders; the re-render's list wipe destroyed it and the next visit
threw on a null before drawing anything (reproduced live with the
stack trace at the allBtn deref). It is parked outside the list
before the wipe now.

Overview claimed values are read from the server, but rendered from a
cached serverSettings -- a just-saved audit toggle still read Off. It
refetches settings on every render.

The two peering global toggles were the last instantly-saving admin
settings; they now participate in the pending-changes save bar (scope
and field selectors learned .peerpane/.prow), with one Save that
merges both over serverSettings (#306). Settings persist in the
state backend, so the choice survives redeployments.

Opening Administration closes an open file preview.