Locks: admin-configurable expiry cap for manual locks (#394) #397

Merged

Cordy merged 10 commits from lock-cap into main 2026-09-02 20:08:47 +00:00

Conversation 0 Commits 10 Files changed 7 +110 -3

Cordy commented 2026-09-02 20:08:33 +00:00

Owner

Copy link

Implements #394 (deferred L4 from #315).

• lockMaxHours setting (0 = off, the default) with validation, persisted with the rest of the settings.
• filelock.Store.SetMaxAge hook: a policy lens consulted at liveness checks (Live/List/rename-carry) for user-type locks only. Existing locks are affected immediately by a settings change, and turning the cap off revives them — the policy is never baked into stored records (save-time pruning still uses only a dav lock's own Expires). Dav locks keep their RFC timeouts.
• Wired in main.go from the settings store; no restart needed.
• Admin UI: "Manual lock expiry (hours)" number field in Basic settings (shared set-* field relocation), load/save through the existing merge-over-serverSettings PUT, i18n ×4.
• Tests: cap semantics (old manual lock lapses, fresh one and dav lock unaffected, cap-off revives), settings validation, mutation check on the age comparison.

Closes #394.

Implements #394 (deferred L4 from #315). - `lockMaxHours` setting (0 = off, the default) with validation, persisted with the rest of the settings. - `filelock.Store.SetMaxAge` hook: a policy lens consulted at liveness checks (`Live`/`List`/rename-carry) for `user`-type locks only. Existing locks are affected immediately by a settings change, and turning the cap off revives them — the policy is never baked into stored records (save-time pruning still uses only a dav lock's own `Expires`). Dav locks keep their RFC timeouts. - Wired in `main.go` from the settings store; no restart needed. - Admin UI: "Manual lock expiry (hours)" number field in Basic settings (shared `set-*` field relocation), load/save through the existing merge-over-serverSettings PUT, i18n ×4. - Tests: cap semantics (old manual lock lapses, fresh one and dav lock unaffected, cap-off revives), settings validation, mutation check on the age comparison. Closes #394.

Cordy added 10 commits 2026-09-02 20:08:34 +00:00

scout: settings package + main wiring + admin settings UI anchors (#394) b83e3b3e95

scout dumps for #394 fdb76a3d8d

scout 2: basic settings panel + save handler windows (#394) 28683109c5

scout 2 dumps for #394 1b6d6925c6

scout 3: basic fields markup + adm-basic-fields population (#394) 0a2968160c

scout 3 dumps for #394 2663a2609d

one-shot: manual-lock expiry cap - setting, hook, admin row (#394) 9a48f60d8d

fixer: regex main anchor + post counts for oneshot-cap-a 0ff3344921

fix oneshot-cap-a: regex main anchor, corrected post counts 2567a0d37e

feat(locks): admin-configurable expiry cap for manual locks (#394) 094f844f85

Cordy merged commit 8843886870 into main 2026-09-02 20:08:47 +00:00

Cordy referenced this pull request from a commit 2026-09-02 20:08:48 +00:00

Merge pull request 'Locks: admin-configurable expiry cap for manual locks (#394)' (#397) from lock-cap into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#397

No description provided.